Skip to content

[fix](cloud) fix core dump in CloudWarmUpManager::handle_jobs - #43262

Merged
dataroaring merged 3 commits into
apache:masterfrom
freemandealer:fix-handle-jobs-core
Nov 7, 2024
Merged

[fix](cloud) fix core dump in CloudWarmUpManager::handle_jobs#43262
dataroaring merged 3 commits into
apache:masterfrom
freemandealer:fix-handle-jobs-core

Conversation

@freemandealer

@freemandealerfreemandealer commented Nov 5, 2024•
edited by gavinchou
Loading

Copy link
Copy Markdown
Member

use smart pointer to control the lifespan of JobMeta to avoid nullptr

@freemandealer
[fix](cloud) fix core dump in CloudWarmUpManager::handle_jobs
2201360
use smart pointer to control the lifespan of JobMeta to avoid nullptr
Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
@doris-robot

doris-robot commented Nov 5, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@freemandealer

freemandealer commented Nov 5, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

github-actionsBot commented Nov 5, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Nov 5, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.86% (9836/25983)
Line Coverage: 29.02% (81823/281917)
Region Coverage: 28.26% (42171/149234)
Branch Coverage: 24.84% (21398/86156)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2201360198f19eebff0110ce8d79b5a525137dfd_2201360198f19eebff0110ce8d79b5a525137dfd/report/index.html

@freemandealer

freemandealer commented Nov 5, 2024

Copy link
Copy Markdown
MemberAuthor

run p0

@freemandealer

freemandealer commented Nov 5, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

github-actionsBot commented Nov 5, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@freemandealer

freemandealer commented Nov 6, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

github-actionsBot commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Nov 6, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.86% (9836/25982)
Line Coverage: 29.03% (81817/281851)
Region Coverage: 28.26% (42154/149159)
Branch Coverage: 24.85% (21396/86096)
Coverage Report: http://coverage.selectdb-in.cc/coverage/60547049289c19517c755883850a12677c51d867_60547049289c19517c755883850a12677c51d867/report/index.html

@github-actions

github-actionsBot commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 6, 2024
@github-actions

github-actionsBot commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Nov 7, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 9bbe042 into apache:masterNov 7, 2024
github-actionsBot pushed a commit that referenced this pull request Nov 7, 2024
@freemandealerYour Name
[fix](cloud) fix core dump in CloudWarmUpManager::handle_jobs (#43262)
9a36ec6
use smart pointer to control the lifespan of JobMeta to avoid nullptr
Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Nov 7, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 8, 2024
@github-actions@freemandealer
branch-3.0: [fix](cloud) fix core dump in CloudWarmUpManager::handle_…
4f81a8e
…jobs (#43404)
Cherry-picked from #43262
Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
Co-authored-by: zhengyu <freeman.zhang1992@gmail.com>
@XLPEXLPE mentioned this pull request Jun 27, 2025
Closed
16 tasks
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@freemandealer@HappenLee
[fix](cloud) fix core dump in CloudWarmUpManager::handle_jobs (apache…
ae83a48
…#43262)
use smart pointer to control the lifespan of JobMeta to avoid nullptr
Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchougavinchougavinchou approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@freemandealer@doris-robot@gavinchou@dataroaring