[fix](build index)Fix build index empty index file on renamed column by qidaye · Pull Request #43336 · apache/doris

qidaye · 2024-11-06T07:03:36Z

What problem does this PR solve?

This PR is a followup repair on the basis of #42882.
Building index on renamed column will produce an empty index file, when column_idx is not found.
The query is successful because match without inverted index.
Move test_match_without_index to fault_injection folder and make it non-concurrent to avoid concurrency issues.

Check List (For Committer)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No colde files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.
Release note
Fix build index empty index file on renamed column

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

doris-robot · 2024-11-06T07:03:40Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

qidaye · 2024-11-06T07:03:44Z

run buildall

github-actions · 2024-11-06T07:08:04Z

clang-tidy review says "All clean, LGTM! 👍"

airborne12

LGTM

github-actions · 2024-11-06T07:12:44Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-11-06T07:12:46Z

PR approved by anyone and no changes requested.

doris-robot · 2024-11-06T08:02:25Z

TeamCity be ut coverage result:
Function Coverage: 37.89% (9848/25989)
Line Coverage: 29.05% (81909/281913)
Region Coverage: 28.28% (42190/149187)
Branch Coverage: 24.85% (21401/86112)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1153202c6600c1950557cce4dce1c6ea2b75eb52_1153202c6600c1950557cce4dce1c6ea2b75eb52/report/index.html

…on-concurrent

qidaye · 2024-11-06T09:33:54Z

run buildall

github-actions · 2024-11-06T09:34:46Z

clang-tidy review says "All clean, LGTM! 👍"

airborne12

LGTM

csun5285

LGTM

github-actions · 2024-11-06T09:58:49Z

PR approved by at least one committer and no changes requested.

doris-robot · 2024-11-06T10:10:55Z

TeamCity be ut coverage result:
Function Coverage: 37.88% (9849/26000)
Line Coverage: 29.04% (81909/282037)
Region Coverage: 28.27% (42191/149244)
Branch Coverage: 24.85% (21404/86140)
Coverage Report: http://coverage.selectdb-in.cc/coverage/93582f9f8df92d1815fa84aa9862174b0de34772_93582f9f8df92d1815fa84aa9862174b0de34772/report/index.html

qidaye · 2024-11-06T13:43:54Z

run buildall

github-actions · 2024-11-06T13:48:36Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-11-06T14:21:27Z

TeamCity be ut coverage result:
Function Coverage: 37.88% (9848/25998)
Line Coverage: 29.03% (81887/282031)
Region Coverage: 28.26% (42170/149241)
Branch Coverage: 24.84% (21396/86142)
Coverage Report: http://coverage.selectdb-in.cc/coverage/50c01d693196f50e2388bc8b62129bcc6aa8f797_50c01d693196f50e2388bc8b62129bcc6aa8f797/report/index.html

qidaye · 2024-11-06T15:02:59Z

run buildall

qidaye · 2024-11-06T15:04:05Z

run buildall

github-actions · 2024-11-06T15:07:12Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-11-06T15:08:12Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-11-06T15:38:45Z

TeamCity be ut coverage result:
Function Coverage: 37.88% (9848/25998)
Line Coverage: 29.02% (81855/282038)
Region Coverage: 28.25% (42169/149248)
Branch Coverage: 24.84% (21395/86148)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f3a5cf660c52065cc0bf82cf7c7d589028e982d6_f3a5cf660c52065cc0bf82cf7c7d589028e982d6/report/index.html

csun5285

LGTM

airborne12

LGTM

github-actions · 2024-11-07T03:26:04Z

PR approved by at least one committer and no changes requested.

…43336) ### What problem does this PR solve? This PR is a followup repair on the basis of #42882. Building index on renamed column will produce an empty index file, when `column_idx` is not found. The query is successful because match without inverted index. Move test_match_without_index to fault_injection folder and make it non-concurrent to avoid concurrency issues.

…pache#43336) ### What problem does this PR solve? This PR is a followup repair on the basis of apache#42882. Building index on renamed column will produce an empty index file, when `column_idx` is not found. The query is successful because match without inverted index. Move test_match_without_index to fault_injection folder and make it non-concurrent to avoid concurrency issues.

…amed column (#43392) Cherry-picked from #43336 Co-authored-by: qiye <jianliang5669@gmail.com>

…43246)(#43336) (#43266) bp #42882 #43246 #43336 We pick these PRs together because they all fix one problem and if not do so, the regression test won't be passed. --------- Co-authored-by: Sun Chenyang <csun5285@gmail.com> Co-authored-by: qidaye <luen@selectdb.com>

…pache#43336) ### What problem does this PR solve? This PR is a followup repair on the basis of apache#42882. Building index on renamed column will produce an empty index file, when `column_idx` is not found. The query is successful because match without inverted index. Move test_match_without_index to fault_injection folder and make it non-concurrent to avoid concurrency issues.

[fix](build index)Fix build index empty index file on renamed column
1153202

airborne12 previously approved these changes Nov 6, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 6, 2024

github-actionsBot added the reviewed label Nov 6, 2024

move test_match_without_index to fault_injection folder and make it n…
93582f9
…on-concurrent

qidaye dismissed airborne12’s stale review via 93582f9November 6, 2024 09:29

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Nov 6, 2024

airborne12 previously approved these changes Nov 6, 2024
View reviewed changes

csun5285 approved these changes Nov 6, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 6, 2024

set enable_inverted_index_query = true in set_var
50c01d6

qidaye dismissed airborne12’s stale review via 50c01d6November 6, 2024 13:43

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Nov 6, 2024

airborne12 added dev/2.1.x dev/3.0.x labels Nov 6, 2024

fix
61fb786

fix
f3a5cf6

csun5285 approved these changes Nov 7, 2024
View reviewed changes

airborne12 approved these changes Nov 7, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 7, 2024

airborne12 merged commit 585759a into apache:masterNov 7, 2024

github-actionsBot mentioned this pull request Nov 7, 2024
branch-3.0: [fix](build index)Fix build index empty index file on renamed column #43392
Merged

github-actionsBot added the cherry-pick-conflict-in-2.1.x label Nov 7, 2024

qidaye deleted the fix_build_index_empty_index branch November 7, 2024 03:32

qidaye mentioned this pull request Nov 7, 2024
[fix](build index)Fix build index failed on renamed column (#42882)(#43246)(#43336) #43266
Merged

qidaye added a commit that referenced this pull request Nov 7, 2024
branch-3.0: [fix](build index)Fix build index empty index file on ren…
12ced58
…amed column (#43392) Cherry-picked from #43336 Co-authored-by: qiye <jianliang5669@gmail.com>

qidaye added dev/3.0.3-merged and removed dev/3.0.x cherry-pick-conflict-in-2.1.x labels Nov 7, 2024

qidaye added dev/2.1.8-merged and removed dev/2.1.x labels Nov 7, 2024

Uh oh!

Conversation

qidaye commented Nov 6, 2024• edited by airborne12 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Check List (For Committer)

Check List (For Reviewer who merge this PR)

Uh oh!

doris-robot commented Nov 6, 2024

Uh oh!

qidaye commented Nov 6, 2024

Uh oh!

github-actionsBot commented Nov 6, 2024

Uh oh!

airborne12 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Nov 6, 2024

Uh oh!

github-actionsBot commented Nov 6, 2024

Uh oh!

doris-robot commented Nov 6, 2024

Uh oh!

qidaye commented Nov 6, 2024

Uh oh!

github-actionsBot commented Nov 6, 2024

Uh oh!

airborne12 left a comment

Choose a reason for hiding this comment

Uh oh!

csun5285 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Nov 6, 2024

Uh oh!

doris-robot commented Nov 6, 2024

Uh oh!

qidaye commented Nov 6, 2024

Uh oh!

github-actionsBot commented Nov 6, 2024

Uh oh!

doris-robot commented Nov 6, 2024

Uh oh!

qidaye commented Nov 6, 2024

Uh oh!

qidaye commented Nov 6, 2024

Uh oh!

github-actionsBot commented Nov 6, 2024

Uh oh!

github-actionsBot commented Nov 6, 2024

Uh oh!

doris-robot commented Nov 6, 2024

Uh oh!

csun5285 left a comment

Choose a reason for hiding this comment

Uh oh!

airborne12 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Nov 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

qidaye commented Nov 6, 2024•
edited by airborne12
Loading