Skip to content

[fix](test) fix clickhouse jdbc catalog func with cast push down case - #43348

Merged
zy-kkk merged 1 commit into
apache:masterfrom
zy-kkk:fix_ck_case1106
Nov 7, 2024
Merged

[fix](test) fix clickhouse jdbc catalog func with cast push down case#43348
zy-kkk merged 1 commit into
apache:masterfrom
zy-kkk:fix_ck_case1106

Conversation

@zy-kkk

@zy-kkkzy-kkk commented Nov 6, 2024•
edited
Loading

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #42102

Problem Summary:

When a predicate involves multiple nested functions, there will be some implicit type casts, so it cannot be pushed down. We need to set enable_jdbc_cast_predicate_push_down to true to push down similar predicates.

Check List (For Committer)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

doris-robot commented Nov 6, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zy-kkk

zy-kkk commented Nov 6, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

morningman
morningman approved these changes Nov 7, 2024
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 7, 2024
@github-actions

github-actionsBot commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@zy-kkk
zy-kkk merged commit 60b6e56 into apache:masterNov 7, 2024
@zy-kkk
zy-kkk deleted the fix_ck_case1106 branch November 7, 2024 09:05
github-actionsBot pushed a commit that referenced this pull request Nov 7, 2024
@zy-kkkYour Name
[fix](test) fix clickhouse jdbc catalog func with cast push down case (…
8639bb2
…#43348)
When a predicate involves multiple nested functions, there will be some implicit type casts, so it cannot be pushed down. We need to set `enable_jdbc_cast_predicate_push_down` to true to push down similar predicates.
@github-actionsgithub-actionsBot mentioned this pull request Nov 7, 2024
Merged
github-actionsBot pushed a commit that referenced this pull request Nov 7, 2024
@zy-kkkYour Name
[fix](test) fix clickhouse jdbc catalog func with cast push down case (…
cfc8ccd
…#43348)
When a predicate involves multiple nested functions, there will be some implicit type casts, so it cannot be pushed down. We need to set `enable_jdbc_cast_predicate_push_down` to true to push down similar predicates.
@github-actionsgithub-actionsBot mentioned this pull request Nov 7, 2024
Merged
zy-kkk added a commit that referenced this pull request Nov 11, 2024
@zy-kkk
[fix](test) fix clickhouse jdbc catalog func with cast push down case (…
d95a313
…#43348)
When a predicate involves multiple nested functions, there will be some implicit type casts, so it cannot be pushed down. We need to set `enable_jdbc_cast_predicate_push_down` to true to push down similar predicates.
zy-kkk added a commit that referenced this pull request Nov 11, 2024
@github-actions@zy-kkk
branch-3.0: [fix](test) fix clickhouse jdbc catalog func with cast pu…
982a2b6
…sh down case (#43429)
Cherry-picked from #43348
Co-authored-by: zy-kkk <zhongyongkang@selectdb.com>
morningman pushed a commit that referenced this pull request Nov 11, 2024
@github-actions@zy-kkk
branch-2.1: [fix](test) fix clickhouse jdbc catalog func with cast pu…
541284e
…sh down case (#43431)
Cherry-picked from #43348
Co-authored-by: zy-kkk <zhongyk10@gmail.com>
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@zy-kkk@HappenLee
[fix](test) fix clickhouse jdbc catalog func with cast push down case (…
f19b8ad
…apache#43348)
When a predicate involves multiple nested functions, there will be some implicit type casts, so it cannot be pushed down. We need to set `enable_jdbc_cast_predicate_push_down` to true to push down similar predicates.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes
@wuwenchiwuwenchiwuwenchi approved these changes
@hubgeterhubgeterhubgeter approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.8-mergeddev/3.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zy-kkk@doris-robot@morningman@wuwenchi@hubgeter