Skip to content

[fix](cloud-mow) Fix clear GetDeleteBitmapResponse problem when geting delete bitmap fail and retry - #43358

Merged
dataroaring merged 1 commit into
apache:masterfrom
hust-hhb:fix-clear
Nov 6, 2024
Merged

[fix](cloud-mow) Fix clear GetDeleteBitmapResponse problem when geting delete bitmap fail and retry#43358
dataroaring merged 1 commit into
apache:masterfrom
hust-hhb:fix-clear

Conversation

@hust-hhb

@hust-hhbhust-hhb commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Related PR: #43261

Problem Summary:
pr #43261 doesn't clear GetDeleteBitmapResponse correctly, this pr fix this problem

Check List (For Committer)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

doris-robot commented Nov 6, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@hust-hhb

hust-hhb commented Nov 6, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 6, 2024
@github-actions

github-actionsBot commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@doris-robot

doris-robot commented Nov 6, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.88% (9849/26000)
Line Coverage: 29.03% (81870/282031)
Region Coverage: 28.27% (42194/149243)
Branch Coverage: 24.85% (21401/86138)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e746e1ab46e526f3ca3033f54ba6479ead25bc20_e746e1ab46e526f3ca3033f54ba6479ead25bc20/report/index.html

dataroaring
dataroaring approved these changes Nov 6, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit a586bac into apache:masterNov 6, 2024
@hust-hhbhust-hhb mentioned this pull request Nov 7, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 8, 2024
@hust-hhb
[fix](cloud-mow) Fix clear GetDeleteBitmapResponse problem when getin…
e30560b
…g delete bitmap fail and retry (#43457)
pr #43261 doesn't clear
GetDeleteBitmapResponse correctly, this pr fix this problem
pick pr #43358
Co-authored-by: huanghaibin <huanghaibin@selectdb.com>
BiteTheDDDDt pushed a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Feb 7, 2025
@hust-hhb@gavinchou
[fix](cloud-mow) Fix clear GetDeleteBitmapResponse problem when getin…
9f17f2a
…g delete bitmap fail and retry (apache#43358)
Problem Summary:
pr apache#43261 doesn't clear GetDeleteBitmapResponse correctly, this pr fix
this problem
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@hust-hhb@HappenLee
[fix](cloud-mow) Fix clear GetDeleteBitmapResponse problem when getin…
b39bac5
…g delete bitmap fail and retry (apache#43358)
Problem Summary:
pr apache#43261 doesn't clear GetDeleteBitmapResponse correctly, this pr fix
this problem
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchougavinchougavinchou approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.cirdev/3.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hust-hhb@doris-robot@gavinchou@dataroaring