Skip to content

[opt](cloud) Simplify default config file of meta-service - #43381

Merged
gavinchou merged 1 commit into
apache:masterfrom
gavinchou:gavin-simplify-ms-config-file
Nov 7, 2024
Merged

[opt](cloud) Simplify default config file of meta-service#43381
gavinchou merged 1 commit into
apache:masterfrom
gavinchou:gavin-simplify-ms-config-file

Conversation

@gavinchou

@gavinchougavinchou commented Nov 6, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Remove some entries in the default doris_cloud.conf which may make users hard to understand.

Problem Summary:

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No colde files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

  • Release note

    None

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

doris-robot commented Nov 6, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions

github-actionsBot commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@gavinchou
gavinchouforce-pushed the gavin-simplify-ms-config-file branch from d35018d to f4d2522CompareNovember 6, 2024 13:29
@gavinchou

gavinchou commented Nov 6, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@gavinchougavinchou changed the title [opt](cloud) Simplify config file of meta-service[opt](cloud) Simplify default config file of meta-serviceNov 6, 2024
@github-actions

github-actionsBot commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring approved these changes Nov 6, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 6, 2024
@github-actions

github-actionsBot commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

Hastyshell
Hastyshell approved these changes Nov 7, 2024
View reviewed changes

@HastyshellHastyshell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinchou
gavinchou merged commit d42e829 into apache:masterNov 7, 2024
github-actionsBot pushed a commit that referenced this pull request Nov 7, 2024
@gavinchouYour Name
[opt](cloud) Simplify default config file of meta-service (#43381)
387c758
Remove some entries in the default doris_cloud.conf which may make users
hard to understand.
@github-actionsgithub-actionsBot mentioned this pull request Nov 7, 2024
Merged
gavinchou added a commit to gavinchou/doris that referenced this pull request Nov 8, 2024
@gavinchou
[opt](cloud) Simplify default config file of meta-service (apache#43381)
63ff483
Remove some entries in the default doris_cloud.conf which may make users
hard to understand.
gavinchou added a commit that referenced this pull request Nov 10, 2024
@gavinchou
[opt](cloud) Simplify default config file of meta-service (#43381) (#…
1f4072a
…43522)
Remove some entries in the default doris_cloud.conf which may make users
hard to understand.
@gavinchougavinchou mentioned this pull request Nov 10, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 10, 2024
@github-actions@gavinchou
branch-3.0: [opt](cloud) Simplify default config file of meta-service (…
4df1499
…#43434)
Cherry-picked from #43381
Co-authored-by: Gavin Chou <gavineaglechou@gmail.com>
@gavinchougavinchou mentioned this pull request Nov 26, 2024
Closed
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@gavinchou@HappenLee
[opt](cloud) Simplify default config file of meta-service (apache#43381)
632f6dd
Remove some entries in the default doris_cloud.conf which may make users
hard to understand.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaringdataroaringdataroaring approved these changes
+1 more reviewer
@HastyshellHastyshellHastyshell approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gavinchou@doris-robot@Hastyshell@dataroaring