Skip to content

[fix](segcompaction) fix coredump for inverted index file writer close in segment compaction - #43477

Merged
airborne12 merged 3 commits into
apache:masterfrom
airborne12:fix-segcompaction
Nov 11, 2024
Merged

[fix](segcompaction) fix coredump for inverted index file writer close in segment compaction#43477
airborne12 merged 3 commits into
apache:masterfrom
airborne12:fix-segcompaction

Conversation

@airborne12

@airborne12airborne12 commented Nov 8, 2024•
edited
Loading

Copy link
Copy Markdown
Member

What problem does this PR solve?

Related PR: #41625

Problem Summary:
Fix coredump when doing segcompaction after refactor of inverted index file writer.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

doris-robot commented Nov 8, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@airborne12

airborne12 commented Nov 8, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

github-actionsBot commented Nov 8, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Nov 8, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.90% (9864/26026)
Line Coverage: 29.07% (82064/282338)
Region Coverage: 28.28% (42264/149427)
Branch Coverage: 24.85% (21434/86244)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a497292dae4581f8a9cd59c2241613f40c3c77c5_a497292dae4581f8a9cd59c2241613f40c3c77c5/report/index.html

@airborne12

airborne12 commented Nov 10, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

github-actionsBot commented Nov 10, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

csun5285
csun5285 approved these changes Nov 10, 2024
View reviewed changes

@csun5285csun5285 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Nov 10, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@airborne12

airborne12 commented Nov 11, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

github-actionsBot commented Nov 11, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Nov 11, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.94% (9875/26029)
Line Coverage: 29.11% (82331/282790)
Region Coverage: 28.26% (42378/149942)
Branch Coverage: 24.81% (21462/86496)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ff1a9ff5dfe3a0f9959b1732e992089c9f036877_ff1a9ff5dfe3a0f9959b1732e992089c9f036877/report/index.html

qidaye
qidaye approved these changes Nov 11, 2024
View reviewed changes

@qidayeqidaye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 11, 2024
@github-actions

github-actionsBot commented Nov 11, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@airborne12
airborne12 merged commit 14084ee into apache:masterNov 11, 2024
@airborne12
airborne12 deleted the fix-segcompaction branch November 11, 2024 06:37
github-actionsBot pushed a commit that referenced this pull request Nov 11, 2024
@airborne12Your Name
[fix](segcompaction) fix coredump for inverted index file writer clos…
abf1235
…e in segment compaction (#43477)
Related PR: #41625
Problem Summary:
Fix coredump when doing segcompaction after refactor of inverted index
file writer.
Co-authored-by: airborne12 <jiangkai@selectdb.com>
@github-actionsgithub-actionsBot mentioned this pull request Nov 11, 2024
Closed
@airborne12airborne12 mentioned this pull request Nov 11, 2024
Merged
airborne12 added a commit to airborne12/apache-doris that referenced this pull request Nov 11, 2024
@airborne12
[fix](segcompaction) fix coredump for inverted index file writer clos…
7662bbd
…e in segment compaction (apache#43477)
Related PR: apache#41625
Problem Summary:
Fix coredump when doing segcompaction after refactor of inverted index
file writer.
Co-authored-by: airborne12 <jiangkai@selectdb.com>
airborne12 added a commit that referenced this pull request Nov 11, 2024
@airborne12
[fix](segcompaction) fix coredump for inverted index file writer clos…
014b709
…e in segment compaction #43477 (#43587)
cherry pick from #43477
Co-authored-by: airborne12 <jiangkai@selectdb.com>
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@airborne12@HappenLee
[fix](segcompaction) fix coredump for inverted index file writer clos…
2d94712
…e in segment compaction (apache#43477)
Related PR: apache#41625
Problem Summary:
Fix coredump when doing segcompaction after refactor of inverted index
file writer.
Co-authored-by: airborne12 <jiangkai@selectdb.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qidayeqidayeqidaye approved these changes
@csun5285csun5285csun5285 approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.3-mergedp0_creviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@airborne12@doris-robot@qidaye@csun5285@shuke987