Skip to content

[Bug]Fix bug that BE crash when load ORC file - #4350

Merged
morningman merged 4 commits into
apache:masterfrom
WingsGo:fix_orc_crash
Aug 17, 2020
Merged

[Bug]Fix bug that BE crash when load ORC file#4350
morningman merged 4 commits into
apache:masterfrom
WingsGo:fix_orc_crash

Conversation

@WingsGo

@WingsGoWingsGo commented Aug 14, 2020

Copy link
Copy Markdown
Contributor

@WingsGo

WingsGo commented Aug 14, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

For reviewers, I found that ORC include file didn't expose orc::TimezoneError, which is writer in Timezone.hh, I don't know why, maybe it is a wrong design, I will submit a issue to ORC project, currently solution is declare orc::TimezoneError by handle or just catch std::runtime_error exception, I choosen the first solution because I think it is less error-prone and more reasonable.

morningman
morningman previously approved these changes Aug 15, 2020
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman

morningman commented Aug 15, 2020

Copy link
Copy Markdown
Contributor

Maybe you need to rebase to upstream master to make UT happy

@morningmanmorningman self-assigned this Aug 15, 2020
@morningmanmorningman added the kind/fix Categorizes issue or PR as related to a bug. label Aug 15, 2020
@WingsGo

WingsGo commented Aug 15, 2020

Copy link
Copy Markdown
ContributorAuthor

Maybe you need to rebase to upstream master to make UT happy

@morningman OK, done~~

morningman
morningman approved these changes Aug 16, 2020
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added approved Indicates a PR has been approved by one committer. branch-0.13 PR which need to merge to branch 0.13 labels Aug 16, 2020
@morningman
morningman merged commit 391d534 into apache:masterAug 17, 2020
acelyc111 pushed a commit to acelyc111/incubator-doris that referenced this pull request Aug 21, 2020
@WingsGo@acelyc111
[Bug]Fix bug that BE crash when load ORC file (apache#4350)
df94c61
@yangzhgyangzhg mentioned this pull request Feb 9, 2021
Closed
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Nov 4, 2025
@luwei16
reslove merge conflict (apache#4350)
01b8a34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes

Assignees

@morningmanmorningman

Labels

approvedIndicates a PR has been approved by one committer.branch-0.13PR which need to merge to branch 0.13kind/fixCategorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]Using Broker load with ORC file may cause BE crash

2 participants

@WingsGo@morningman