Skip to content

[opt](remote scan) Fix remote scan parallelism - #43532

Merged
yiguolei merged 3 commits into
apache:masterfrom
RoanHeNaN:fix-remote-scan
Nov 11, 2024
Merged

[opt](remote scan) Fix remote scan parallelism#43532
yiguolei merged 3 commits into
apache:masterfrom
RoanHeNaN:fix-remote-scan

Conversation

@RoanHeNaN

@RoanHeNaNRoanHeNaN commented Nov 8, 2024

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Do same thing with #42633 on master

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

doris-robot commented Nov 8, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@RoanHeNaN

RoanHeNaN commented Nov 8, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Nov 8, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Nov 8, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.91% (9866/26027)
Line Coverage: 29.09% (82268/282775)
Region Coverage: 28.24% (42342/149933)
Branch Coverage: 24.79% (21441/86492)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b363cb9050c45008dd2d5a32be147d34464c6d09_b363cb9050c45008dd2d5a32be147d34464c6d09/report/index.html

@RoanHeNaN
RoanHeNaN marked this pull request as ready for review November 11, 2024 02:34
@RoanHeNaN

RoanHeNaN commented Nov 11, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@RoanHeNaN

RoanHeNaN commented Nov 11, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Nov 11, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions

github-actionsBot commented Nov 11, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Nov 11, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.91% (9867/26027)
Line Coverage: 29.09% (82251/282775)
Region Coverage: 28.24% (42340/149933)
Branch Coverage: 24.79% (21438/86492)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2f5d51f5ff7485f08d08814ed37e6b8cee8f9bd8_2f5d51f5ff7485f08d08814ed37e6b8cee8f9bd8/report/index.html

@github-actions

github-actionsBot commented Nov 11, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 11, 2024
@github-actions

github-actionsBot commented Nov 11, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei
yiguolei merged commit fc0c022 into apache:masterNov 11, 2024
github-actionsBot pushed a commit that referenced this pull request Nov 11, 2024
@RoanHeNaNzhiqiang-hhhhYour Name
[opt](remote scan) Fix remote scan parallelism (#43532)
e14645e
Co-authored-by: zhiqiang-hhhh <hezhiqiang@flywheels.com>
@github-actionsgithub-actionsBot mentioned this pull request Nov 11, 2024
Merged
@RoanHeNaN
RoanHeNaN deleted the fix-remote-scan branch November 11, 2024 13:21
dataroaring pushed a commit that referenced this pull request Nov 11, 2024
@github-actions@RoanHeNaNzhiqiang-hhhh
branch-3.0: [opt](remote scan) Fix remote scan parallelism (#43625)
cd2d79c
Cherry-picked from #43532
Co-authored-by: zhiqiang <seuhezhiqiang@163.com>
Co-authored-by: zhiqiang-hhhh <hezhiqiang@flywheels.com>
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@RoanHeNaNzhiqiang-hhhh@HappenLee
[opt](remote scan) Fix remote scan parallelism (apache#43532)
4765d16
Co-authored-by: zhiqiang-hhhh <hezhiqiang@flywheels.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes
@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.7-mergeddev/3.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RoanHeNaN@doris-robot@morningman@yiguolei@dataroaring