Skip to content

[MySQL Compatibility 2/4][Bug] Fix bug and improve compatibility with mysql protocol - #4362

Merged
morningman merged 3 commits into
apache:masterfrom
morningman:schema_reture
Aug 26, 2020
Merged

[MySQL Compatibility 2/4][Bug] Fix bug and improve compatibility with mysql protocol#4362
morningman merged 3 commits into
apache:masterfrom
morningman:schema_reture

Conversation

@morningman

@morningmanmorningman commented Aug 16, 2020

Copy link
Copy Markdown
Contributor

Proposed changes

  1. select database() will only return database name, without cluster name. [Bug][MySQL compatibility] Query to info schema table does not return correct results. #4361

  2. select user() will return the IP which user connected in. [Bug] select user() stmt does return the IP which user connected in #4360

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

@morningmanmorningman added kind/fix Categorizes issue or PR as related to a bug. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API area/mysql-compatibility Issues or PRs related to the mysql compatibility labels Aug 16, 2020
@morningmanmorningman self-assigned this Aug 16, 2020
@morningmanmorningman changed the title [Bug] Fix bug and improve compatibility with mysql protocol[MySQL Compatibility 2/4][Bug] Fix bug and improve compatibility with mysql protocolAug 16, 2020
yangzhg
yangzhg reviewed Aug 20, 2020
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/analysis/InformationFunction.java Outdated
}
}


@yangzhgyangzhgAug 20, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two empty lines？

morningman
morningman commented Aug 20, 2020
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/analysis/InformationFunction.java Outdated
kangkaisen
kangkaisen previously approved these changes Aug 25, 2020
View reviewed changes

@kangkaisenkangkaisen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

morningman-cmyand others added 3 commits August 26, 2020 10:30
@morningman-cmy@morningman
[Bug] Fix bug and improve compatibility with mysql protocol
d7a7a40
1. select database() will only return database name, without cluster name.
2. select user() will return the IP which user connected in.
@morningman-cmy@morningman
add ut
de97d8d
@morningman
Update fe/fe-core/src/main/java/org/apache/doris/analysis/Information…
b04d5d6
…Function.java
EmmyMiao87
EmmyMiao87 approved these changes Aug 26, 2020
View reviewed changes

@EmmyMiao87EmmyMiao87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmmyMiao87EmmyMiao87 added the approved Indicates a PR has been approved by one committer. label Aug 26, 2020
@morningman
morningman merged commit 763a42c into apache:masterAug 26, 2020
@yangzhgyangzhg mentioned this pull request Feb 9, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yangzhgyangzhgyangzhg left review comments
@EmmyMiao87EmmyMiao87EmmyMiao87 approved these changes
@kangkaisenkangkaisenkangkaisen left review comments

Assignees

@morningmanmorningman

Labels

approvedIndicates a PR has been approved by one committer.area/mysql-compatibilityIssues or PRs related to the mysql compatibilitykind/api-changeCategorizes issue or PR as related to adding, removing, or otherwise changing an APIkind/fixCategorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug][MySQL compatibility] Query to info schema table does not return correct results.

5 participants

@morningman@yangzhg@kangkaisen@EmmyMiao87@morningman-cmy