[fix](group commit) fix NPE in group commit select backend by mymeiyi · Pull Request #43629 · apache/doris

mymeiyi · 2024-11-11T10:47:55Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

2024-11-11 12:00:12,200 WARN (mysql-nio-pool-24123|259) execute Exception. stmt[15559118, 7d88d2401de44f4b-8325fbee3de50791]
java.lang.NullPointerException: Cannot invoke "org.apache.doris.system.Backend.isActive()" because "backend" is null
at org.apache.doris.load.GroupCommitManager.getCachedBackend(GroupCommitManager.java:305) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.load.GroupCommitManager.selectBackendForCloudGroupCommitInternal(GroupCommitManager.java:251) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.load.GroupCommitManager.selectBackendForGroupCommitInternal(GroupCommitManager.java:239) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.load.GroupCommitManager.selectBackendForGroupCommit(GroupCommitManager.java:203) ~[doris-fe.jar:1.2-SNAPSHOT]
at org.apache.doris.cloud.planner.CloudGroupCommitPlanner.selectBackends(CloudGroupCommitPlanner.java:49) ~[doris-fe.jar:1.2-SNAPSHOT]

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason : drop backend is not supported in regression and it's a simple fix
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

doris-robot · 2024-11-11T10:48:01Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

mymeiyi · 2024-11-11T10:52:09Z

run buildall

github-actions · 2024-11-11T10:53:07Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-11-11T10:53:09Z

PR approved by anyone and no changes requested.

dataroaring

LGTM

Problem Summary: ``` 2024-11-11 12:00:12,200 WARN (mysql-nio-pool-24123|259) execute Exception. stmt[15559118, 7d88d2401de44f4b-8325fbee3de50791] java.lang.NullPointerException: Cannot invoke "org.apache.doris.system.Backend.isActive()" because "backend" is null at org.apache.doris.load.GroupCommitManager.getCachedBackend(GroupCommitManager.java:305) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.GroupCommitManager.selectBackendForCloudGroupCommitInternal(GroupCommitManager.java:251) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.GroupCommitManager.selectBackendForGroupCommitInternal(GroupCommitManager.java:239) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.GroupCommitManager.selectBackendForGroupCommit(GroupCommitManager.java:203) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.cloud.planner.CloudGroupCommitPlanner.selectBackends(CloudGroupCommitPlanner.java:49) ~[doris-fe.jar:1.2-SNAPSHOT] ``` Co-authored-by: meiyi <meiyi@selectdb.com>

)

#43635) Cherry-picked from #43629 Co-authored-by: meiyi <myimeiyi@gmail.com>

…43651) pick #43629 Co-authored-by: meiyi <meiyi@selectdb.com>

) Problem Summary: ``` 2024-11-11 12:00:12,200 WARN (mysql-nio-pool-24123|259) execute Exception. stmt[15559118, 7d88d2401de44f4b-8325fbee3de50791] java.lang.NullPointerException: Cannot invoke "org.apache.doris.system.Backend.isActive()" because "backend" is null at org.apache.doris.load.GroupCommitManager.getCachedBackend(GroupCommitManager.java:305) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.GroupCommitManager.selectBackendForCloudGroupCommitInternal(GroupCommitManager.java:251) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.GroupCommitManager.selectBackendForGroupCommitInternal(GroupCommitManager.java:239) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.GroupCommitManager.selectBackendForGroupCommit(GroupCommitManager.java:203) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.cloud.planner.CloudGroupCommitPlanner.selectBackends(CloudGroupCommitPlanner.java:49) ~[doris-fe.jar:1.2-SNAPSHOT] ``` Co-authored-by: meiyi <meiyi@selectdb.com>

[fix](group commit) fix NPE in group commit select backend
34a2c1b

gavinchou approved these changes Nov 11, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 11, 2024

github-actionsBot added the reviewed label Nov 11, 2024

dataroaring approved these changes Nov 11, 2024
View reviewed changes

dataroaring added dev/3.0.x dev/2.1.x labels Nov 11, 2024

dataroaring merged commit 446514e into apache:masterNov 11, 2024

github-actionsBot mentioned this pull request Nov 11, 2024
branch-3.0: [fix](group commit) fix NPE in group commit select backend #43635
Merged

github-actionsBot added the cherry-pick-conflict-in-2.1.x label Nov 11, 2024

gavinchou added the cir label Nov 11, 2024

mymeiyi added a commit to mymeiyi/doris that referenced this pull request Nov 12, 2024
[fix](group commit) fix NPE in group commit select backend (apache#43629
6f1cdb1
)

mymeiyi mentioned this pull request Nov 12, 2024
[fix](group commit) fix NPE in group commit select backend (#43629) #43651
Merged

mymeiyi added a commit to mymeiyi/doris that referenced this pull request Nov 12, 2024
[fix](group commit) fix NPE in group commit select backend (apache#43629
1495381
)

dataroaring pushed a commit that referenced this pull request Nov 12, 2024
branch-3.0: [fix](group commit) fix NPE in group commit select backend (
93281e2
#43635) Cherry-picked from #43629 Co-authored-by: meiyi <myimeiyi@gmail.com>

dataroaring added dev/3.0.3-merged and removed dev/3.0.x cir labels Nov 12, 2024

dataroaring pushed a commit that referenced this pull request Nov 12, 2024
[fix](group commit) fix NPE in group commit select backend (#43629) (#…
f1a8ac7
…43651) pick #43629 Co-authored-by: meiyi <meiyi@selectdb.com>

dataroaring added dev/2.1.8-merged and removed dev/2.1.x cherry-pick-conflict-in-2.1.x labels Nov 12, 2024

Navigation Menu

Uh oh!

[fix](group commit) fix NPE in group commit select backend - #43629

[fix](group commit) fix NPE in group commit select backend#43629
dataroaring merged 1 commit into
apache:masterfrom
mymeiyi:fix-gc

mymeiyi commented Nov 11, 2024•
edited
Loading

Uh oh!

doris-robot commented Nov 11, 2024

Uh oh!

mymeiyi commented Nov 11, 2024

Uh oh!

github-actionsBot commented Nov 11, 2024

Uh oh!

github-actionsBot commented Nov 11, 2024

Uh oh!

dataroaring left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

mymeiyi commented Nov 11, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

doris-robot commented Nov 11, 2024

Uh oh!

mymeiyi commented Nov 11, 2024

Uh oh!

github-actionsBot commented Nov 11, 2024

Uh oh!

github-actionsBot commented Nov 11, 2024

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mymeiyi commented Nov 11, 2024•
edited
Loading