Skip to content

[fix](build) Added type conversion to ensure MacOS compile - #43630

Closed
zy-kkk wants to merge 1 commit into
apache:masterfrom
zy-kkk:fix_mac_build_1111
Closed

[fix](build) Added type conversion to ensure MacOS compile#43630
zy-kkk wants to merge 1 commit into
apache:masterfrom
zy-kkk:fix_mac_build_1111

Conversation

@zy-kkk

@zy-kkkzy-kkk commented Nov 11, 2024

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #40813,#43289,#42930

Problem Summary:
Some types cannot be implicitly converted on MacOS and require explicit cast to ensure compilation

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zy-kkk

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@zy-kkk

Copy link
Copy Markdown
MemberAuthor

run buildall

@zy-kkk

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@morningman

Copy link
Copy Markdown
Contributor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zy-kkk

Copy link
Copy Markdown
MemberAuthor

run buildall

@zy-kkk

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.97% (9897/26067)
Line Coverage: 29.16% (82715/283668)
Region Coverage: 28.30% (42483/150135)
Branch Coverage: 24.88% (21547/86612)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6b165d06c4ef9c2347951ebd44f556108a85bfc2_6b165d06c4ef9c2347951ebd44f556108a85bfc2/report/index.html

@zy-kkkzy-kkk closed this Nov 18, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@zy-kkk@doris-robot@morningman@zclllyybb