Skip to content

[Fix](auto-increment) Fix duplicate auto-increment column value problem - #43774

Merged
dataroaring merged 5 commits into
apache:masterfrom
bobhan1:bh-log-auto-inc
Nov 14, 2024
Merged

[Fix](auto-increment) Fix duplicate auto-increment column value problem#43774
dataroaring merged 5 commits into
apache:masterfrom
bobhan1:bh-log-auto-inc

Conversation

@bobhan1

@bobhan1bobhan1 commented Nov 12, 2024•
edited by dataroaring
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Result<int64_t> AutoIncIDBuffer::_fetch_ids_from_fe(size_t length) {
// ...return _rpc_status;
}

should be

Result<int64_t> AutoIncIDBuffer::_fetch_ids_from_fe(size_t length) {
// ...returnResultError(_rpc_status);
}

Otherwise, the returned Result<int64_t>'s m_has_val will be true, then AutoIncIDBuffer::_launch_async_fetch_task() will wrongly add an auto-increment range [0, length) to _buffers which will cause duplicate value problem.

Release note

Fix duplicate auto-increment column value problem in some situations.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

doris-robot commented Nov 12, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1

bobhan1 commented Nov 12, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

zhannngchen
zhannngchen approved these changes Nov 12, 2024
View reviewed changes

@zhannngchenzhannngchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 12, 2024
@github-actions

github-actionsBot commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@bobhan1

bobhan1 commented Nov 12, 2024

Copy link
Copy Markdown
ContributorAuthor

run cloud_p0

dataroaring
dataroaring approved these changes Nov 12, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring

dataroaring commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

run buildall

@github-actions

github-actionsBot commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1

bobhan1 commented Nov 13, 2024

Copy link
Copy Markdown
ContributorAuthor

run beut

@bobhan1

bobhan1 commented Nov 13, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Nov 13, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1

bobhan1 commented Nov 13, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Nov 13, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1

bobhan1 commented Nov 14, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1

bobhan1 commented Nov 14, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Nov 14, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.94% (9885/26056)
Line Coverage: 29.12% (82580/283542)
Region Coverage: 28.26% (42449/150228)
Branch Coverage: 24.84% (21532/86678)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ca8de90d6f76cfa62881d94729f1eb90bf4f14d1_ca8de90d6f76cfa62881d94729f1eb90bf4f14d1/report/index.html

@bobhan1

bobhan1 commented Nov 14, 2024

Copy link
Copy Markdown
ContributorAuthor

run p0

dataroaring
dataroaring approved these changes Nov 14, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit b4a7240 into apache:masterNov 14, 2024
github-actionsBot pushed a commit that referenced this pull request Nov 14, 2024
@bobhan1Your Name
[Fix](auto-increment) Fix duplicate auto-increment column value probl…
8cbd45e
…em (#43774)
```cpp
Result<int64_t> AutoIncIDBuffer::_fetch_ids_from_fe(size_t length) {
// ...
return _rpc_status;
}
```
should be
```cpp
Result<int64_t> AutoIncIDBuffer::_fetch_ids_from_fe(size_t length) {
// ...
return ResultError(_rpc_status);
}
```
Otherwise, the returned `Result<int64_t>`'s `m_has_val` will be `true`,
then `AutoIncIDBuffer::_launch_async_fetch_task()` will wrongly add an
auto-increment range [0, length) to `_buffers` which will cause
duplicate value problem.
### Release note
Fix duplicate auto-increment column value problem in some situations.
@github-actionsgithub-actionsBot mentioned this pull request Nov 14, 2024
Merged
github-actionsBot pushed a commit that referenced this pull request Nov 14, 2024
@bobhan1Your Name
[Fix](auto-increment) Fix duplicate auto-increment column value probl…
b7bd026
…em (#43774)
```cpp
Result<int64_t> AutoIncIDBuffer::_fetch_ids_from_fe(size_t length) {
// ...
return _rpc_status;
}
```
should be
```cpp
Result<int64_t> AutoIncIDBuffer::_fetch_ids_from_fe(size_t length) {
// ...
return ResultError(_rpc_status);
}
```
Otherwise, the returned `Result<int64_t>`'s `m_has_val` will be `true`,
then `AutoIncIDBuffer::_launch_async_fetch_task()` will wrongly add an
auto-increment range [0, length) to `_buffers` which will cause
duplicate value problem.
### Release note
Fix duplicate auto-increment column value problem in some situations.
@github-actionsgithub-actionsBot mentioned this pull request Nov 14, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 15, 2024
@github-actions@bobhan1
branch-3.0: [Fix](auto-increment) Fix duplicate auto-increment column…
adfbe69
… value problem #43774 (#43983)
Cherry-picked from #43774
Co-authored-by: bobhan1 <baohan@selectdb.com>
yiguolei pushed a commit that referenced this pull request Nov 16, 2024
@github-actions@bobhan1
branch-2.1: [Fix](auto-increment) Fix duplicate auto-increment column…
d1cc68a
… value problem #43774 (#43984)
Cherry-picked from #43774
Co-authored-by: bobhan1 <baohan@selectdb.com>
@gavinchougavinchou mentioned this pull request Nov 26, 2024
Closed
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@bobhan1@HappenLee
[Fix](auto-increment) Fix duplicate auto-increment column value probl…
89645d7
…em (apache#43774)
```cpp
Result<int64_t> AutoIncIDBuffer::_fetch_ids_from_fe(size_t length) {
// ...
return _rpc_status;
}
```
should be
```cpp
Result<int64_t> AutoIncIDBuffer::_fetch_ids_from_fe(size_t length) {
// ...
return ResultError(_rpc_status);
}
```
Otherwise, the returned `Result<int64_t>`'s `m_has_val` will be `true`,
then `AutoIncIDBuffer::_launch_async_fetch_task()` will wrongly add an
auto-increment range [0, length) to `_buffers` which will cause
duplicate value problem.
### Release note
Fix duplicate auto-increment column value problem in some situations.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhannngchenzhannngchenzhannngchen approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.8-mergeddev/3.0.3-mergedp0_wreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bobhan1@doris-robot@dataroaring@zhannngchen@yiguolei