Skip to content

[Improment]Reset workload group's default value - #43942

Merged
wangbo merged 1 commit into
apache:masterfrom
wangbo:1113_wg_default_val
Nov 18, 2024
Merged

[Improment]Reset workload group's default value#43942
wangbo merged 1 commit into
apache:masterfrom
wangbo:1113_wg_default_val

Conversation

@wangbo

@wangbowangbo commented Nov 14, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

1 set cpu_share and memory_limit's default value to -1.
2 unify error message when workload group's value is invalid.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

doris-robot commented Nov 14, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions

github-actionsBot commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions

github-actionsBot commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@wangbo

wangbo commented Nov 14, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Nov 14, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.94% (9887/26063)
Line Coverage: 29.13% (82610/283609)
Region Coverage: 28.27% (42472/150261)
Branch Coverage: 24.84% (21537/86704)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8aca7c3013ffef59edec67aaac4f6557fbaa0ddc_8aca7c3013ffef59edec67aaac4f6557fbaa0ddc/report/index.html

@wangbo

wangbo commented Nov 14, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Nov 14, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.94% (9888/26060)
Line Coverage: 29.15% (82648/283567)
Region Coverage: 28.27% (42468/150240)
Branch Coverage: 24.85% (21544/86688)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bed6dd9ffab1a910c8d2f88f9f7d07675682471f_bed6dd9ffab1a910c8d2f88f9f7d07675682471f/report/index.html

@wangbo

wangbo commented Nov 15, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

yiguolei
yiguolei reviewed Nov 15, 2024
View reviewed changes
Comment threadbe/src/runtime/workload_group/workload_group.cpp
// 4 cpu_share
uint64_t cpu_share = CgroupCpuCtl::cpu_soft_limit_default_value();
if (tworkload_group_info.__isset.cpu_share) {
if (tworkload_group_info.__isset.cpu_share && tworkload_group_info.cpu_share > 0) {

@yiguoleiyiguoleiNov 15, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果我先从-1 设置为10，然后又想设置为-1 咋办？

@wangbowangboNov 15, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不影响啊，fe的-1可以随便设置。传到be的时候，如果发现是-1，就使用be的默认值(cpu_soft_limit_default_value)啊

@doris-robot

doris-robot commented Nov 15, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.98% (9895/26052)
Line Coverage: 29.18% (82715/283500)
Region Coverage: 28.30% (42475/150104)
Branch Coverage: 24.88% (21543/86598)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c9763eb2232cef38e7537a0e94ea6a0691170255_c9763eb2232cef38e7537a0e94ea6a0691170255/report/index.html

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 18, 2024
@github-actions

github-actionsBot commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

xinyiZzz
xinyiZzz approved these changes Nov 18, 2024
View reviewed changes

@xinyiZzzxinyiZzz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangbo
wangbo merged commit e4a7464 into apache:masterNov 18, 2024
wangbo pushed a commit to wangbo/incubator-doris that referenced this pull request Nov 26, 2024
wangbo
[Improment]Reset workload group's default value (apache#43942)
fb22d24
1 set cpu_share and memory_limit's default value to -1.
2 unify error message when workload group's value is invalid.
@wangbowangbo mentioned this pull request Nov 26, 2024
Merged
wangbo pushed a commit that referenced this pull request Nov 27, 2024
wangbo
[branch-2.1] pick some workload group pr (#44634)
43ebfa9
pick #42053#43942
wangbo pushed a commit to wangbo/incubator-doris that referenced this pull request Dec 13, 2024
wangbo
[Improment]Reset workload group's default value (apache#43942)
4406af2
1 set cpu_share and memory_limit's default value to -1.
2 unify error message when workload group's value is invalid.
wangbo pushed a commit to wangbo/incubator-doris that referenced this pull request Dec 13, 2024
wangbo
[Improment]Reset workload group's default value (apache#43942)
16c3442
1 set cpu_share and memory_limit's default value to -1.
2 unify error message when workload group's value is invalid.
@wangbowangbo mentioned this pull request Dec 13, 2024
Merged
wangbo pushed a commit that referenced this pull request Dec 13, 2024
wangbo
[branch-3.0]Reset workload group's default value (#43942) (#45393)
0f95d59
pick #43942
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
wangbo@HappenLee
[Improment]Reset workload group's default value (apache#43942)
53be106
1 set cpu_share and memory_limit's default value to -1.
2 unify error message when workload group's value is invalid.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes
@xinyiZzzxinyiZzzxinyiZzz approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.8-mergedreviewedworkload-group

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wangbo@doris-robot@yiguolei@xinyiZzz