Skip to content

[optimization](agg) add float/double type in agg percentile_array - #43953

Merged
zhangstar333 merged 1 commit into
apache:masterfrom
zhangstar333:percentile-array-type
Nov 18, 2024
Merged

[optimization](agg) add float/double type in agg percentile_array#43953
zhangstar333 merged 1 commit into
apache:masterfrom
zhangstar333:percentile-array-type

Conversation

@zhangstar333

@zhangstar333zhangstar333 commented Nov 14, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Related PR: #41206
Problem Summary:
before in pr #41206 have support float/double in percentile function,
and percentile_array is the same logical, so it's could support float/double also.

doc: apache/doris-website#1350

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes. after support float/double, it's no need to cast others integer type

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

doris-robot commented Nov 14, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333

zhangstar333 commented Nov 14, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Nov 14, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.94% (9887/26060)
Line Coverage: 29.14% (82624/283565)
Region Coverage: 28.27% (42471/150230)
Branch Coverage: 24.85% (21541/86678)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f909f82ccd82c1b69d81d57f565ff9839a874ddf_f909f82ccd82c1b69d81d57f565ff9839a874ddf/report/index.html

HappenLee
HappenLee approved these changes Nov 15, 2024
View reviewed changes

@HappenLeeHappenLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 15, 2024
@github-actions

github-actionsBot commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

zclllyybb
zclllyybb approved these changes Nov 17, 2024
View reviewed changes

@zclllyybbzclllyybb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangstar333
zhangstar333 merged commit d22b5b8 into apache:masterNov 18, 2024
@yiguoleiyiguolei added usercase Important user case type label dev/3.0.x labels Feb 17, 2025
@yiguoleiyiguolei mentioned this pull request Feb 17, 2025
Closed
3 tasks
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Feb 19, 2025
@zhangstar333
[optimization](agg) add float/double type in agg percentile_array (ap…
5c21935
…ache#43953)
Related PR: apache#41206
Problem Summary:
before in pr apache#41206 have support float/double in percentile function,
and percentile_array is the same logical, so it's could support
float/double also.
doc: apache/doris-website#1350
@zhangstar333zhangstar333 mentioned this pull request Feb 19, 2025
Merged
16 tasks
dataroaring pushed a commit that referenced this pull request Feb 22, 2025
@zhangstar333
[cherry-pick](branch-30) add float/double type in agg percentile_array (
d2464dd
#43953) (#48094)
cherry-pick from master #43953
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@zhangstar333@HappenLee
[optimization](agg) add float/double type in agg percentile_array (ap…
d3cd0d9
…ache#43953)
### What problem does this PR solve?
Related PR: apache#41206
Problem Summary:
before in pr apache#41206 have support float/double in percentile function, and percentile_array is the same logical, so it's could support
float/double also.
doc: apache/doris-website#1350
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLeeHappenLeeHappenLee approved these changes
@zclllyybbzclllyybbzclllyybb approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.5-mergedreviewedusercaseImportant user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zhangstar333@doris-robot@HappenLee@zclllyybb@yiguolei@dataroaring