Skip to content

[Bug-Fix] Some deleted tablets are not recycled on BE - #4401

Merged
morningman merged 3 commits into
apache:masterfrom
yiguolei:master
Aug 27, 2020
Merged

[Bug-Fix] Some deleted tablets are not recycled on BE#4401
morningman merged 3 commits into
apache:masterfrom
yiguolei:master

Conversation

@yiguolei

Copy link
Copy Markdown
Contributor

@wuyunfengwuyunfeng changed the title [bugfix] Some deleted tablets are not recycled on BE and occupy too m…[Bug-Fix] Some deleted tablets are not recycled on BE and occupy too m…Aug 20, 2020
@wuyunfengwuyunfeng added area/storage Issues or PRs related to storage engine kind/fix Categorizes issue or PR as related to a bug. labels Aug 20, 2020
@wuyunfengwuyunfeng changed the title [Bug-Fix] Some deleted tablets are not recycled on BE and occupy too m…[Bug-Fix] Some deleted tablets are not recycled on BEAug 20, 2020

@yangzhgyangzhg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yangzhg
yangzhg previously approved these changes Aug 20, 2020
Comment threadbe/src/olap/tablet_manager.cpp Outdated

void TabletManager::unregister_clone_tablet(int64_t tablet_id) {
RWMutex& tablet_map_lock = _get_tablet_map_lock(tablet_id);
ReadLock rlock(&tablet_map_lock);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be WriteLock?

morningman
morningman previously approved these changes Aug 25, 2020

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman

Copy link
Copy Markdown
Contributor

UT compile failed

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added the approved Indicates a PR has been approved by one committer. label Aug 26, 2020
@morningman
morningman merged commit b85bb0e into apache:masterAug 27, 2020
@yangzhgyangzhg mentioned this pull request Feb 9, 2021
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Sep 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.area/storageIssues or PRs related to storage enginekind/fixCategorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@yiguolei@morningman@yangzhg@wuyunfeng