Skip to content

[fix](Export) fix a memory leak in the FE because of the ExportJob - #44019

Merged
morningman merged 1 commit into
apache:masterfrom
BePPPower:clearObjectsOfExportJob
Nov 17, 2024
Merged

[fix](Export) fix a memory leak in the FE because of the ExportJob#44019
morningman merged 1 commit into
apache:masterfrom
BePPPower:clearObjectsOfExportJob

Conversation

@BePPPower

@BePPPowerBePPPower commented Nov 15, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
When an Export job has finished or been cancelled, ExportMgr will maintain a reference of the ExportJob object. Therefore, we need to clear these no longer used objects; otherwise it will cause a memory leak in the FE.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason: It can not be figured out in neither Unit Test nor Regression test.

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

doris-robot commented Nov 15, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BePPPower

BePPPower commented Nov 15, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@BePPPowerBePPPower changed the title [fix](Export) fix memory leak of FE because of the ExportJob[fix](Export) fix memory leak in the FE because of the ExportJobNov 15, 2024
@BePPPowerBePPPower changed the title [fix](Export) fix memory leak in the FE because of the ExportJob[fix](Export) fix a memory leak in the FE because of the ExportJobNov 15, 2024
morningman
morningman approved these changes Nov 16, 2024
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 16, 2024
@github-actions

github-actionsBot commented Nov 16, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Nov 16, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

kaka11chen
kaka11chen approved these changes Nov 16, 2024
View reviewed changes

@kaka11chenkaka11chen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
morningman merged commit 27132c8 into apache:masterNov 17, 2024
github-actionsBot pushed a commit that referenced this pull request Nov 17, 2024
@BePPPowerYour Name
[fix](Export) fix a memory leak in the FE because of the ExportJob (#…
caf2482
…44019)
### What problem does this PR solve?
Problem Summary:
When an `Export` job has finished or been cancelled, `ExportMgr` will
maintain a reference of the `ExportJob` object. Therefore, we need to
clear these no longer used objects; otherwise it will cause a memory
leak in the FE.
@github-actionsgithub-actionsBot mentioned this pull request Nov 17, 2024
Merged
github-actionsBot pushed a commit that referenced this pull request Nov 17, 2024
@BePPPowerYour Name
[fix](Export) fix a memory leak in the FE because of the ExportJob (#…
6f64150
…44019)
### What problem does this PR solve?
Problem Summary:
When an `Export` job has finished or been cancelled, `ExportMgr` will
maintain a reference of the `ExportJob` object. Therefore, we need to
clear these no longer used objects; otherwise it will cause a memory
leak in the FE.
@github-actionsgithub-actionsBot mentioned this pull request Nov 17, 2024
Merged
morningman pushed a commit that referenced this pull request Nov 17, 2024
@github-actions@BePPPower
branch-3.0: [fix](Export) fix a memory leak in the FE because of the …
028a450
…ExportJob #44019 (#44088)
Cherry-picked from #44019
Co-authored-by: Tiewei Fang <ftw2139@163.com>
yiguolei pushed a commit that referenced this pull request Nov 18, 2024
@github-actions@BePPPower
branch-2.1: [fix](Export) fix a memory leak in the FE because of the …
05e1620
…ExportJob #44019 (#44089)
Cherry-picked from #44019
Co-authored-by: Tiewei Fang <ftw2139@163.com>
@yiguoleiyiguolei mentioned this pull request Jan 19, 2025
Closed
@gavinchougavinchou mentioned this pull request Feb 18, 2025
Closed
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@BePPPower@HappenLee
[fix](Export) fix a memory leak in the FE because of the ExportJob (a…
892225e
…pache#44019)
### What problem does this PR solve?
Problem Summary:
When an `Export` job has finished or been cancelled, `ExportMgr` will
maintain a reference of the `ExportJob` object. Therefore, we need to
clear these no longer used objects; otherwise it will cause a memory
leak in the FE.
@horus-leonardohorus-leonardo mentioned this pull request Apr 27, 2026
Open
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaka11chenkaka11chenkaka11chen approved these changes
@morningmanmorningmanmorningman approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.8-mergeddev/3.0.3-mergedp0_breviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BePPPower@doris-robot@kaka11chen@morningman@yiguolei@wm1581066