Skip to content

[pick](branch-2.1) pick #43281 - #44020

Merged
yiguolei merged 2 commits into
apache:branch-2.1from
xinyiZzz:branch-2.1_20241114_pick_arrow_vip
Nov 16, 2024
Merged

[pick](branch-2.1) pick #43281 #44020
yiguolei merged 2 commits into
apache:branch-2.1from
xinyiZzz:branch-2.1_20241114_pick_arrow_vip

Conversation

@xinyiZzz

Copy link
Copy Markdown
Contributor

pick #43281

@doris-robot

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@xinyiZzz

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/runtime/buffer_control_block.h
Comment threadbe/src/runtime/result_buffer_mgr.h
Comment threadbe/src/service/arrow_flight/arrow_flight_batch_reader.cpp
Comment threadbe/src/service/arrow_flight/arrow_flight_batch_reader.h
@xinyiZzz
xinyiZzzforce-pushed the branch-2.1_20241114_pick_arrow_vip branch from 6704bf1 to 85395f6CompareNovember 15, 2024 07:20
@xinyiZzz
xinyiZzzforce-pushed the branch-2.1_20241114_pick_arrow_vip branch from 85395f6 to bfa3b55CompareNovember 15, 2024 08:42
@xinyiZzz

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.34% (9486/26101)
Line Coverage: 27.88% (78148/280260)
Region Coverage: 26.54% (40082/151021)
Branch Coverage: 23.33% (20354/87246)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bfa3b55217310d1bb4f1c56d40d1a635bf5cf127_bfa3b55217310d1bb4f1c56d40d1a635bf5cf127/report/index.html

@xinyiZzz

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.34% (9486/26102)
Line Coverage: 27.88% (78136/280277)
Region Coverage: 26.53% (40073/151027)
Branch Coverage: 23.32% (20346/87250)
Coverage Report: http://coverage.selectdb-in.cc/coverage/92f251a0688c0771c6e5b9801bf6b575f7ff7a2b_92f251a0688c0771c6e5b9801bf6b575f7ff7a2b/report/index.html

@yiguolei
yiguolei merged commit ea61206 into apache:branch-2.1Nov 16, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@xinyiZzz@doris-robot@yiguolei