Skip to content

[improve][ms] Bvars add the FDB get_count_normalized indicator - #44036

Merged
dataroaring merged 2 commits into
apache:masterfrom
Sjwhello:add_indicator
Nov 20, 2024
Merged

[improve][ms] Bvars add the FDB get_count_normalized indicator#44036
dataroaring merged 2 commits into
apache:masterfrom
Sjwhello:add_indicator

Conversation

@Sjwhello

@SjwhelloSjwhello commented Nov 15, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Bvars add the FDB get_count_normalized indicator

  • g_bvar_txn_kv_ get_count_normalized

@doris-robot

doris-robot commented Nov 15, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions

github-actionsBot commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Sjwhello

Sjwhello commented Nov 15, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

gavinchou
gavinchou reviewed Nov 15, 2024
View reviewed changes
Comment threadcloud/src/common/bvars.cpp Outdated
@github-actions

github-actionsBot commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@SjwhelloSjwhello changed the title [improve][ms] Bvars add the FDB get count total indicator[improve][ms] Bvars add the FDB get_count_normalized indicatorNov 18, 2024
@Sjwhello

Sjwhello commented Nov 18, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actions

github-actionsBot commented Nov 18, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Sjwhello

Sjwhello commented Nov 18, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@Sjwhello

Sjwhello commented Nov 19, 2024

Copy link
Copy Markdown
ContributorAuthor

run cloud_p0

@github-actions

github-actionsBot commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 20, 2024
@github-actions

github-actionsBot commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Nov 20, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 6898b77 into apache:masterNov 20, 2024
github-actionsBot pushed a commit that referenced this pull request Nov 20, 2024
@SjwhellosunjiangweiYour Name
[improve][ms] Bvars add the FDB get_count_normalized indicator (#44036)
9b71e32
### What problem does this PR solve?
Bvars add the FDB get_count_normalized indicator
- g_bvar_txn_kv_ get_count_normalized
Co-authored-by: sunjiangwei <sunjiangwei@meituan.com>
@github-actionsgithub-actionsBot mentioned this pull request Nov 20, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 26, 2024
@github-actions@Sjwhellosunjiangwei
branch-3.0: [improve][ms] Bvars add the FDB get_count_normalized indi…
1b34ae3
…cator #44036 (#44350)
Cherry-picked from #44036
Co-authored-by: jw-sun <55874234+Sjwhello@users.noreply.github.com>
Co-authored-by: sunjiangwei <sunjiangwei@meituan.com>
@Sjwhello
Sjwhello deleted the add_indicator branch January 15, 2025 08:36
@gavinchougavinchou mentioned this pull request Feb 18, 2025
Closed
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@Sjwhellosunjiangwei@HappenLee
[improve][ms] Bvars add the FDB get_count_normalized indicator (apach…
244003e
…e#44036)
### What problem does this PR solve?
Bvars add the FDB get_count_normalized indicator
- g_bvar_txn_kv_ get_count_normalized
Co-authored-by: sunjiangwei <sunjiangwei@meituan.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchougavinchougavinchou approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.4-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Sjwhello@doris-robot@gavinchou@dataroaring