Skip to content

[fix](s3) do not replace https scheme if specified - #44242

Merged
morningman merged 1 commit into
apache:masterfrom
morningman:https_s3
Nov 19, 2024
Merged

[fix](s3) do not replace https scheme if specified#44242
morningman merged 1 commit into
apache:masterfrom
morningman:https_s3

Conversation

@morningman

@morningmanmorningman commented Nov 19, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Problem Summary:
When creating s3 resource with endpoint, if user already specify https:// schema in endpoint url,
we should not replace it with http://.

Release note

fix fix bug that s3 resource do not support https://

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

doris-robot commented Nov 19, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman

morningman commented Nov 19, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@morningman

morningman commented Nov 19, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@morningmanmorningman mentioned this pull request Nov 19, 2024
Merged
@github-actions

github-actionsBot commented Nov 19, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actions

github-actionsBot commented Nov 19, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 19, 2024
@morningman
morningman merged commit def0bc2 into apache:masterNov 19, 2024
github-actionsBot pushed a commit that referenced this pull request Nov 19, 2024
@morningmanYour Name
[fix](s3) do not replace https scheme if specified (#44242)
5b71b1d
### What problem does this PR solve?
Problem Summary:
When creating s3 resource with endpoint, it user already specify
`https://` schema in endpoint url,
we should not replace it with `http://`.
### Release note
[fix](s3) fix bug that s3 resource do not support `https://`
@github-actionsgithub-actionsBot mentioned this pull request Nov 19, 2024
Merged
github-actionsBot pushed a commit that referenced this pull request Nov 19, 2024
@morningmanYour Name
[fix](s3) do not replace https scheme if specified (#44242)
10bddd9
### What problem does this PR solve?
Problem Summary:
When creating s3 resource with endpoint, it user already specify
`https://` schema in endpoint url,
we should not replace it with `http://`.
### Release note
[fix](s3) fix bug that s3 resource do not support `https://`
@github-actionsgithub-actionsBot mentioned this pull request Nov 19, 2024
Merged
@wm1581066wm1581066 added the usercase Important user case type label label Nov 19, 2024
morningman added a commit that referenced this pull request Nov 19, 2024
@github-actions@morningman
branch-2.1: [fix](s3) do not replace https scheme if specified#44242(…
e937132
…#44250)
Cherry-picked from #44242
Co-authored-by: Mingyu Chen (Rayner) <morningman@163.com>
morningman added a commit that referenced this pull request Nov 19, 2024
@github-actions@morningman
branch-3.0: [fix](s3) do not replace https scheme if specified#44242(…
c149e83
…#44249)
Cherry-picked from #44242
Co-authored-by: Mingyu Chen (Rayner) <morningman@163.com>
morningman added a commit that referenced this pull request Nov 19, 2024
@morningman
[fix](s3) do not replace https scheme if specified#44242(#44243)
a346e77
cherry-pick #44242
@yiguoleiyiguolei mentioned this pull request Jan 19, 2025
Closed
@gavinchougavinchou mentioned this pull request Feb 18, 2025
Closed
deardeng pushed a commit to deardeng/incubator-doris that referenced this pull request Dec 19, 2025
@swjtu-zhanglei@morningman
[fix](s3) do not replace https scheme if specified (apache#44242) (ap…
3f414bb
…ache#304)
### What problem does this PR solve?
Problem Summary:
When creating s3 resource with endpoint, it user already specify
`https://` schema in endpoint url,
we should not replace it with `http://`.
### Release note
[fix](s3) fix bug that s3 resource do not support `https://`
Co-authored-by: Mingyu Chen (Rayner) <morningman@163.com>
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@morningman@HappenLee
[fix](s3) do not replace https scheme if specified (apache#44242)
800f773
### What problem does this PR solve?
Problem Summary:
When creating s3 resource with endpoint, it user already specify
`https://` schema in endpoint url,
we should not replace it with `http://`.
### Release note
[fix](s3) fix bug that s3 resource do not support `https://`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CalvinKirsCalvinKirsCalvinKirs approved these changes
@wuwenchiwuwenchiwuwenchi approved these changes
@hubgeterhubgeterhubgeter approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.8-mergeddev/3.0.3-mergedreviewedusercaseImportant user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@morningman@doris-robot@CalvinKirs@wuwenchi@hubgeter@wm1581066