Skip to content

[cleanup](load) remove bvar "g_memtable_input_block_allocated_size" - #44304

Merged
dataroaring merged 2 commits into
apache:masterfrom
kaijchen:remove-g_memtable_input_block_allocated_size
Nov 26, 2024
Merged

[cleanup](load) remove bvar "g_memtable_input_block_allocated_size"#44304
dataroaring merged 2 commits into
apache:masterfrom
kaijchen:remove-g_memtable_input_block_allocated_size

Conversation

@kaijchen

@kaijchenkaijchen commented Nov 20, 2024•
edited
Loading

Copy link
Copy Markdown
Member

What problem does this PR solve?

Bvar "g_memtable_input_block_allocated_size" is no longer needed after #40912.
Calling MutableBlock::allocated_bytes() in Memtable::insert() has some performance penalties.
So we should remove it.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

doris-robot commented Nov 20, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaijchen

kaijchen commented Nov 20, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

github-actionsBot commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Nov 20, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 38.02% (9898/26035)
Line Coverage: 29.21% (82816/283535)
Region Coverage: 28.33% (42514/150055)
Branch Coverage: 24.89% (21555/86584)
Coverage Report: http://coverage.selectdb-in.cc/coverage/61dc0f3864634f256f8f36771d021b229594f8d1_61dc0f3864634f256f8f36771d021b229594f8d1/report/index.html

dataroaring
dataroaring approved these changes Nov 21, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 21, 2024
@github-actions

github-actionsBot commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@kaijchen

kaijchen commented Nov 22, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@github-actions

github-actionsBot commented Nov 22, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

doris-robot commented Nov 22, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 38.30% (9976/26048)
Line Coverage: 29.43% (83513/283801)
Region Coverage: 28.57% (42960/150354)
Branch Coverage: 25.16% (21824/86742)
Coverage Report: http://coverage.selectdb-in.cc/coverage/fa648235f8d459bc550624f9a8224180618ce6c1_fa648235f8d459bc550624f9a8224180618ce6c1/report/index.html

@dataroaring
dataroaring merged commit 7560a78 into apache:masterNov 26, 2024
github-actionsBot pushed a commit that referenced this pull request Nov 26, 2024
@kaijchenYour Name
[cleanup](load) remove bvar "g_memtable_input_block_allocated_size" (#…
15c195f
…44304)
### What problem does this PR solve?
Bvar "g_memtable_input_block_allocated_size" is no longer needed after
#40912.
Calling `MutableBlock::allocated_bytes()` in `Memtable::insert()` has
some performance penalties.
So we should remove it.
@github-actionsgithub-actionsBot mentioned this pull request Nov 26, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 27, 2024
@github-actions@kaijchen
branch-3.0: [cleanup](load) remove bvar "g_memtable_input_block_alloc…
47c3f05
…ated_size" #44304 (#44643)
Cherry-picked from #44304
Co-authored-by: Kaijie Chen <chenkaijie@selectdb.com>
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@kaijchen@HappenLee
[cleanup](load) remove bvar "g_memtable_input_block_allocated_size" (a…
3b72a20
…pache#44304)
### What problem does this PR solve?
Bvar "g_memtable_input_block_allocated_size" is no longer needed after
apache#40912.
Calling `MutableBlock::allocated_bytes()` in `Memtable::insert()` has
some performance penalties.
So we should remove it.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yukang-LianYukang-LianYukang-Lian approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.4-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kaijchen@doris-robot@Yukang-Lian@dataroaring