Skip to content

[Fix](ms) Fix ci-uncaught ut coredump due to dynamic rate limit setting - #44362

Merged
dataroaring merged 1 commit into
apache:masterfrom
Hastyshell:fix-rate-limit
Nov 21, 2024
Merged

[Fix](ms) Fix ci-uncaught ut coredump due to dynamic rate limit setting#44362
dataroaring merged 1 commit into
apache:masterfrom
Hastyshell:fix-rate-limit

Conversation

@Hastyshell

@HastyshellHastyshell commented Nov 20, 2024

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Related PR: #42413

Problem Summary:

UT failed with coredump in PR #42413 but was not detected by CI. Fix the problem.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

doris-robot commented Nov 20, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Hastyshell

Hastyshell commented Nov 20, 2024

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

gavinchou
gavinchou previously approved these changes Nov 20, 2024
View reviewed changes
@github-actions

github-actionsBot commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 20, 2024
@github-actions

github-actionsBot commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring previously approved these changes Nov 20, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Hastyshell
Hastyshell dismissed stale reviews from dataroaring and gavinchou via 6e17d80November 20, 2024 16:28
@Hastyshell

Hastyshell commented Nov 20, 2024

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Nov 20, 2024
@github-actions

github-actionsBot commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Hastyshell

Hastyshell commented Nov 20, 2024

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@github-actions

github-actionsBot commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Hastyshell

Hastyshell commented Nov 20, 2024

Copy link
Copy Markdown
CollaboratorAuthor

run cloudut

@gavinchou

gavinchou commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

run cloud_ut

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 20, 2024
@github-actions

github-actionsBot commented Nov 20, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@gavinchou

gavinchou commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

run cloud_p0

hello-stephen
hello-stephen approved these changes Nov 21, 2024
View reviewed changes

@hello-stephenhello-stephen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
dataroaring merged commit 012620c into apache:masterNov 21, 2024
github-actionsBot pushed a commit that referenced this pull request Nov 21, 2024
@HastyshellYour Name
[Fix](ms) Fix ci-uncaught ut coredump due to dynamic rate limit setti…
63cd07d
…ng (#44362)
UT failed with coredump in PR #42413 but was not detected by CI. Fix the
problem.
@github-actionsgithub-actionsBot mentioned this pull request Nov 21, 2024
Merged
dataroaring pushed a commit that referenced this pull request Nov 21, 2024
@github-actions@Hastyshell
branch-3.0: [Fix](ms) Fix ci-uncaught ut coredump due to dynamic rate…
9cd1287
… limit setting #44362 (#44370)
Cherry-picked from #44362
Co-authored-by: Siyang Tang <tangsiyang@selectdb.com>
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@Hastyshell@HappenLee
[Fix](ms) Fix ci-uncaught ut coredump due to dynamic rate limit setti…
bf19a57
…ng (apache#44362)
UT failed with coredump in PR apache#42413 but was not detected by CI. Fix the
problem.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchougavinchougavinchou approved these changes
@hello-stephenhello-stephenhello-stephen approved these changes
@dataroaringdataroaringdataroaring left review comments

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.3-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Hastyshell@doris-robot@gavinchou@hello-stephen@dataroaring