Skip to content

[fix](arrow-flight-sql) Remove arrow_flight_sql group from regression test - #44489

Merged
xinyiZzz merged 1 commit into
apache:masterfrom
xinyiZzz:20241119_fix_arrowflight_pipeline
Nov 27, 2024
Merged

[fix](arrow-flight-sql) Remove arrow_flight_sql group from regression test#44489
xinyiZzz merged 1 commit into
apache:masterfrom
xinyiZzz:20241119_fix_arrowflight_pipeline

Conversation

@xinyiZzz

@xinyiZzzxinyiZzz commented Nov 22, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Problem Summary:

Add ./run-regression-test.sh --run ... -g arrow_flight_sql to the pipeline. then add the group arrow_flight_sql again, which is safer.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

doris-robot commented Nov 22, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@xinyiZzz

xinyiZzz commented Nov 22, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@xinyiZzzxinyiZzz changed the title [fix](arrow-flight-sql) Remove arrow_flight_sql tag from regression test[fix](arrow-flight-sql) Remove arrow_flight_sql group from regression testNov 22, 2024
@xinyiZzz
xinyiZzzforce-pushed the 20241119_fix_arrowflight_pipeline branch from 61b6afc to 4c8e411CompareNovember 25, 2024 02:46
@xinyiZzz

xinyiZzz commented Nov 25, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 26, 2024
@github-actions

github-actionsBot commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

wangbo
wangbo approved these changes Nov 27, 2024
View reviewed changes

@wangbowangbo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinyiZzz
xinyiZzz merged commit 7a6bb51 into apache:masterNov 27, 2024
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request Dec 4, 2024
@xinyiZzz
Revert "[fix](arrow-flight-sql) Remove arrow_flight_sql group from …
68904cf
…regression test (apache#44489)"
This reverts commit 7a6bb51.
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request Dec 5, 2024
@xinyiZzz
[fix](arrow-flight-sql) Remove arrow_flight_sql group from regressi…
d5d5f02
…on test (apache#44489)
Problem Summary:
Add `./run-regression-test.sh --run ... -g arrow_flight_sql` to the
pipeline. then add the group `arrow_flight_sql` again, which is safer.
@xinyiZzzxinyiZzz mentioned this pull request Dec 5, 2024
Merged
16 tasks
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request Dec 5, 2024
@xinyiZzz
[fix](arrow-flight-sql) Remove arrow_flight_sql group from regressi…
19a3178
…on test (apache#44489)
Problem Summary:
Add `./run-regression-test.sh --run ... -g arrow_flight_sql` to the
pipeline. then add the group `arrow_flight_sql` again, which is safer.
@xinyiZzzxinyiZzz mentioned this pull request Dec 5, 2024
Merged
16 tasks
xinyiZzz added a commit that referenced this pull request Dec 5, 2024
@xinyiZzz
[pick](branch-2.1) pick#44489#44894(#45024)
fa633d7
### What problem does this PR solve?
pick #44489#44894
yiguolei pushed a commit that referenced this pull request Dec 6, 2024
@xinyiZzz
[pick](branch-3.0) pick#44489#44894(#45031)
b12d0eb
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@xinyiZzz@HappenLee
[fix](arrow-flight-sql) Remove arrow_flight_sql group from regressi…
3564950
…on test (apache#44489)
### What problem does this PR solve?
Problem Summary:
Add `./run-regression-test.sh --run ... -g arrow_flight_sql` to the
pipeline. then add the group `arrow_flight_sql` again, which is safer.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes
@wangbowangbowangbo approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.8-mergeddev/3.0.4-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xinyiZzz@doris-robot@yiguolei@wangbo