Skip to content

[fix](jdbc catalog) set enable_jdbc_cast_predicate_push_down default true - #44548

Merged
morningman merged 2 commits into
apache:masterfrom
zy-kkk:fix_jdbc_cast
Nov 28, 2024
Merged

[fix](jdbc catalog) set enable_jdbc_cast_predicate_push_down default true#44548
morningman merged 2 commits into
apache:masterfrom
zy-kkk:fix_jdbc_cast

Conversation

@zy-kkk

@zy-kkkzy-kkk commented Nov 25, 2024•
edited by morningman
Loading

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #42102

Problem Summary:

We found that after disabling pushdown of predicates with implicit casts, some users experienced slower queries, so we temporarily changed this parameter back to the default behavior.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

doris-robot commented Nov 25, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zy-kkk

zy-kkk commented Nov 25, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@zy-kkk

zy-kkk commented Nov 26, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@morningmanmorningman reopened this Nov 26, 2024
@github-actions

github-actionsBot commented Nov 28, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 28, 2024
@github-actions

github-actionsBot commented Nov 28, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morningman
morningman merged commit 8492f02 into apache:masterNov 28, 2024
github-actionsBot pushed a commit that referenced this pull request Nov 28, 2024
@zy-kkkYour Name
[fix](jdbc catalog) set enable_jdbc_cast_predicate_push_down defaul…
dcae370
…t true (#44548)
### What problem does this PR solve?
Related PR: #42102
Problem Summary:
We found that after disabling pushdown of predicates with implicit
casts, some users experienced slower queries, so we temporarily changed
this parameter back to the default behavior.
@github-actionsgithub-actionsBot mentioned this pull request Nov 28, 2024
Merged
github-actionsBot pushed a commit that referenced this pull request Nov 28, 2024
@zy-kkkYour Name
[fix](jdbc catalog) set enable_jdbc_cast_predicate_push_down defaul…
b3cc0c7
…t true (#44548)
### What problem does this PR solve?
Related PR: #42102
Problem Summary:
We found that after disabling pushdown of predicates with implicit
casts, some users experienced slower queries, so we temporarily changed
this parameter back to the default behavior.
@github-actionsgithub-actionsBot mentioned this pull request Nov 28, 2024
Merged
yiguolei pushed a commit that referenced this pull request Nov 29, 2024
@zy-kkk@yiguolei
[fix](jdbc catalog) set enable_jdbc_cast_predicate_push_down defaul…
4339063
…t true (#44548)
### What problem does this PR solve?
Related PR: #42102
Problem Summary:
We found that after disabling pushdown of predicates with implicit
casts, some users experienced slower queries, so we temporarily changed
this parameter back to the default behavior.
yiguolei pushed a commit that referenced this pull request Dec 1, 2024
@zy-kkk@yiguolei
[fix](jdbc catalog) set enable_jdbc_cast_predicate_push_down defaul…
2011074
…t true (#44548)
### What problem does this PR solve?
Related PR: #42102
Problem Summary:
We found that after disabling pushdown of predicates with implicit
casts, some users experienced slower queries, so we temporarily changed
this parameter back to the default behavior.
yiguolei pushed a commit that referenced this pull request Dec 2, 2024
@github-actions@zy-kkk
branch-2.1: [fix](jdbc catalog) set `enable_jdbc_cast_predicate_push_…
e322955
…down` default true #44548 (#44760)
Cherry-picked from #44548
Co-authored-by: zy-kkk <zhongyongkang@selectdb.com>
dataroaring pushed a commit that referenced this pull request Dec 6, 2024
@github-actions@zy-kkk
branch-3.0: [fix](jdbc catalog) set `enable_jdbc_cast_predicate_push_…
acae6ad
…down` default true #44548 (#44759)
Cherry-picked from #44548
Co-authored-by: zy-kkk <zhongyongkang@selectdb.com>
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@zy-kkk@HappenLee
[fix](jdbc catalog) set enable_jdbc_cast_predicate_push_down defaul…
eee477b
…t true (apache#44548)
### What problem does this PR solve?
Related PR: apache#42102
Problem Summary:
We found that after disabling pushdown of predicates with implicit
casts, some users experienced slower queries, so we temporarily changed
this parameter back to the default behavior.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes
@CalvinKirsCalvinKirsCalvinKirs approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.8-mergeddev/3.0.4-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zy-kkk@doris-robot@morningman@CalvinKirs@yiguolei@dataroaring