Skip to content

branch-2.1: [fix](hyperscan) Fix hyper scan fall back to re2 #44547 - #44653

Merged
yiguolei merged 1 commit into
branch-2.1from
auto-pick-44547-branch-2.1
Nov 28, 2024
Merged

branch-2.1: [fix](hyperscan) Fix hyper scan fall back to re2 #44547#44653
yiguolei merged 1 commit into
branch-2.1from
auto-pick-44547-branch-2.1

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Nov 27, 2024

Copy link
Copy Markdown
Contributor

Cherry-picked from #44547

@doris-robot

doris-robot commented Nov 27, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot

doris-robot commented Nov 27, 2024

Copy link
Copy Markdown

run buildall

@doris-robot

doris-robot commented Nov 27, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.74% (9608/26154)
Line Coverage: 28.13% (79033/280919)
Region Coverage: 26.83% (40637/151471)
Branch Coverage: 23.64% (20671/87440)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c9d8d521fa8790fbe423487547d73ca6ddd09845_c9d8d521fa8790fbe423487547d73ca6ddd09845/report/index.html

@RoanHeNaN

RoanHeNaN commented Nov 27, 2024

Copy link
Copy Markdown
Contributor

run p0

@RoanHeNaN@yiguolei
[fix](hyperscan) Fix hyper scan fall back to re2 (#44547)
28109d0
* Core modification
When hyper scan failed, we should not set_error in FunctionContext.
Since set_error will try cancel query, but actually we want to fall back
to re2 in this case.
* Some refactor
Rename FunctionRegexp so that we can distinguish regexp match with
regexp_extract.
* Reproduce
```cpp
SELECT * FROM regexp_test_chinese WHERE city REGEXP "^上海｜^北京" ORDER BY id;
```
Note, the `|` in above sql is a Chinese character.
@yiguolei
yiguoleiforce-pushed the auto-pick-44547-branch-2.1 branch from c9d8d52 to 28109d0CompareNovember 27, 2024 14:48
@yiguolei

yiguolei commented Nov 27, 2024

Copy link
Copy Markdown
Contributor

run buildall

@doris-robot

doris-robot commented Nov 27, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.74% (9608/26154)
Line Coverage: 28.13% (79031/280924)
Region Coverage: 26.82% (40629/151474)
Branch Coverage: 23.64% (20671/87442)
Coverage Report: http://coverage.selectdb-in.cc/coverage/28109d0d186f1612ce6f4f2a41abcc980c636241_28109d0d186f1612ce6f4f2a41abcc980c636241/report/index.html

@yiguolei
yiguolei merged commit e7520ae into branch-2.1Nov 28, 2024
@github-actions
github-actionsBot deleted the auto-pick-44547-branch-2.1 branch November 28, 2024 08:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@doris-robot@RoanHeNaN@yiguolei@dataroaring