[fix](ip) fix ip nullable param without check by amorynan · Pull Request #44700 · apache/doris

amorynan · 2024-11-27T15:49:09Z

What problem does this PR solve?

if we use ipv6_cidr_to_range function with nullable func which with invalid ipv6 will make be core

mysql> select id, ipv6_cidr_to_range(nullable(''), 32) from fn_test_ip_nullable order by id;


Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->

doris-robot · 2024-11-27T15:49:14Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

amorynan · 2024-11-28T01:32:54Z

run buildall

doris-robot · 2024-11-28T02:05:21Z

TeamCity be ut coverage result:
Function Coverage: 38.34% (9974/26017)
Line Coverage: 29.42% (83488/283780)
Region Coverage: 28.57% (42983/150449)
Branch Coverage: 25.18% (21827/86698)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c01b79bf8c161b710e3528d983e94445ec0b8d55_c01b79bf8c161b710e3528d983e94445ec0b8d55/report/index.html

github-actions · 2024-11-28T03:09:28Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-11-28T03:09:29Z

PR approved by anyone and no changes requested.

amorynan · 2024-11-30T03:28:43Z

run buildall

doris-robot · 2024-11-30T04:37:44Z

TeamCity be ut coverage result:
Function Coverage: 38.37% (9981/26014)
Line Coverage: 29.43% (83568/283994)
Region Coverage: 28.55% (43001/150621)
Branch Coverage: 25.17% (21847/86794)
Coverage Report: http://coverage.selectdb-in.cc/coverage/96f60c30bcf9ac7c11ce70cbd247104a46fcbac1_96f60c30bcf9ac7c11ce70cbd247104a46fcbac1/report/index.html

HappenLee

should delete the useless code of ColumnString

github-actions · 2024-12-02T05:40:51Z

PR approved by at least one committer and no changes requested.

amorynan · 2024-12-02T11:12:49Z

run buildall

HappenLee

LGTM

github-actions · 2024-12-02T11:39:16Z

PR approved by at least one committer and no changes requested.

doris-robot · 2024-12-02T11:42:06Z

TeamCity be ut coverage result:
Function Coverage: 38.39% (9978/25989)
Line Coverage: 29.45% (83651/284032)
Region Coverage: 28.58% (43042/150605)
Branch Coverage: 25.20% (21883/86832)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6c3d290e792adc3ce3df51047c03db0c5a7d9fbc_6c3d290e792adc3ce3df51047c03db0c5a7d9fbc/report/index.html

if we use ipv6_cidr_to_range function with nullable func which with invalid ipv6 will make be core ``` mysql> select id, ipv6_cidr_to_range(nullable(''), 32) from fn_test_ip_nullable order by id; ```

if we use ipv6_cidr_to_range function with nullable func which with invalid ipv6 will make be core ``` mysql> select id, ipv6_cidr_to_range(nullable(''), 32) from fn_test_ip_nullable order by id; ``` ### What problem does this PR solve? Related PR: #44700

if we use ipv6_cidr_to_range function with nullable func which with invalid ipv6 will make be core ``` mysql> select id, ipv6_cidr_to_range(nullable(''), 32) from fn_test_ip_nullable order by id; ```

amorynan added 2 commits November 27, 2024 22:07

fix ip nullable param without check
3113e28

fixed
c01b79b

zhangstar333 previously approved these changes Nov 28, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Nov 28, 2024

github-actionsBot added the reviewed label Nov 28, 2024

fix ip functions
96f60c3

amorynan dismissed zhangstar333’s stale review via 96f60c3November 30, 2024 02:56

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Nov 30, 2024

HappenLee previously approved these changes Dec 2, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 2, 2024

delete un use code
6c3d290

amorynan dismissed HappenLee’s stale review via 6c3d290December 2, 2024 11:12

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Dec 2, 2024

HappenLee approved these changes Dec 2, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 2, 2024

zhangstar333 approved these changes Dec 3, 2024
View reviewed changes

HappenLee merged commit 702ca90 into apache:masterDec 3, 2024

eldenmoon added dev/3.0.x dev/2.1.x labels Dec 4, 2024

github-actionsBot added dev/2.1.x-conflict dev/3.0.x-conflict labels Dec 4, 2024

HappenLee mentioned this pull request Jan 2, 2025
[fix](ip) fix ip nullable param without check (#44700) #46250
Merged
16 tasks

wm1581066 added dev/3.0.4-merged and removed dev/3.0.x dev/3.0.x-conflict labels Jan 3, 2025

wm1581066 added dev/2.1.8-merged and removed dev/2.1.x dev/2.1.x-conflict labels Jan 3, 2025

gavinchou mentioned this pull request Feb 18, 2025
Release Notes 3.0.4 #48013
Closed

Navigation Menu

Uh oh!

[fix](ip) fix ip nullable param without check - #44700

[fix](ip) fix ip nullable param without check#44700
HappenLee merged 4 commits into
apache:masterfrom
amorynan:fix-ip-funcs-with-params-not-check

amorynan commented Nov 27, 2024

Uh oh!

doris-robot commented Nov 27, 2024

Uh oh!

amorynan commented Nov 28, 2024

Uh oh!

doris-robot commented Nov 28, 2024

Uh oh!

github-actionsBot commented Nov 28, 2024

Uh oh!

github-actionsBot commented Nov 28, 2024

Uh oh!

amorynan commented Nov 30, 2024

Uh oh!

doris-robot commented Nov 30, 2024

Uh oh!

HappenLee left a comment •
edited
Loading

Uh oh!

github-actionsBot commented Dec 2, 2024

Uh oh!

amorynan commented Dec 2, 2024

Uh oh!

HappenLee left a comment

Uh oh!

github-actionsBot commented Dec 2, 2024

Uh oh!

doris-robot commented Dec 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

amorynan commented Nov 27, 2024

What problem does this PR solve?

Uh oh!

doris-robot commented Nov 27, 2024

Uh oh!

amorynan commented Nov 28, 2024

Uh oh!

doris-robot commented Nov 28, 2024

Uh oh!

github-actionsBot commented Nov 28, 2024

Uh oh!

github-actionsBot commented Nov 28, 2024

Uh oh!

amorynan commented Nov 30, 2024

Uh oh!

doris-robot commented Nov 30, 2024

Uh oh!

HappenLee left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Dec 2, 2024

Uh oh!

amorynan commented Dec 2, 2024

Uh oh!

HappenLee left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Dec 2, 2024

Uh oh!

doris-robot commented Dec 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

HappenLee left a comment •
edited
Loading