Skip to content

[fix](meta-service) Avoid rowset meta exceeds 2G result in protobuf fatal - #44780

Merged
dataroaring merged 5 commits into
apache:masterfrom
Hastyshell:fix-rowset-meta-too-big
Dec 9, 2024
Merged

[fix](meta-service) Avoid rowset meta exceeds 2G result in protobuf fatal#44780
dataroaring merged 5 commits into
apache:masterfrom
Hastyshell:fix-rowset-meta-too-big

Conversation

@Hastyshell

@HastyshellHastyshell commented Nov 29, 2024

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Rowset meta may exceed limit of 2GB incase of table of extremely wide variant type. Check the size before serializing.

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

doris-robot commented Nov 29, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Hastyshell

Hastyshell commented Nov 29, 2024

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@Hastyshell
Hastyshell marked this pull request as ready for review November 29, 2024 09:07
@Hastyshell
Hastyshellforce-pushed the fix-rowset-meta-too-big branch from 001b254 to ad0beddCompareNovember 29, 2024 09:10
@Hastyshell

Hastyshell commented Nov 29, 2024

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

gavinchou
gavinchou reviewed Dec 3, 2024
View reviewed changes
Comment threadcloud/src/meta-service/meta_service.cpp
@Hastyshell

Hastyshell commented Dec 5, 2024

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@Hastyshell

Hastyshell commented Dec 5, 2024

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@Hastyshell

Hastyshell commented Dec 5, 2024

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

dataroaring
dataroaring approved these changes Dec 9, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 9, 2024
@github-actions

github-actionsBot commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@dataroaring
dataroaring merged commit 8c5307e into apache:masterDec 9, 2024
github-actionsBot pushed a commit that referenced this pull request Dec 9, 2024
@HastyshellYour Name
[fix](meta-service) Avoid rowset meta exceeds 2G result in protobuf f…
b190938
…atal (#44780)
Rowset meta may exceed limit of 2GB incase of table of extremely wide
variant type. Check the size before serializing.
@github-actionsgithub-actionsBot mentioned this pull request Dec 9, 2024
Merged
dataroaring pushed a commit that referenced this pull request Dec 9, 2024
@github-actions@Hastyshell
branch-3.0: [fix](meta-service) Avoid rowset meta exceeds 2G result i…
d611e71
…n protobuf fatal #44780 (#45205)
Cherry-picked from #44780
Co-authored-by: Siyang Tang <tangsiyang2001@foxmail.com>
@gavinchougavinchou mentioned this pull request Feb 18, 2025
Closed
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@Hastyshell@HappenLee
[fix](meta-service) Avoid rowset meta exceeds 2G result in protobuf f…
f23a17b
…atal (apache#44780)
Rowset meta may exceed limit of 2GB incase of table of extremely wide
variant type. Check the size before serializing.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchougavinchougavinchou approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.4-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hastyshell@doris-robot@gavinchou@dataroaring