Skip to content

[fix](orc) check all the cases before build_search_argument (#44615) - #44801

Merged
morningman merged 1 commit into
apache:branch-2.1from
morningman:pick_44615_to_upstream-apache_branch-2.1
Nov 30, 2024
Merged

[fix](orc) check all the cases before build_search_argument (#44615)#44801
morningman merged 1 commit into
apache:branch-2.1from
morningman:pick_44615_to_upstream-apache_branch-2.1

Conversation

@morningman

@morningmanmorningman commented Nov 29, 2024

Copy link
Copy Markdown
Contributor

cherry-pick #44615

@suxiaogang223@morningman
[fix](orc) check all the cases before build_search_argument (apache#4…
0174028
…4615)
In the old logic, the `check_expr_can_push_down` function does not check
whether the `orc::Literal` are constructed successfully, but only checks
during `build_search_argument`. However, if it is found that the
`orc::Literal` fails to be constructed after `builder->startNot`, it
will fail because the builder cannot end `startNot`.
Therefore, we advance the behavior of constructing `orc::Literal` to the
`check_expr_can_push_down` function and save the result to the map, so
that it will never fail in the `build_search_argument` phase.
Related PR: apache#43255
@doris-robot

doris-robot commented Nov 29, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman

morningman commented Nov 29, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Nov 29, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.73% (9608/26157)
Line Coverage: 28.15% (79081/280935)
Region Coverage: 26.81% (40609/151451)
Branch Coverage: 23.63% (20660/87426)
Coverage Report: http://coverage.selectdb-in.cc/coverage/01740282be2980c8e5f6bfbb3a2bae91aecc1817_01740282be2980c8e5f6bfbb3a2bae91aecc1817/report/index.html

@morningman
morningman merged commit 4b15b1f into apache:branch-2.1Nov 30, 2024
@morningmanmorningman mentioned this pull request Dec 6, 2024
Closed
morningman added a commit to morningman/doris that referenced this pull request Dec 6, 2024
@morningman
Revert "[fix](orc) check all the cases before build_search_argument (a…
c4c7218
…pache#44615) (apache#44801)"
This reverts commit 4b15b1f.
@morningmanmorningman mentioned this pull request Dec 6, 2024
Merged
yiguolei pushed a commit that referenced this pull request Dec 6, 2024
@morningman
Revert#43255&#44615(#45096)
d4a6fd1
Revert "branch-2.1: [enhance](orc) Optimize ORC Predicate Pushdown for
OR-connected Predicate #43255 (#44438)"
Revert "[fix](orc) check all the cases before build_search_argument
(#44615) (#44801)"
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@morningman@doris-robot@suxiaogang223