Skip to content

[fix](cloud) fix CHECK failed when transmit from non-TTL to normal - #45057

Merged
gavinchou merged 1 commit into
apache:masterfrom
freemandealer:fix-core-when-transmit-from-ttl-to-normal
Dec 9, 2024
Merged

[fix](cloud) fix CHECK failed when transmit from non-TTL to normal#45057
gavinchou merged 1 commit into
apache:masterfrom
freemandealer:fix-core-when-transmit-from-ttl-to-normal

Conversation

@freemandealer

@freemandealerfreemandealer commented Dec 5, 2024

Copy link
Copy Markdown
Member

we need not transmit non-TTL cache to normal, just exclude them.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@freemandealer
[fix](cloud) fix CHECK failed when transmit from non-TTL to normal
8d088cd
we need not transmit noon-TTL cache to normal
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@doris-robot

doris-robot commented Dec 5, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer

freemandealer commented Dec 5, 2024

Copy link
Copy Markdown
MemberAuthor

run buildall

@doris-robot

doris-robot commented Dec 5, 2024

Copy link
Copy Markdown
TPC-H: Total hot run time: 39890 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8d088cdcd86ca2a1ad664773f0d634cc240db748, data reload: false
------ Round 1 ----------------------------------
q1	17576	7446	7300	7300
q2	2044	178	165	165
q3	10576	1103	1211	1103
q4	10581	761	665	665
q5	7610	2733	2623	2623
q6	238	148	152	148
q7	981	620	604	604
q8	9248	1897	1882	1882
q9	6704	6484	6496	6484
q10	7014	2272	2323	2272
q11	470	266	260	260
q12	412	226	224	224
q13	17790	3038	3082	3038
q14	240	209	226	209
q15	571	526	532	526
q16	661	600	586	586
q17	968	465	519	465
q18	7204	6693	6702	6693
q19	1361	1036	1037	1036
q20	451	178	173	173
q21	4230	3203	3113	3113
q22	380	321	321	321
Total cold run time: 107310 ms
Total hot run time: 39890 ms
----- Round 2, with runtime_filter_mode=off -----
q1	7257	7222	7226	7222
q2	325	229	232	229
q3	2885	2757	2929	2757
q4	2102	1822	1831	1822
q5	5672	5674	5642	5642
q6	222	143	141	141
q7	2252	1783	1823	1783
q8	3366	3522	3476	3476
q9	9026	9057	9046	9046
q10	3592	3548	3568	3548
q11	615	508	508	508
q12	801	606	603	603
q13	10976	3298	3247	3247
q14	328	275	278	275
q15	580	537	530	530
q16	689	649	641	641
q17	1865	1614	1650	1614
q18	8333	7715	7620	7620
q19	1712	1555	1603	1555
q20	2109	1899	1888	1888
q21	5596	5408	5492	5408
q22	659	584	564	564
Total cold run time: 70962 ms
Total hot run time: 60119 ms

@doris-robot

doris-robot commented Dec 5, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 38.48% (10007/26003)
Line Coverage: 29.51% (83885/284298)
Region Coverage: 28.62% (43126/150692)
Branch Coverage: 25.21% (21923/86952)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8d088cdcd86ca2a1ad664773f0d634cc240db748_8d088cdcd86ca2a1ad664773f0d634cc240db748/report/index.html

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 5, 2024
@github-actions

github-actionsBot commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@doris-robot

doris-robot commented Dec 5, 2024

Copy link
Copy Markdown
TPC-DS: Total hot run time: 197561 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8d088cdcd86ca2a1ad664773f0d634cc240db748, data reload: false
query1	1486	967	925	925
query2	6257	2013	2027	2013
query3	10977	4381	4443	4381
query4	66976	29711	23667	23667
query5	4863	499	465	465
query6	422	214	189	189
query7	5618	305	298	298
query8	335	238	245	238
query9	8971	2727	2715	2715
query10	469	269	256	256
query11	17338	15458	15869	15458
query12	164	111	108	108
query13	1532	427	435	427
query14	10493	7061	7336	7061
query15	223	184	190	184
query16	6998	462	491	462
query17	1234	602	563	563
query18	1743	328	304	304
query19	213	160	157	157
query20	123	111	116	111
query21	222	116	104	104
query22	4859	4601	4406	4406
query23	35520	34497	34449	34449
query24	5453	2430	2493	2430
query25	498	383	395	383
query26	684	151	152	151
query27	1932	283	278	278
query28	4685	2498	2466	2466
query29	645	421	420	420
query30	210	157	151	151
query31	1025	827	856	827
query32	66	53	54	53
query33	425	289	298	289
query34	935	524	535	524
query35	917	784	781	781
query36	1125	961	972	961
query37	124	72	73	72
query38	4535	4378	4470	4378
query39	1557	1477	1517	1477
query40	209	103	102	102
query41	44	42	41	41
query42	112	102	101	101
query43	526	498	498	498
query44	1224	848	821	821
query45	192	170	169	169
query46	1173	778	763	763
query47	2031	1910	1919	1910
query48	420	346	314	314
query49	724	388	410	388
query50	856	402	399	399
query51	7352	7169	7285	7169
query52	96	86	86	86
query53	261	187	177	177
query54	503	397	388	388
query55	75	72	78	72
query56	257	248	238	238
query57	1236	1124	1092	1092
query58	225	205	211	205
query59	3137	2960	2934	2934
query60	278	241	248	241
query61	108	105	141	105
query62	803	659	654	654
query63	213	199	182	182
query64	1379	669	659	659
query65	3324	3197	3187	3187
query66	713	302	320	302
query67	16174	15662	15756	15662
query68	4051	597	579	579
query69	429	250	259	250
query70	1196	1143	1156	1143
query71	328	239	252	239
query72	6182	4044	4132	4044
query73	757	354	358	354
query74	10193	9062	9003	9003
query75	3395	2695	2696	2695
query76	1764	1061	1081	1061
query77	494	299	281	281
query78	10585	9433	9512	9433
query79	1762	581	606	581
query80	1429	438	427	427
query81	513	239	232	232
query82	1270	125	112	112
query83	258	148	146	146
query84	328	74	68	68
query85	990	315	291	291
query86	428	293	279	279
query87	4781	4614	4555	4555
query88	3679	2189	2154	2154
query89	426	299	301	299
query90	1888	187	189	187
query91	136	103	104	103
query92	63	50	51	50
query93	2228	552	543	543
query94	889	296	316	296
query95	347	257	255	255
query96	614	277	285	277
query97	2845	2676	2678	2676
query98	216	205	200	200
query99	1619	1307	1340	1307
Total cold run time: 321580 ms
Total hot run time: 197561 ms

@doris-robot

doris-robot commented Dec 5, 2024

Copy link
Copy Markdown
ClickBench: Total hot run time: 31.81 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8d088cdcd86ca2a1ad664773f0d634cc240db748, data reload: false
query1	0.04	0.03	0.03
query2	0.08	0.03	0.04
query3	0.23	0.07	0.07
query4	1.63	0.11	0.10
query5	0.42	0.42	0.40
query6	1.18	0.66	0.65
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.59	0.49	0.50
query10	0.56	0.56	0.59
query11	0.15	0.11	0.11
query12	0.14	0.11	0.12
query13	0.61	0.62	0.59
query14	2.85	2.68	2.74
query15	0.90	0.84	0.82
query16	0.39	0.38	0.38
query17	1.02	1.07	1.08
query18	0.23	0.22	0.21
query19	1.91	1.80	1.93
query20	0.01	0.01	0.02
query21	15.36	0.58	0.58
query22	2.58	1.94	1.62
query23	17.14	1.01	0.79
query24	2.92	1.76	0.47
query25	0.25	0.19	0.09
query26	0.54	0.13	0.13
query27	0.04	0.05	0.04
query28	10.57	1.11	1.08
query29	12.58	3.20	3.16
query30	0.25	0.06	0.08
query31	2.85	0.37	0.38
query32	3.28	0.47	0.47
query33	2.99	3.03	3.12
query34	16.87	4.46	4.47
query35	4.54	4.53	4.56
query36	0.66	0.47	0.50
query37	0.09	0.07	0.06
query38	0.05	0.04	0.03
query39	0.04	0.03	0.03
query40	0.16	0.12	0.12
query41	0.08	0.03	0.02
query42	0.04	0.03	0.02
query43	0.03	0.04	0.03
Total cold run time: 106.91 s
Total hot run time: 31.81 s

dataroaring
dataroaring approved these changes Dec 6, 2024
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinchou
gavinchou merged commit f4ca6da into apache:masterDec 9, 2024
github-actionsBot pushed a commit that referenced this pull request Dec 9, 2024
@freemandealerYour Name
[fix](cloud) fix CHECK failed when transmit from non-TTL to normal (#…
a050884
…45057)
we need not transmit non-TTL cache to normal, just exclude them.
@github-actionsgithub-actionsBot mentioned this pull request Dec 9, 2024
Merged
gavinchou pushed a commit that referenced this pull request Dec 10, 2024
@github-actions
branch-3.0: [fix](cloud) fix CHECK failed when transmit from non-TTL …
112bbb8
…to normal #45057 (#45182)
Cherry-picked from #45057
@gavinchougavinchou mentioned this pull request Feb 18, 2025
Closed
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@freemandealer@HappenLee
[fix](cloud) fix CHECK failed when transmit from non-TTL to normal (a…
883f1b9
…pache#45057)
we need not transmit non-TTL cache to normal, just exclude them.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchougavinchougavinchou approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.4-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@freemandealer@doris-robot@gavinchou@dataroaring@wm1581066