Skip to content

[fix](recycler) Process self-defined domain names for s3 storage vault - #45072

Merged
dataroaring merged 1 commit into
apache:masterfrom
gavinchou:gavin-fix-recycle-s3-path-style
Dec 6, 2024
Merged

[fix](recycler) Process self-defined domain names for s3 storage vault#45072
dataroaring merged 1 commit into
apache:masterfrom
gavinchou:gavin-fix-recycle-s3-path-style

Conversation

@gavinchou

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou

Copy link
Copy Markdown
ContributorAuthor

run buildall

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 6, 2024
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@dataroaringdataroaring added the usercase Important user case type label label Dec 6, 2024
@dataroaring
dataroaring merged commit 1a03fed into apache:masterDec 6, 2024
dataroaring pushed a commit that referenced this pull request Dec 6, 2024
…storage vault #45072 (#45100)
Cherry-picked from #45072
Co-authored-by: Gavin Chou <gavin@selectdb.com>
@gavinchougavinchou mentioned this pull request Feb 18, 2025
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.4-mergedreviewedusercaseImportant user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@gavinchou@doris-robot@Yukang-Lian@dataroaring