Skip to content

[refactor](shuffle) (PART I) Unify all hash-partition based shuffling - #45256

Merged
Gabriel39 merged 4 commits into
apache:masterfrom
Gabriel39:refactor_1210
Dec 11, 2024
Merged

[refactor](shuffle) (PART I) Unify all hash-partition based shuffling#45256
Gabriel39 merged 4 commits into
apache:masterfrom
Gabriel39:refactor_1210

Conversation

@Gabriel39

@Gabriel39Gabriel39 commented Dec 10, 2024

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot

doris-robot commented Dec 10, 2024

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39

Gabriel39 commented Dec 10, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

github-actions[bot]
github-actionsBot reviewed Dec 10, 2024
View reviewed changes

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment threadbe/src/pipeline/shuffle/writer.cpp
@doris-robot

doris-robot commented Dec 10, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 38.76% (10104/26068)
Line Coverage: 29.69% (84710/285343)
Region Coverage: 28.76% (43489/151206)
Branch Coverage: 25.32% (22093/87256)
Coverage Report: http://coverage.selectdb-in.cc/coverage/401738f352562c29c080e26b7c0b81ef891ee26e_401738f352562c29c080e26b7c0b81ef891ee26e/report/index.html

@Gabriel39

Gabriel39 commented Dec 10, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Dec 10, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 38.76% (10104/26069)
Line Coverage: 29.70% (84748/285355)
Region Coverage: 28.76% (43492/151214)
Branch Coverage: 25.32% (22091/87260)
Coverage Report: http://coverage.selectdb-in.cc/coverage/06e554fc8bfaf78fa3be06316030d9dede6d60f6_06e554fc8bfaf78fa3be06316030d9dede6d60f6/report/index.html

@Gabriel39

Gabriel39 commented Dec 11, 2024

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Dec 11, 2024

Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 38.76% (10104/26069)
Line Coverage: 29.69% (84717/285359)
Region Coverage: 28.76% (43496/151221)
Branch Coverage: 25.32% (22094/87264)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3bd3f262c4863c5488ce050fc4b565a51eee7aa9_3bd3f262c4863c5488ce050fc4b565a51eee7aa9/report/index.html

@Gabriel39Gabriel39 changed the title [refactor](shuffle) Unify all hash-partition based shuffling[refactor](shuffle) (PART I) Unify all hash-partition based shufflingDec 11, 2024
@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 11, 2024
@github-actions

github-actionsBot commented Dec 11, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Dec 11, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@Gabriel39
Gabriel39 merged commit d1e8beb into apache:masterDec 11, 2024
@zclllyybbzclllyybb mentioned this pull request Mar 5, 2025
Merged
16 tasks
zclllyybb added a commit that referenced this pull request Jan 27, 2026
@zclllyybb
[Refactor](shuffle) Fix wrong deal of batching block in TabletSinkHas…
9571a91
…hPartitioner (#48720)
Related PR: bug introduced by
#44102, expanded by
#45256, partially fixed by
#47911
Problem Summary:
also fixed Auto Partition + Auto Increment-Column may core dump in
loading
zclllyybb added a commit to zclllyybb/doris that referenced this pull request Jan 27, 2026
@zclllyybb
[Refactor](shuffle) Fix wrong deal of batching block in TabletSinkHas…
bb3d97c
…hPartitioner (apache#48720)
Related PR: bug introduced by
apache#44102, expanded by
apache#45256, partially fixed by
apache#47911
Problem Summary:
also fixed Auto Partition + Auto Increment-Column may core dump in
loading
zclllyybb added a commit to zclllyybb/doris that referenced this pull request Jan 27, 2026
@zclllyybb
[Refactor](shuffle) Fix wrong deal of batching block in TabletSinkHas…
c067462
…hPartitioner (apache#48720)
Related PR: bug introduced by
apache#44102, expanded by
apache#45256, partially fixed by
apache#47911
Problem Summary:
also fixed Auto Partition + Auto Increment-Column may core dump in
loading
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@Gabriel39@HappenLee
[refactor](shuffle) (PART I) Unify all hash-partition based shuffling (…
27c1be5
…apache#45256)
@Gabriel39
Gabriel39 deleted the refactor_1210 branch July 30, 2026 06:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@BiteTheDDDDtBiteTheDDDDtBiteTheDDDDt approved these changes
@MryangeMryangeMryange approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Gabriel39@doris-robot@BiteTheDDDDt@Mryange