Uh oh!
There was an error while loading. Please reload this page.
[revert](memory) Revert disable Jemalloc Hook - #45507
Closed
xinyiZzz wants to merge 1 commit into
Closed
Conversation
…time (apache#45210)" This reverts commit c5a2307.
Thearas
commented
Dec 17, 2024
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
xinyiZzz
commented
Dec 17, 2024
ContributorAuthor
run buildall |
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
doris-robot
commented
Dec 17, 2024
TeamCity be ut coverage result: |
doris-robot
commented
Dec 17, 2024
TPC-H: Total hot run time: 39985 ms |
doris-robot
commented
Dec 17, 2024
TPC-DS: Total hot run time: 195940 ms |
doris-robot
commented
Dec 17, 2024
ClickBench: Total hot run time: 32.41 s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
It is not easy to remove
with-jemalloc-prefix, which may affect the compatibility between third-party and old version codes.Also, will building failed on Mac, it said can't find mallctl symbol. because jemalloc's default prefix on macOS is "je_", not "".
Maybe can use alias instead of override.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)