Uh oh!
There was an error while loading. Please reload this page.
[opt](recycler) Improve robustness and observability - #45617
Merged
gavinchou merged 5 commits intoDec 24, 2024
Merged
Conversation
hello-stephen
commented
Dec 18, 2024
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
clang-tidy review says "All clean, LGTM! 👍" |
gavinchou
commented
Dec 18, 2024
ContributorAuthor
run buildall |
qidaye
commented
Dec 19, 2024
Contributor
run p1 |
Yukang-Lian
approved these changes
Dec 19, 2024
Contributor
PR approved by anyone and no changes requested. |
hello-stephen
commented
Dec 20, 2024
Contributor
run cloud_p1 |
hello-stephen
commented
Dec 20, 2024
Contributor
run p1 |
gavinchou
commented
Dec 20, 2024
ContributorAuthor
run buildall |
Contributor
PR approved by at least one committer and no changes requested. |
github-actionsBot
pushed a commit
that referenced
this pull request
Dec 24, 2024
1. Fix delete non-existed object, the original impl. does not handle
correctly
2. Add recycle lag indicators: bvars for index, partition, rowset and
txn
1. `recycle_index_earlest_ts_${instance_id}` dropped table/mv 2. `recycle_partition_earlest_ts_${instance_id}` dropped partitions
3. `recycle_rowset_earlest_ts_${instance_id}` compacted rowset
4. `recycle_tmp_rowset_earlest_ts_${instance_id}` aborted transactions
tmp data
5. `recycle_expired_txn_label_earlest_ts_${instance_id}` expired labels
and transactions
4. Add retry for scan_and_recycle() to prevent KV error like "Request
future version"
6. Fix recycle delete instance may leak object data: we have to delete
data first before delete KV
7. Improve code readability: remove duplicated code and add more
commentsdataroaring pushed a commit
that referenced
this pull request
Dec 25, 2024
16 tasks
Closed
HappenLee pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
1. Fix delete non-existed object, the original impl. does not handle
correctly
2. Add recycle lag indicators: bvars for index, partition, rowset and
txn
1. `recycle_index_earlest_ts_${instance_id}` dropped table/mv 2. `recycle_partition_earlest_ts_${instance_id}` dropped partitions
3. `recycle_rowset_earlest_ts_${instance_id}` compacted rowset
4. `recycle_tmp_rowset_earlest_ts_${instance_id}` aborted transactions
tmp data
5. `recycle_expired_txn_label_earlest_ts_${instance_id}` expired labels
and transactions
4. Add retry for scan_and_recycle() to prevent KV error like "Request
future version"
6. Fix recycle delete instance may leak object data: we have to delete
data first before delete KV
7. Improve code readability: remove duplicated code and add more
comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
recycle_index_earlest_ts_${instance_id}dropped table/mvrecycle_partition_earlest_ts_${instance_id}dropped partitionsrecycle_rowset_earlest_ts_${instance_id}compacted rowsetrecycle_tmp_rowset_earlest_ts_${instance_id}aborted transactions tmp datarecycle_expired_txn_label_earlest_ts_${instance_id}expired labels and transactionsProblem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)