Skip to content

[fix](variable) force update variable not work as expected - #45648

Merged
morrySnow merged 1 commit into
apache:masterfrom
morrySnow:fix_force_update_variable
Dec 20, 2024
Merged

[fix](variable) force update variable not work as expected#45648
morrySnow merged 1 commit into
apache:masterfrom
morrySnow:fix_force_update_variable

Conversation

@morrySnow

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Related PR: #41607

Problem Summary:

should not reset variable version when replay edit log

Release note

None

Check List (For Author)

  • Test
    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
set global enable_fallback_to_original_planner=true;

and then restart FE, this variable do not be set to false again.

  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

related PR apache#41607
should not reset variable version when replay edit log
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 19, 2024
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morrySnow

Copy link
Copy Markdown
ContributorAuthor

run buildall

@morrySnow
morrySnow merged commit 62ff850 into apache:masterDec 20, 2024
@morrySnow
morrySnow deleted the fix_force_update_variable branch December 20, 2024 04:03
github-actionsBot pushed a commit that referenced this pull request Dec 20, 2024
### What problem does this PR solve?
Related PR: #41607
Problem Summary:
should not reset variable version when replay edit log
github-actionsBot pushed a commit that referenced this pull request Dec 20, 2024
### What problem does this PR solve?
Related PR: #41607
Problem Summary:
should not reset variable version when replay edit log
morrySnow added a commit that referenced this pull request Dec 20, 2024
…#45648 (#45696)
Cherry-picked from #45648
Co-authored-by: morrySnow <zhangwenxin@selectdb.com>
morrySnow added a commit that referenced this pull request Dec 24, 2024
…#45648 (#45695)
Cherry-picked from #45648
Co-authored-by: morrySnow <zhangwenxin@selectdb.com>
morrySnow added a commit that referenced this pull request Jan 7, 2025
### What problem does this PR solve?
Related PR: #41607#45648
Problem Summary:
org.apache.doris.qe.GlobalVariable#getPersistentGlobalVarNames should
use bit and to check whether variable is Global
github-actionsBot pushed a commit that referenced this pull request Jan 7, 2025
### What problem does this PR solve?
Related PR: #41607#45648
Problem Summary:
org.apache.doris.qe.GlobalVariable#getPersistentGlobalVarNames should
use bit and to check whether variable is Global
github-actionsBot pushed a commit that referenced this pull request Jan 7, 2025
### What problem does this PR solve?
Related PR: #41607#45648
Problem Summary:
org.apache.doris.qe.GlobalVariable#getPersistentGlobalVarNames should
use bit and to check whether variable is Global
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
)
### What problem does this PR solve?
Related PR: apache#41607
Problem Summary:
should not reset variable version when replay edit log
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.8-mergeddev/3.0.4-mergedp0_breviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@morrySnow@hello-stephen@924060929@yiguolei@CalvinKirs