Skip to content

[fix](recycler) Fix CountdownEvent error and hang - #45760

Merged
w41ter merged 4 commits into
apache:masterfrom
Yukang-Lian:Fix-Countdown
Dec 24, 2024
Merged

[fix](recycler) Fix CountdownEvent error and hang#45760
w41ter merged 4 commits into
apache:masterfrom
Yukang-Lian:Fix-Countdown

Conversation

@Yukang-Lian

@Yukang-LianYukang-Lian commented Dec 21, 2024

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Fix CountdownEvent error "Invoking add_count() after wait() was invoked"

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Dec 21, 2024

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Yukang-Lian

Yukang-Lian commented Dec 21, 2024

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

gavinchou
gavinchou reviewed Dec 22, 2024
View reviewed changes
Comment threadcloud/src/recycler/sync_executor.h Outdated
@dataroaringdataroaring added usercase Important user case type label dev/3.0.x labels Dec 23, 2024
@Yukang-Lian

Yukang-Lian commented Dec 23, 2024

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

gavinchou
gavinchou reviewed Dec 23, 2024
View reviewed changes
Comment threadcloud/src/recycler/sync_executor.h Outdated
@Yukang-Lian

Yukang-Lian commented Dec 23, 2024

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

gavinchou
gavinchou reviewed Dec 23, 2024
View reviewed changes
Comment threadcloud/src/recycler/sync_executor.h Outdated
gavinchou
gavinchou approved these changes Dec 23, 2024
View reviewed changes

@gavinchougavinchou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run buildall

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 23, 2024
@github-actions

github-actionsBot commented Dec 23, 2024

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Dec 23, 2024

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@gavinchougavinchou changed the title [fix](recycler) Fix CountdownEvent error[fix](recycler) Fix CountdownEvent error "Invoking add_count() after wait() was invoked"Dec 23, 2024
@gavinchougavinchou changed the title [fix](recycler) Fix CountdownEvent error "Invoking add_count() after wait() was invoked"[fix](recycler) Fix CountdownEvent error and hang-upDec 23, 2024
@gavinchougavinchou changed the title [fix](recycler) Fix CountdownEvent error and hang-up[fix](recycler) Fix CountdownEvent error and hangDec 23, 2024
@Yukang-Lian

Yukang-Lian commented Dec 24, 2024

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@w41ter
w41ter merged commit e3b18b5 into apache:masterDec 24, 2024
github-actionsBot pushed a commit that referenced this pull request Dec 24, 2024
@Yukang-Lian@gavinchouYour Name
[fix](recycler) Fix CountdownEvent error and hang (#45760)
7ad4af6
Fix CountdownEvent error "Invoking add_count() after wait() was invoked"
---------
Co-authored-by: Gavin Chou <gavineaglechou@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Dec 24, 2024
Merged
gavinchou added a commit that referenced this pull request Dec 24, 2024
@github-actions@Yukang-Lian@gavinchou
branch-3.0: [fix](recycler) Fix CountdownEvent error and hang#45760(#…
bfd5966
…45853)
Cherry-picked from #45760
Co-authored-by: abmdocrt <lianyukang@selectdb.com>
Co-authored-by: Gavin Chou <gavineaglechou@gmail.com>
BiteTheDDDDt pushed a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Feb 7, 2025
@Yukang-Lian@gavinchou
[fix](recycler) Fix CountdownEvent error and hang (apache#45760) (apa…
c1046ee
…che#3707)
Fix CountdownEvent error "Invoking add_count() after wait() was invoked"
Co-authored-by: Gavin Chou <gavineaglechou@gmail.com>
@gavinchougavinchou mentioned this pull request Feb 18, 2025
Closed
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026
@Yukang-Lian@gavinchou@HappenLee
[fix](recycler) Fix CountdownEvent error and hang (apache#45760)
0c14afd
Fix CountdownEvent error "Invoking add_count() after wait() was invoked"
---------
Co-authored-by: Gavin Chou <gavineaglechou@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchougavinchougavinchou approved these changes
@bobhan1bobhan1bobhan1 approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.4-mergedp0_creviewedusercaseImportant user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Yukang-Lian@Thearas@gavinchou@bobhan1@w41ter@dataroaring