[improvement](information_schema)Show view definition in information_schema.views. by Jibing-Li · Pull Request #45857 · apache/doris

Jibing-Li · 2024-12-24T08:02:32Z

What problem does this PR solve?

Support show view definition sql in information_schema.views.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2024-12-24T08:02:37Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

Jibing-Li · 2024-12-24T08:04:25Z

run buildall

github-actions · 2024-12-24T08:04:38Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-12-24T08:04:40Z

PR approved by anyone and no changes requested.

doris-robot · 2024-12-24T08:24:11Z

TPC-H: Total hot run time: 40129 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9d8d5eb726083556b7e2ec219cab5dd2611181aa, data reload: false
------ Round 1 ----------------------------------
q1	17594	7434	7285	7285
q2	2040	178	169	169
q3	10545	1163	1234	1163
q4	10222	744	681	681
q5	7597	2720	2746	2720
q6	232	145	149	145
q7	984	625	613	613
q8	9235	1862	1891	1862
q9	6783	6439	6471	6439
q10	7005	2307	2306	2306
q11	471	267	266	266
q12	547	224	219	219
q13	17766	2993	2944	2944
q14	246	215	207	207
q15	549	516	498	498
q16	678	609	603	603
q17	984	578	569	569
q18	7366	6777	6767	6767
q19	1348	1054	924	924
q20	468	184	185	184
q21	4048	3378	3248	3248
q22	380	324	317	317
Total cold run time: 107088 ms
Total hot run time: 40129 ms
----- Round 2, with runtime_filter_mode=off -----
q1	7207	7239	7186	7186
q2	331	237	231	231
q3	2961	2728	2763	2728
q4	1974	1735	1691	1691
q5	5367	5376	5383	5376
q6	219	140	142	140
q7	2136	1694	1757	1694
q8	3265	3366	3414	3366
q9	8567	8637	8556	8556
q10	3522	3457	3479	3457
q11	585	491	503	491
q12	753	580	588	580
q13	14528	3015	3009	3009
q14	286	264	263	263
q15	543	495	491	491
q16	681	628	646	628
q17	1790	1609	1555	1555
q18	7823	7354	7260	7260
q19	1697	1580	1574	1574
q20	2071	1839	1836	1836
q21	5503	5187	5260	5187
q22	644	602	585	585
Total cold run time: 72453 ms
Total hot run time: 57884 ms

doris-robot · 2024-12-24T08:36:11Z

TPC-DS: Total hot run time: 191341 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9d8d5eb726083556b7e2ec219cab5dd2611181aa, data reload: false
query1	866	393	378	378
query2	3731	2484	2525	2484
query3	6590	215	210	210
query4	33697	23658	23781	23658
query5	2547	477	474	474
query6	283	184	182	182
query7	4588	295	301	295
query8	315	240	233	233
query9	9607	2761	2764	2761
query10	467	257	246	246
query11	18645	15057	15017	15017
query12	157	99	106	99
query13	1686	423	399	399
query14	10671	7684	7594	7594
query15	272	182	190	182
query16	7756	466	457	457
query17	1911	593	583	583
query18	2023	307	322	307
query19	354	151	143	143
query20	111	104	109	104
query21	208	100	100	100
query22	4543	4434	4332	4332
query23	34753	33865	33338	33338
query24	10995	2555	2352	2352
query25	614	367	380	367
query26	1342	150	152	150
query27	2868	330	337	330
query28	8008	2442	2485	2442
query29	880	395	401	395
query30	298	151	145	145
query31	1014	827	819	819
query32	105	62	58	58
query33	787	287	284	284
query34	1121	536	509	509
query35	887	730	729	729
query36	1087	916	939	916
query37	211	75	72	72
query38	4319	4041	4055	4041
query39	1603	1446	1440	1440
query40	252	102	108	102
query41	46	47	43	43
query42	114	101	101	101
query43	526	494	482	482
query44	1202	795	800	795
query45	180	160	170	160
query46	1166	695	716	695
query47	1986	1866	1856	1856
query48	416	320	321	320
query49	1186	386	377	377
query50	802	386	378	378
query51	7158	6979	7043	6979
query52	108	97	98	97
query53	256	184	184	184
query54	1274	400	407	400
query55	80	79	81	79
query56	251	237	239	237
query57	1253	1124	1109	1109
query58	230	221	231	221
query59	3267	2964	3032	2964
query60	274	246	266	246
query61	112	104	103	103
query62	933	725	737	725
query63	220	190	189	189
query64	4358	674	645	645
query65	3217	3191	3221	3191
query66	1270	307	310	307
query67	15797	15560	15555	15555
query68	5797	570	567	567
query69	427	251	249	249
query70	1204	1161	1140	1140
query71	404	251	252	251
query72	6496	4081	4159	4081
query73	770	358	356	356
query74	9966	9015	9021	9015
query75	3416	2644	2648	2644
query76	3620	1178	1146	1146
query77	552	276	272	272
query78	10245	9600	9476	9476
query79	2218	621	603	603
query80	917	424	416	416
query81	544	246	228	228
query82	840	120	128	120
query83	179	148	143	143
query84	259	71	67	67
query85	1191	306	303	303
query86	401	296	289	289
query87	4681	4310	4564	4310
query88	4053	2199	2201	2199
query89	413	298	303	298
query90	2235	196	186	186
query91	133	101	103	101
query92	68	56	50	50
query93	1772	565	551	551
query94	1129	288	290	288
query95	349	248	248	248
query96	610	275	277	275
query97	2882	2704	2676	2676
query98	224	202	198	198
query99	1687	1452	1430	1430
Total cold run time: 299536 ms
Total hot run time: 191341 ms

doris-robot · 2024-12-24T08:41:43Z

ClickBench: Total hot run time: 32.05 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9d8d5eb726083556b7e2ec219cab5dd2611181aa, data reload: false
query1	0.03	0.03	0.03
query2	0.07	0.02	0.04
query3	0.24	0.08	0.07
query4	1.60	0.10	0.11
query5	0.44	0.41	0.41
query6	1.17	0.65	0.65
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.53	0.51
query10	0.55	0.57	0.56
query11	0.15	0.10	0.10
query12	0.14	0.11	0.12
query13	0.62	0.59	0.60
query14	2.71	2.74	2.87
query15	0.89	0.81	0.84
query16	0.38	0.37	0.38
query17	1.05	1.06	0.99
query18	0.22	0.20	0.20
query19	1.99	1.89	2.00
query20	0.02	0.00	0.01
query21	15.38	0.59	0.60
query22	2.74	3.31	1.79
query23	17.04	1.08	0.83
query24	2.69	0.56	1.68
query25	0.21	0.07	0.17
query26	0.42	0.14	0.15
query27	0.03	0.05	0.04
query28	10.67	1.10	1.07
query29	12.59	3.25	3.22
query30	0.25	0.07	0.06
query31	2.84	0.38	0.39
query32	3.25	0.46	0.45
query33	3.06	3.04	3.06
query34	17.13	4.41	4.46
query35	4.48	4.42	4.52
query36	0.67	0.48	0.48
query37	0.10	0.06	0.05
query38	0.04	0.03	0.03
query39	0.02	0.02	0.02
query40	0.16	0.13	0.14
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.8 s
Total hot run time: 32.05 s

doris-robot · 2024-12-24T08:43:27Z

TeamCity be ut coverage result:
Function Coverage: 38.80% (10093/26015)
Line Coverage: 29.77% (85111/285869)
Region Coverage: 28.90% (43462/150406)
Branch Coverage: 25.43% (22152/87118)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9d8d5eb726083556b7e2ec219cab5dd2611181aa_9d8d5eb726083556b7e2ec219cab5dd2611181aa/report/index.html

Jibing-Li · 2024-12-24T09:29:49Z

run buildall

doris-robot · 2024-12-24T09:49:06Z

TPC-H: Total hot run time: 40078 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2e178c32af92ffc88c69834a403ffede09707edc, data reload: false
------ Round 1 ----------------------------------
q1	17639	7448	7297	7297
q2	2048	173	180	173
q3	10552	1143	1177	1143
q4	10229	757	721	721
q5	7607	2720	2700	2700
q6	240	147	151	147
q7	998	635	606	606
q8	9234	1917	1904	1904
q9	6640	6417	6400	6400
q10	6993	2394	2321	2321
q11	459	260	270	260
q12	417	218	223	218
q13	17747	2922	2895	2895
q14	250	215	220	215
q15	548	506	501	501
q16	692	589	604	589
q17	976	546	515	515
q18	7435	6833	6783	6783
q19	1349	1095	1011	1011
q20	474	185	180	180
q21	4013	3313	3189	3189
q22	388	312	310	310
Total cold run time: 106928 ms
Total hot run time: 40078 ms
----- Round 2, with runtime_filter_mode=off -----
q1	7283	7276	7274	7274
q2	340	231	231	231
q3	2860	2787	3023	2787
q4	2110	1839	1890	1839
q5	5560	5682	5670	5670
q6	226	140	142	140
q7	2164	1818	1787	1787
q8	3347	3500	3496	3496
q9	8955	8865	8891	8865
q10	3636	3601	3583	3583
q11	596	523	498	498
q12	798	625	626	625
q13	13505	3171	3056	3056
q14	315	285	272	272
q15	570	490	505	490
q16	692	670	660	660
q17	1803	1586	1566	1566
q18	7939	7469	7388	7388
q19	1713	1501	1572	1501
q20	2068	1826	1878	1826
q21	5494	5314	5184	5184
q22	632	556	574	556
Total cold run time: 72606 ms
Total hot run time: 59294 ms

doris-robot · 2024-12-24T10:01:13Z

TPC-DS: Total hot run time: 190169 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2e178c32af92ffc88c69834a403ffede09707edc, data reload: false
query1	964	399	394	394
query2	6535	2403	2360	2360
query3	6703	211	210	210
query4	33824	23653	23717	23653
query5	4301	473	446	446
query6	281	193	191	191
query7	4624	306	306	306
query8	308	249	231	231
query9	9805	2763	2763	2763
query10	462	243	273	243
query11	18607	15015	15031	15015
query12	166	104	106	104
query13	1681	446	420	420
query14	9872	6643	6747	6643
query15	266	175	190	175
query16	8214	438	466	438
query17	1635	587	574	574
query18	2117	293	292	292
query19	358	156	145	145
query20	114	114	131	114
query21	210	101	102	101
query22	4508	4419	4356	4356
query23	34331	33174	33205	33174
query24	12565	2483	2442	2442
query25	679	377	377	377
query26	1869	146	155	146
query27	3030	344	321	321
query28	7609	2472	2473	2472
query29	1053	400	408	400
query30	297	151	161	151
query31	1067	842	787	787
query32	92	57	56	56
query33	781	289	279	279
query34	1072	519	510	510
query35	908	735	748	735
query36	1103	949	952	949
query37	280	75	74	74
query38	4285	4210	4271	4210
query39	1507	1442	1432	1432
query40	280	101	98	98
query41	49	46	49	46
query42	117	102	107	102
query43	543	498	491	491
query44	1279	805	804	804
query45	185	160	163	160
query46	1141	710	697	697
query47	2035	1915	1899	1899
query48	405	323	315	315
query49	1276	385	372	372
query50	787	375	384	375
query51	7247	7167	6968	6968
query52	99	92	93	92
query53	259	181	185	181
query54	1189	403	411	403
query55	76	75	82	75
query56	252	237	248	237
query57	1329	1142	1108	1108
query58	234	212	245	212
query59	3225	3123	3109	3109
query60	263	249	251	249
query61	106	104	101	101
query62	952	742	742	742
query63	215	186	191	186
query64	5062	689	644	644
query65	3224	3198	3273	3198
query66	1422	305	326	305
query67	15915	15704	15510	15510
query68	5993	568	554	554
query69	475	243	252	243
query70	1183	1148	1136	1136
query71	474	243	259	243
query72	6608	4187	4082	4082
query73	782	366	367	366
query74	10746	8901	8840	8840
query75	3495	2615	2659	2615
query76	3577	1128	1061	1061
query77	552	325	271	271
query78	10331	9448	9344	9344
query79	1689	597	604	597
query80	1047	418	429	418
query81	532	222	233	222
query82	948	122	117	117
query83	239	150	144	144
query84	232	72	71	71
query85	1268	312	305	305
query86	368	306	310	306
query87	4644	4528	4366	4366
query88	3461	2294	2234	2234
query89	414	305	287	287
query90	2069	187	186	186
query91	138	104	106	104
query92	67	52	53	52
query93	1158	552	558	552
query94	1135	292	277	277
query95	359	254	253	253
query96	618	289	291	289
query97	2836	2641	2645	2641
query98	217	195	202	195
query99	1674	1482	1430	1430
Total cold run time: 306578 ms
Total hot run time: 190169 ms

doris-robot · 2024-12-24T10:02:52Z

TeamCity be ut coverage result:
Function Coverage: 38.79% (10092/26015)
Line Coverage: 29.78% (85135/285869)
Region Coverage: 28.89% (43458/150406)
Branch Coverage: 25.43% (22153/87118)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2e178c32af92ffc88c69834a403ffede09707edc_2e178c32af92ffc88c69834a403ffede09707edc/report/index.html

doris-robot · 2024-12-24T10:06:43Z

ClickBench: Total hot run time: 33.06 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2e178c32af92ffc88c69834a403ffede09707edc, data reload: false
query1	0.04	0.04	0.03
query2	0.07	0.03	0.04
query3	0.23	0.07	0.07
query4	1.61	0.10	0.10
query5	0.42	0.41	0.43
query6	1.14	0.65	0.65
query7	0.02	0.01	0.02
query8	0.04	0.04	0.03
query9	0.58	0.51	0.52
query10	0.55	0.57	0.57
query11	0.13	0.10	0.10
query12	0.14	0.11	0.10
query13	0.61	0.61	0.60
query14	2.83	2.83	2.84
query15	0.90	0.82	0.83
query16	0.37	0.37	0.38
query17	1.06	1.02	1.00
query18	0.22	0.22	0.22
query19	1.88	1.76	2.06
query20	0.01	0.01	0.01
query21	15.38	0.57	0.58
query22	2.41	2.29	1.75
query23	17.15	0.91	0.98
query24	2.70	1.41	1.39
query25	0.23	0.18	0.07
query26	0.47	0.13	0.13
query27	0.04	0.05	0.05
query28	10.28	1.11	1.08
query29	12.61	3.27	3.21
query30	0.25	0.06	0.06
query31	2.86	0.39	0.37
query32	3.25	0.47	0.47
query33	3.17	3.17	3.07
query34	17.13	4.44	4.46
query35	4.58	4.49	4.54
query36	0.68	0.48	0.49
query37	0.10	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 106.53 s
Total hot run time: 33.06 s

Jibing-Li · 2024-12-24T12:27:15Z

run feut

Jibing-Li · 2024-12-24T12:43:46Z

run feut

github-actions · 2024-12-25T02:37:39Z

PR approved by at least one committer and no changes requested.

…schema.views. (#45857) ### What problem does this PR solve? Support show view definition sql in information_schema.views. Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None

…information_schema.views. #45857 (#45904) Cherry-picked from #45857 Co-authored-by: James <lijibing@selectdb.com>

…schema.views. (apache#45857) Support show view definition sql in information_schema.views. Issue Number: close #xxx Related PR: #xxx Problem Summary: None

…schema.views. (#45857) (#45930) backport: #45857

Jibing-Li marked this pull request as ready for review December 24, 2024 08:02

morrySnow added dev/2.1.x dev/3.0.x area/mysql-compatibility Issues or PRs related to the mysql compatibility labels Dec 24, 2024

morrySnow previously approved these changes Dec 24, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 24, 2024

github-actionsBot added the reviewed label Dec 24, 2024

Show view definition in information_schema.views.
2e178c3

Jibing-Li dismissed morrySnow’s stale review via 2e178c3December 24, 2024 09:25

Jibing-Li force-pushed the viewdef branch from 9d8d5eb to 2e178c3Compare December 24, 2024 09:25

github-actionsBot removed the approved Indicates a PR has been approved by one committer. label Dec 24, 2024

morrySnow approved these changes Dec 25, 2024
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 25, 2024

hubgeter approved these changes Dec 25, 2024
View reviewed changes

Jibing-Li merged commit b5644fd into apache:masterDec 25, 2024

github-actionsBot mentioned this pull request Dec 25, 2024
branch-3.0: [improvement](information_schema)Show view definition in information_schema.views. #45857 #45904
Merged

github-actionsBot added the dev/2.1.x-conflict label Dec 25, 2024

Jibing-Li added a commit that referenced this pull request Dec 25, 2024
branch-3.0: [improvement](information_schema)Show view definition in …
a88183e
…information_schema.views. #45857 (#45904) Cherry-picked from #45857 Co-authored-by: James <lijibing@selectdb.com>

Jibing-Li added dev/3.0.4-merged and removed dev/3.0.x labels Dec 25, 2024

Jibing-Li mentioned this pull request Dec 25, 2024
[improvement](information_schema)Show view definition in information_schema.views. (#45857) #45930
Merged

Jibing-Li deleted the viewdef branch December 25, 2024 15:06

Jibing-Li added a commit that referenced this pull request Dec 26, 2024
[improvement](information_schema)Show view definition in information_…
289d621
…schema.views. (#45857) (#45930) backport: #45857

Jibing-Li added dev/2.1.8-merged and removed dev/2.1.x dev/2.1.x-conflict labels Dec 26, 2024

yiguolei mentioned this pull request Jan 19, 2025
Release Note 2.1.8 #47198
Closed

gavinchou mentioned this pull request Feb 18, 2025
Release Notes 3.0.4 #48013
Closed

Uh oh!

Conversation

Jibing-Li commented Dec 24, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Dec 24, 2024

Uh oh!

Jibing-Li commented Dec 24, 2024

Uh oh!

github-actionsBot commented Dec 24, 2024

Uh oh!

github-actionsBot commented Dec 24, 2024

Uh oh!

doris-robot commented Dec 24, 2024

Uh oh!

doris-robot commented Dec 24, 2024

Uh oh!

doris-robot commented Dec 24, 2024

Uh oh!

doris-robot commented Dec 24, 2024

Uh oh!

Jibing-Li commented Dec 24, 2024

Uh oh!

doris-robot commented Dec 24, 2024

Uh oh!

doris-robot commented Dec 24, 2024

Uh oh!

doris-robot commented Dec 24, 2024

Uh oh!

doris-robot commented Dec 24, 2024

Uh oh!

Jibing-Li commented Dec 24, 2024

Uh oh!

Jibing-Li commented Dec 24, 2024

Uh oh!

github-actionsBot commented Dec 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Jibing-Li commented Dec 24, 2024•
edited
Loading