Skip to content

[Bug] Fix hard cardinality check which makes queries fail - #4678

Merged
morningman merged 2 commits into
apache:masterfrom
ccoffline:fix-cardinality-check
Oct 13, 2020
Merged

[Bug] Fix hard cardinality check which makes queries fail#4678
morningman merged 2 commits into
apache:masterfrom
ccoffline:fix-cardinality-check

Conversation

@ccoffline

@ccofflineccoffline commented Sep 27, 2020•
edited by morningman
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

#4581
fix hard Preconditions.checkState() by setting cardinality to -1 when computation is invalid.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

@ccofflineccoffline changed the title fix hard cardinality check which makes the queries failfix hard cardinality check which makes queries failSep 27, 2020
@ccofflineccoffline changed the title fix hard cardinality check which makes queries fail[Bug] Fix hard cardinality check which makes queries failSep 27, 2020
morningman
morningman reviewed Oct 4, 2020
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/planner/SelectNode.java Outdated
@morningmanmorningman added area/planner Issues or PRs related to the query planner kind/fix Categorizes issue or PR as related to a bug. labels Oct 4, 2020
@ccoffline@morningman
Update fe/fe-core/src/main/java/org/apache/doris/planner/SelectNode.java
821b5a6
Co-authored-by: Mingyu Chen <morningman.cmy@gmail.com>
morningman
morningman approved these changes Oct 12, 2020
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added the approved Indicates a PR has been approved by one committer. label Oct 12, 2020
@morningman
morningman merged commit c69fe23 into apache:masterOct 13, 2020
@yangzhgyangzhg mentioned this pull request Feb 9, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.area/plannerIssues or PRs related to the query plannerkind/fixCategorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] SelectNode.cardinality < 0 cause query exception "Unexpected exception: null"

2 participants

@ccoffline@morningman