Uh oh!
There was an error while loading. Please reload this page.
[Enhancement] (nereids)implement kill connection and query command in nereids - #46882
Merged
starocean999 merged 26 commits intoApr 3, 2025
Merged
Conversation
hello-stephen
commented
Jan 13, 2025
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
ContributorAuthor
yx-keith
commented
Jan 13, 2025
ContributorAuthor
run p0 |
yx-keith
commented
Jan 13, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Jan 13, 2025
TPC-H: Total hot run time: 33008 ms |
doris-robot
commented
Jan 13, 2025
TPC-DS: Total hot run time: 195284 ms |
doris-robot
commented
Jan 13, 2025
ClickBench: Total hot run time: 31.18 s |
doris-robot
commented
Jan 13, 2025
TPC-H: Total hot run time: 32414 ms |
doris-robot
commented
Jan 13, 2025
TPC-DS: Total hot run time: 187723 ms |
doris-robot
commented
Jan 13, 2025
ClickBench: Total hot run time: 30.95 s |
yx-keith
commented
Jan 14, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Jan 14, 2025
TPC-H: Total hot run time: 32433 ms |
doris-robot
commented
Jan 14, 2025
TPC-DS: Total hot run time: 194500 ms |
doris-robot
commented
Jan 14, 2025
ClickBench: Total hot run time: 31.68 s |
yx-keith
commented
Jan 14, 2025
ContributorAuthor
run buildall |
yx-keith
commented
Jan 14, 2025
ContributorAuthor
@hello-stephen hi can you help to review this? |
yx-keith
commented
Jan 15, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Jan 15, 2025
TPC-H: Total hot run time: 32629 ms |
doris-robot
commented
Jan 15, 2025
TPC-DS: Total hot run time: 195632 ms |
doris-robot
commented
Jan 15, 2025
ClickBench: Total hot run time: 30.68 s |
yx-keith
commented
Jan 17, 2025
ContributorAuthor
run buildall |
1 similar comment
yx-keith
commented
Jan 18, 2025
ContributorAuthor
run buildall |
yx-keith
commented
Apr 3, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Apr 3, 2025
TPC-H: Total hot run time: 34231 ms |
doris-robot
commented
Apr 3, 2025
TPC-DS: Total hot run time: 186340 ms |
doris-robot
commented
Apr 3, 2025
ClickBench: Total hot run time: 30.71 s |
yx-keith
commented
Apr 3, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Apr 3, 2025
TPC-H: Total hot run time: 34335 ms |
doris-robot
commented
Apr 3, 2025
TPC-DS: Total hot run time: 193307 ms |
doris-robot
commented
Apr 3, 2025
ClickBench: Total hot run time: 30.64 s |
starocean999
approved these changes
Apr 3, 2025
Contributor
PR approved by at least one committer and no changes requested. |
englefly
approved these changes
Apr 3, 2025
16 tasks
morningman added a commit
that referenced
this pull request
May 26, 2025
…50791) ### What problem does this PR solve? Related PR: #50776, #46882 Problem Summary: 1. Fix bug that `KILL connection_id` is not supported in Nereids This PR #46882 implements `KILL` in Nereids, but it miss the grammar `KILL connection_id` and treat it as `KILL query_id`. This PR fix it. 2. Unify the core code of `KILL` operation in both old and new planner All core logic about `kill` are moved to `KillUtils` class. So that both old and new planner and can have same logic. 3. Support Kill query by query id from all FE Previously, when executing `kill query query_id;`, Doris will only find query id in current FE. If not found, Doris will send the cancel request to all Backends to try cancelling this query. In this PR, I changed the logic. Doris will first find query id in current FE, if not found, this `kill` command will be forwarded to all other Frontends to then find it in other FEs. And Doris will no longer send the cancel request to Backend. 4. Support Kill query by trace id from all FE User can set a custom `trace id` by `set session_context="trace_id:your_trace_id"`. And this trace id will be bind to the subsequent queries in this connection. Then user can cancel the query by trace id: `KILL QUERY "trace_id"` More details can be found in user doc: apache/doris-website#2371
koarz pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
… nereids (apache#46882) Issue Number: close #[42532](apache#42532
koarz pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…pache#50791) ### What problem does this PR solve? Related PR: apache#50776, apache#46882 Problem Summary: 1. Fix bug that `KILL connection_id` is not supported in Nereids This PR apache#46882 implements `KILL` in Nereids, but it miss the grammar `KILL connection_id` and treat it as `KILL query_id`. This PR fix it. 2. Unify the core code of `KILL` operation in both old and new planner All core logic about `kill` are moved to `KillUtils` class. So that both old and new planner and can have same logic. 3. Support Kill query by query id from all FE Previously, when executing `kill query query_id;`, Doris will only find query id in current FE. If not found, Doris will send the cancel request to all Backends to try cancelling this query. In this PR, I changed the logic. Doris will first find query id in current FE, if not found, this `kill` command will be forwarded to all other Frontends to then find it in other FEs. And Doris will no longer send the cancel request to Backend. 4. Support Kill query by trace id from all FE User can set a custom `trace id` by `set session_context="trace_id:your_trace_id"`. And this trace id will be bind to the subsequent queries in this connection. Then user can cancel the query by trace id: `KILL QUERY "trace_id"` More details can be found in user doc: apache/doris-website#2371
morningman pushed a commit
to morningman/doris
that referenced
this pull request
Jun 24, 2025
… nereids (apache#46882) Issue Number: close
morningman added a commit
to morningman/doris
that referenced
this pull request
Jun 24, 2025
…pache#50791) Related PR: apache#50776, apache#46882 Problem Summary: 1. Fix bug that `KILL connection_id` is not supported in Nereids This PR apache#46882 implements `KILL` in Nereids, but it miss the grammar `KILL connection_id` and treat it as `KILL query_id`. This PR fix it. 2. Unify the core code of `KILL` operation in both old and new planner All core logic about `kill` are moved to `KillUtils` class. So that both old and new planner and can have same logic. 3. Support Kill query by query id from all FE Previously, when executing `kill query query_id;`, Doris will only find query id in current FE. If not found, Doris will send the cancel request to all Backends to try cancelling this query. In this PR, I changed the logic. Doris will first find query id in current FE, if not found, this `kill` command will be forwarded to all other Frontends to then find it in other FEs. And Doris will no longer send the cancel request to Backend. 4. Support Kill query by trace id from all FE User can set a custom `trace id` by `set session_context="trace_id:your_trace_id"`. And this trace id will be bind to the subsequent queries in this connection. Then user can cancel the query by trace id: `KILL QUERY "trace_id"` More details can be found in user doc: apache/doris-website#2371
morrySnow pushed a commit
that referenced
this pull request
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What problem does this PR solve?
Issue Number: close #42532,#42533
Related PR: NO
Problem Summary: implement kill connection and query command in nereids
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)