Skip to content

[Bug](hash) fix wrong HashLen16 implement and add cityhash64 unit test - #46928

Merged
BiteTheDDDDt merged 2 commits into
apache:masterfrom
BiteTheDDDDt:fix_0113
Jan 14, 2025
Merged

[Bug](hash) fix wrong HashLen16 implement and add cityhash64 unit test#46928
BiteTheDDDDt merged 2 commits into
apache:masterfrom
BiteTheDDDDt:fix_0113

Conversation

@BiteTheDDDDt

@BiteTheDDDDtBiteTheDDDDt commented Jan 13, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

fix wrtong HashLen16 implement and add cityhash64 unit test

HashLen16 was incorrectly modified in #35841, which would cause ngram indexes built in 2.0/2.1 to get incorrect results in 3.0

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Jan 13, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt

BiteTheDDDDt commented Jan 13, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@BiteTheDDDDt

BiteTheDDDDt commented Jan 13, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@wm1581066wm1581066 added p0_w usercase Important user case type label dev/3.0.x labels Jan 14, 2025
airborne12
airborne12 reviewed Jan 14, 2025
View reviewed changes
Comment threadbe/src/vec/common/string_ref.h
airborne12
airborne12 approved these changes Jan 14, 2025
View reviewed changes

@airborne12airborne12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jan 14, 2025
@github-actions

github-actionsBot commented Jan 14, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Jan 14, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@BiteTheDDDDtBiteTheDDDDt changed the title [Bug](hash) fix wrtong HashLen16 implement and add cityhash64 unit test[Bug](hash) fix wrong HashLen16 implement and add cityhash64 unit testJan 14, 2025
@BiteTheDDDDt
BiteTheDDDDt merged commit 6ec1a86 into apache:masterJan 14, 2025
github-actionsBot pushed a commit that referenced this pull request Jan 14, 2025
@BiteTheDDDDtYour Name
[Bug](hash) fix wrong HashLen16 implement and add cityhash64 unit test (
ee5f442
#46928)
### What problem does this PR solve?
fix wrtong HashLen16 implement and add cityhash64 unit test
HashLen16 was incorrectly modified in #35841, which would cause ngram
indexes built in 2.0/2.1 to get incorrect results in 3.0
@github-actionsgithub-actionsBot mentioned this pull request Jan 14, 2025
Merged
This was referenced Jan 14, 2025
Merged
Merged
BiteTheDDDDt added a commit that referenced this pull request Jan 14, 2025
@BiteTheDDDDt
[Chore](case) add test case for cityhash#46928(#46957)
58415c3
pick from #46928
yiguolei pushed a commit that referenced this pull request Jan 14, 2025
@BiteTheDDDDt
[Chore](case) add test case for cityhash#46928(#46958)
cc073f0
pick from #46928
BiteTheDDDDt added a commit that referenced this pull request Jan 14, 2025
@github-actions@BiteTheDDDDt
branch-3.0: [Bug](hash) fix wrong HashLen16 implement and add cityhas…
f41ac10
…h64 unit test #46928 (#46948)
Cherry-picked from #46928
Co-authored-by: Pxl <xl@selectdb.com>
BiteTheDDDDt added a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Feb 7, 2025
@BiteTheDDDDt
branch-3.0: [Bug](hash) fix wrong HashLen16 implement and add cityha…
ef47ad1
…sh64 unit test apache#46928 (apache#3721)
pick from apache#46948
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@BiteTheDDDDt@lzyy2024
[Bug](hash) fix wrong HashLen16 implement and add cityhash64 unit test (
45eb5db
apache#46928)
### What problem does this PR solve?
fix wrtong HashLen16 implement and add cityhash64 unit test
HashLen16 was incorrectly modified in apache#35841, which would cause ngram
indexes built in 2.0/2.1 to get incorrect results in 3.0
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@airborne12airborne12airborne12 approved these changes
@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.8-mergeddev/3.0.4-mergedp0_wreviewedusercaseImportant user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BiteTheDDDDt@Thearas@airborne12@yiguolei@wm1581066