Uh oh!
There was an error while loading. Please reload this page.
[fix](Nereids) fix log bug and add more numeric arithmetic function cases - #47228
Merged
Conversation
hello-stephen
commented
Jan 20, 2025
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
LiBinfeng-01
commented
Jan 21, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Jan 21, 2025
TPC-H: Total hot run time: 32455 ms |
doris-robot
commented
Jan 21, 2025
TPC-DS: Total hot run time: 195217 ms |
doris-robot
commented
Jan 21, 2025
ClickBench: Total hot run time: 30.95 s |
morrySnow
previously approved these changes
Jan 24, 2025
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
aytrack
reviewed
Jan 27, 2025
Uh oh!
There was an error while loading. Please reload this page.
aytrack
reviewed
Jan 27, 2025
Uh oh!
There was an error while loading. Please reload this page.
aytrack
reviewed
Jan 27, 2025
Uh oh!
There was an error while loading. Please reload this page.
LiBinfeng-01force-pushed
the
fix_numeric_cases
branch
from
February 10, 2025 08:46
58e41d9 to
68d85fdCompareLiBinfeng-01
commented
Feb 10, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Feb 10, 2025
TPC-H: Total hot run time: 31607 ms |
doris-robot
commented
Feb 10, 2025
TPC-DS: Total hot run time: 183573 ms |
doris-robot
commented
Feb 10, 2025
ClickBench: Total hot run time: 30.51 s |
LiBinfeng-01
commented
Feb 11, 2025
ContributorAuthor
run buildall |
doris-robot
commented
Feb 11, 2025
TPC-H: Total hot run time: 31738 ms |
doris-robot
commented
Feb 11, 2025
TPC-DS: Total hot run time: 183388 ms |
Contributor
PR approved by at least one committer and no changes requested. |
16 tasks
dataroaring pushed a commit
that referenced
this pull request
Feb 13, 2025
16 tasks
morrySnow pushed a commit
that referenced
this pull request
Feb 19, 2025
…o match with be execution behavior (#47966) ### What problem does this PR solve? Related PR: #40744, #47228 Problem Summary: When numeric function input or output out of boundary when fe folding constant, it would throw an exception before. Now we change it to match with be execution result, which is NullLiteral
github-actionsBot
pushed a commit
that referenced
this pull request
Feb 19, 2025
…o match with be execution behavior (#47966) ### What problem does this PR solve? Related PR: #40744, #47228 Problem Summary: When numeric function input or output out of boundary when fe folding constant, it would throw an exception before. Now we change it to match with be execution result, which is NullLiteral
morningman pushed a commit
to morningman/doris
that referenced
this pull request
Feb 20, 2025
…c function cases apache#47228 (apache#47749) Cherry-picked from apache#47228 Co-authored-by: LiBinfeng <libinfeng@selectdb.com>
lzyy2024 pushed a commit
to lzyy2024/doris
that referenced
this pull request
Feb 21, 2025
lzyy2024 pushed a commit
to lzyy2024/doris
that referenced
this pull request
Feb 21, 2025
…o match with be execution behavior (apache#47966) ### What problem does this PR solve? Related PR: apache#40744, apache#47228 Problem Summary: When numeric function input or output out of boundary when fe folding constant, it would throw an exception before. Now we change it to match with be execution result, which is NullLiteral
LiBinfeng-01 pushed a commit
to LiBinfeng-01/doris
that referenced
this pull request
Feb 24, 2025
…o match with be execution behavior (apache#47966) Related PR: apache#40744, apache#47228 Problem Summary: When numeric function input or output out of boundary when fe folding constant, it would throw an exception before. Now we change it to match with be execution result, which is NullLiteral
16 tasks
LiBinfeng-01 pushed a commit
to LiBinfeng-01/doris
that referenced
this pull request
Feb 25, 2025
…o match with be execution behavior (apache#47966) ### What problem does this PR solve? Related PR: apache#40744, apache#47228 Problem Summary: When numeric function input or output out of boundary when fe folding constant, it would throw an exception before. Now we change it to match with be execution result, which is NullLiteral
16 tasks
yiguolei pushed a commit
that referenced
this pull request
Feb 25, 2025
…y behavior to match with be execution behavior #47966 (#48237) pick:#47966 Related PR: #40744, #47228 Problem Summary: When numeric function input or output out of boundary when fe folding constant, it would throw an exception before. Now we change it to match with be execution result, which is NullLiteral ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
dataroaring pushed a commit
that referenced
this pull request
Feb 26, 2025
…y behavior to match with be execution behavior (#47966) (#48281) pick:#47966 ### What problem does this PR solve? Related PR: #40744, #47228 Problem Summary: When numeric function input or output out of boundary when fe folding constant, it would throw an exception before. Now we change it to match with be execution result, which is NullLiteral
Closed
deardeng pushed a commit
to deardeng/incubator-doris
that referenced
this pull request
Apr 30, 2025
…c function cases Cherry-picked from apache#47228 Co-authored-by: LiBinfeng <libinfeng@selectdb.com>
koarz pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
koarz pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…o match with be execution behavior (apache#47966) ### What problem does this PR solve? Related PR: apache#40744, apache#47228 Problem Summary: When numeric function input or output out of boundary when fe folding constant, it would throw an exception before. Now we change it to match with be execution result, which is NullLiteral
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
fix log and fmod functions and add more cases
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)