Skip to content

[fix](cloud-mow)Fix case test_cloud_mow_stream_load_with_commit_fail - #47240

Merged
zhannngchen merged 1 commit into
apache:masterfrom
hust-hhb:fix-case-0120
Jan 24, 2025
Merged

[fix](cloud-mow)Fix case test_cloud_mow_stream_load_with_commit_fail#47240
zhannngchen merged 1 commit into
apache:masterfrom
hust-hhb:fix-case-0120

Conversation

@hust-hhb

@hust-hhbhust-hhb commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

Fix case test_cloud_mow_stream_load_with_commit_fail

Issue Number: close #xxx

Related PR: #45673

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hust-hhb

hust-hhb commented Jan 20, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

zhannngchen
zhannngchen approved these changes Jan 20, 2025
View reviewed changes

@zhannngchenzhannngchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jan 20, 2025
@github-actions

github-actionsBot commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Jan 20, 2025
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhannngchen
zhannngchen merged commit 622ca48 into apache:masterJan 24, 2025
github-actionsBot pushed a commit that referenced this pull request Jan 24, 2025
@hust-hhbYour Name
[fix](cloud-mow)Fix case test_cloud_mow_stream_load_with_commit_fail (#…
bc9949d
…47240)
Fix case test_cloud_mow_stream_load_with_commit_fail
@github-actionsgithub-actionsBot mentioned this pull request Jan 24, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jan 26, 2025
@github-actions@hust-hhb
branch-3.0: [fix](cloud-mow)Fix case test_cloud_mow_stream_load_with_…
ac412b3
…commit_fail #47240 (#47435)
Cherry-picked from #47240
Co-authored-by: huanghaibin <huanghaibin@selectdb.com>
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@hust-hhb@lzyy2024
[fix](cloud-mow)Fix case test_cloud_mow_stream_load_with_commit_fail (a…
5ab389a
…pache#47240)
Fix case test_cloud_mow_stream_load_with_commit_fail
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@hust-hhbkoarz
[fix](cloud-mow)Fix case test_cloud_mow_stream_load_with_commit_fail (a…
8c72a6e
…pache#47240)
Fix case test_cloud_mow_stream_load_with_commit_fail
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhannngchenzhannngchenzhannngchen approved these changes
@dataroaringdataroaringdataroaring approved these changes
@gavinchougavinchouAwaiting requested review from gavinchougavinchou is a code owner
@w41terw41terAwaiting requested review from w41ter

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.4-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hust-hhb@Thearas@zhannngchen@dataroaring