Skip to content

[fix](UT) Fix cloud UT network_util_test and resource_test - #47582

Merged
hello-stephen merged 2 commits into
apache:masterfrom
gavinchou:gavin-fix-cloud-ut
Feb 8, 2025
Merged

[fix](UT) Fix cloud UT network_util_test and resource_test#47582
hello-stephen merged 2 commits into
apache:masterfrom
gavinchou:gavin-fix-cloud-ut

Conversation

@gavinchou

@gavinchougavinchou commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Related PR: #45255

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou

gavinchou commented Feb 7, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

deardeng
deardeng approved these changes Feb 7, 2025
View reviewed changes

@deardengdeardeng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

hello-stephen
hello-stephen previously approved these changes Feb 7, 2025
View reviewed changes
@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Feb 7, 2025
@github-actions

github-actionsBot commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot removed the approved Indicates a PR has been approved by one committer. label Feb 8, 2025
@gavinchou

gavinchou commented Feb 8, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Feb 8, 2025

Copy link
Copy Markdown

TeamCity cloud ut coverage result:
Function Coverage: 82.38% (1061/1288)
Line Coverage: 65.90% (17553/26635)
Region Coverage: 65.42% (8660/13237)
Branch Coverage: 55.29% (4668/8442)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3ba5508d911a08ba7905051e1feff9885c529998_3ba5508d911a08ba7905051e1feff9885c529998_cloud/report/index.html

@gavinchougavinchou changed the title [fix](UT) Fix cloud UT network_util_test[fix](UT) Fix cloud UT network_util_test and resource_testFeb 8, 2025
@hello-stephen

hello-stephen commented Feb 8, 2025

Copy link
Copy Markdown
Contributor

skip buildall

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Feb 8, 2025
@github-actions

github-actionsBot commented Feb 8, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

dataroaring
dataroaring approved these changes Feb 8, 2025
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hello-stephen
hello-stephen merged commit c689789 into apache:masterFeb 8, 2025
github-actionsBot pushed a commit that referenced this pull request Feb 8, 2025
@gavinchouYour Name
[fix](UT) Fix cloud UT network_util_test and resource_test (#47582)
ea255db
### What problem does this PR solve?
Related PR: #45255
@github-actionsgithub-actionsBot mentioned this pull request Feb 8, 2025
Merged
hello-stephen added a commit that referenced this pull request Feb 8, 2025
@github-actions@gavinchou@hello-stephen
branch-3.0: [fix](UT) Fix cloud UT network_util_test and resource_test…
7a4ea1a
…#47582 (#47641)
Cherry-picked from #47582
Co-authored-by: Gavin Chou <gavin@selectdb.com>
Co-authored-by: Dongyang Li <lidongyang@selectdb.com>
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@gavinchou@lzyy2024
[fix](UT) Fix cloud UT network_util_test and resource_test (apache#47582
18fce35
)
### What problem does this PR solve?
Related PR: apache#45255
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@gavinchoukoarz
[fix](UT) Fix cloud UT network_util_test and resource_test (apache#47582
629a14e
)
### What problem does this PR solve?
Related PR: apache#45255
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deardengdeardengdeardeng approved these changes
@w41terw41terw41ter approved these changes
@hello-stephenhello-stephenhello-stephen approved these changes
@Yukang-LianYukang-LianYukang-Lian approved these changes
@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/3.0.4-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gavinchou@hello-stephen@doris-robot@deardeng@w41ter@Yukang-Lian@dataroaring@wm1581066