Skip to content

[Bug] Fix some date functions to make their result same as MySQL - #4786

Merged
morningman merged 2 commits into
apache:masterfrom
morningman:ut_failed
Oct 27, 2020
Merged

[Bug] Fix some date functions to make their result same as MySQL#4786
morningman merged 2 commits into
apache:masterfrom
morningman:ut_failed

Conversation

@morningman

@morningmanmorningman commented Oct 25, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

dayofweek, dayofmonth, dayofyear, weekofyear, timediff

Also fix ut compilation problem

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

@morningmanmorningman added kind/fix Categorizes issue or PR as related to a bug. area/mysql-compatibility Issues or PRs related to the mysql compatibility area/sql/function Issues or PRs related to the SQL functions labels Oct 25, 2020
@morningmanmorningman self-assigned this Oct 25, 2020
kangkaisen
kangkaisen reviewed Oct 26, 2020
View reviewed changes
Comment threadbe/src/exprs/timestamp_functions.cpp
kangkaisen
kangkaisen approved these changes Oct 26, 2020
View reviewed changes

@kangkaisenkangkaisen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kangkaisenkangkaisen added the approved Indicates a PR has been approved by one committer. label Oct 26, 2020
@morningman
morningman merged commit bfdb15c into apache:masterOct 27, 2020
@yangzhgyangzhg mentioned this pull request Feb 9, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kangkaisenkangkaisenkangkaisen approved these changes

Assignees

@morningmanmorningman

Labels

approvedIndicates a PR has been approved by one committer.area/mysql-compatibilityIssues or PRs related to the mysql compatibilityarea/sql/functionIssues or PRs related to the SQL functionskind/fixCategorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Function "dayofweek"'s result is not same as MySQL's

3 participants

@morningman@kangkaisen@morningman-cmy