Uh oh!
There was an error while loading. Please reload this page.
[Fix](merge-on-write) should calculate delete bitmaps between segments before skip if tablet is in NOT_READY state in flush phase - #48056
Conversation
Thearas
commented
Feb 19, 2025
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
bobhan1
commented
Feb 19, 2025
run buildall |
doris-robot
commented
Feb 19, 2025
TPC-H: Total hot run time: 31769 ms |
doris-robot
commented
Feb 19, 2025
TPC-DS: Total hot run time: 184031 ms |
doris-robot
commented
Feb 19, 2025
ClickBench: Total hot run time: 30.25 s |
doris-robot
commented
Feb 19, 2025
TeamCity be ut coverage result: |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
…s before skip if tablet is in `NOT_READY` state in flush phase (apache#48056) Problem Summary: considering the following situation: 1. heavy sc start on BE and change tablet's state to `NOT_READY` 2. load1 skip to calculate delete bitmaps in flush phase because the tablet's state is `NOT_READY` 3. heavy sc finished and change tablet's state to `RUNNING` 4. load1 calculate delete bitmaps in publish phase for converted historical rowsets If load1 write multi segments, this will cause duplicate key because it forget to calculate delete bitmaps between segments in any phase.
…s before skip if tablet is in `NOT_READY` state in flush phase (apache#48056) Problem Summary: considering the following situation: 1. heavy sc start on BE and change tablet's state to `NOT_READY` 2. load1 skip to calculate delete bitmaps in flush phase because the tablet's state is `NOT_READY` 3. heavy sc finished and change tablet's state to `RUNNING` 4. load1 calculate delete bitmaps in publish phase for converted historical rowsets If load1 write multi segments, this will cause duplicate key because it forget to calculate delete bitmaps between segments in any phase.
…s before skip if tablet is in `NOT_READY` state in flush phase (apache#48056) Problem Summary: considering the following situation: 1. heavy sc start on BE and change tablet's state to `NOT_READY` 2. load1 skip to calculate delete bitmaps in flush phase because the tablet's state is `NOT_READY` 3. heavy sc finished and change tablet's state to `RUNNING` 4. load1 calculate delete bitmaps in publish phase for converted historical rowsets If load1 write multi segments, this will cause duplicate key because it forget to calculate delete bitmaps between segments in any phase.
…s before skip if tablet is in `NOT_READY` state in flush phase (apache#48056) ### What problem does this PR solve? Problem Summary: considering the following situation: 1. heavy sc start on BE and change tablet's state to `NOT_READY` 2. load1 skip to calculate delete bitmaps in flush phase because the tablet's state is `NOT_READY` 3. heavy sc finished and change tablet's state to `RUNNING` 4. load1 calculate delete bitmaps in publish phase for converted historical rowsets If load1 write multi segments, this will cause duplicate key because it forget to calculate delete bitmaps between segments in any phase.
…s before skip if tablet is in `NOT_READY` state in flush phase (apache#48056) ### What problem does this PR solve? Problem Summary: considering the following situation: 1. heavy sc start on BE and change tablet's state to `NOT_READY` 2. load1 skip to calculate delete bitmaps in flush phase because the tablet's state is `NOT_READY` 3. heavy sc finished and change tablet's state to `RUNNING` 4. load1 calculate delete bitmaps in publish phase for converted historical rowsets If load1 write multi segments, this will cause duplicate key because it forget to calculate delete bitmaps between segments in any phase.
…s between segmens before skip if tablet is in `NOT_READY` state in flush phase (apache#48056) (apache#48089) (apache#334) pick apache#48056
What problem does this PR solve?
Problem Summary:
considering the following situation:
NOT_READYNOT_READYRUNNINGIf load1 write multi segments, this will cause duplicate key because it forget to calculate delete bitmaps between segments in any phase.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)