Skip to content

branch-3.0: [fix](nereids)check if correlated filter exists before converting apply to join #47985 - #48088

Merged
dataroaring merged 1 commit into
branch-3.0from
auto-pick-47985-branch-3.0
Feb 24, 2025
Merged

branch-3.0: [fix](nereids)check if correlated filter exists before converting apply to join #47985#48088
dataroaring merged 1 commit into
branch-3.0from
auto-pick-47985-branch-3.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

Cherry-picked from #47985

@starocean999Your Name
[fix](nereids)check if correlated filter exists before converting app…
5f18cb4
…ly to join (#47985)
example sql:
`SELECT *
FROM t1
WHERE t1.x IN (SELECT x FROM t2 WHERE t1.y is NULL AND t1.y is NOT NULL);`
the correlated filter `t1.y is NULL AND t1.y is NOT NULL` will be
replaced as `FALSE` by SimplifyConflictCompound rule. So we need check
if correlated filter exists before converting apply to join
Related PR: (#47385)
@hello-stephen

hello-stephen commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

hello-stephen commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

run buildall

dataroaring
dataroaring approved these changes Feb 24, 2025
View reviewed changes

@dataroaringdataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Feb 24, 2025
@github-actions

github-actionsBot commented Feb 24, 2025

Copy link
Copy Markdown
ContributorAuthor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Feb 24, 2025

Copy link
Copy Markdown
ContributorAuthor

PR approved by anyone and no changes requested.

@dataroaring
dataroaring merged commit 320d2c0 into branch-3.0Feb 24, 2025
@github-actions
github-actionsBot deleted the auto-pick-47985-branch-3.0 branch February 24, 2025 03:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaringdataroaringdataroaring approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hello-stephen@dataroaring@starocean999