Skip to content

[Compaction][Bug-Fix] Fix bug that meta lock need to be held when calculating compaction score - #4829

Merged
morningman merged 2 commits into
apache:masterfrom
morningman:compaction_score_lock
Nov 5, 2020
Merged

[Compaction][Bug-Fix] Fix bug that meta lock need to be held when calculating compaction score#4829
morningman merged 2 commits into
apache:masterfrom
morningman:compaction_score_lock

Conversation

@morningman

@morningmanmorningman commented Nov 2, 2020

Copy link
Copy Markdown
Contributor

Proposed changes

We need to hold the tablet's meta lock when calculating the compaction score

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

@morningmanmorningman added kind/fix Categorizes issue or PR as related to a bug. area/compact Issues or PRs related to the compact labels Nov 2, 2020
@morningmanmorningman self-assigned this Nov 2, 2020
@morningmanmorningman changed the title [Compaction][Buf] Fix bug that meta lock need to be held when calculating compaction score[Compaction][Bug] Fix bug that meta lock need to be held when calculating compaction scoreNov 4, 2020
@wuyunfengwuyunfeng changed the title [Compaction][Bug] Fix bug that meta lock need to be held when calculating compaction score[Compaction][Bug-Fix] Fix bug that meta lock need to be held when calculating compaction scoreNov 4, 2020
EmmyMiao87
EmmyMiao87 approved these changes Nov 5, 2020
View reviewed changes

@EmmyMiao87EmmyMiao87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
morningman merged commit f239f44 into apache:masterNov 5, 2020
@yangzhgyangzhg mentioned this pull request Feb 9, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmmyMiao87EmmyMiao87EmmyMiao87 approved these changes

Assignees

@morningmanmorningman

Labels

area/compactIssues or PRs related to the compactkind/fixCategorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Compaction cause BE crash

3 participants

@morningman@EmmyMiao87@morningman-cmy