Skip to content

[fix](cold hot separation) Fix the issue of root_path not working in HDFS resource - #48441

Merged
yiguolei merged 8 commits into
apache:branch-2.1from
yagagagaga:fix_cold_hot_hdfs_policy
Jun 20, 2025
Merged

[fix](cold hot separation) Fix the issue of root_path not working in HDFS resource#48441
yiguolei merged 8 commits into
apache:branch-2.1from
yagagagaga:fix_cold_hot_hdfs_policy

Conversation

@yagagagaga

@yagagagagayagagagaga commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

before:

CREATE RESOURCE "remote_hdfs" PROPERTIES (
"type"="hdfs",
"fs.defaultFS"="192.168.0.1:8020",
"hadoop.username"="hdfs",
"root_path"="/user/hdfs"-- not working 👎
);

after:

be.conf

enable_root_path_of_hdfs_resource=true

and then

CREATE RESOURCE "remote_hdfs" PROPERTIES (
"type"="hdfs",
"fs.defaultFS"="192.168.0.1:8020",
"hadoop.username"="hdfs",
"root_path"="/user/hdfs"-- working 👍
);

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

also pick #48452

@Thearas

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yagagagaga

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 0.00% (0/12) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage36.59% (9635/26330)
Line Coverage28.19% (79969/283674)
Region Coverage26.82% (40981/152827)
Branch Coverage23.56% (20774/88164)

@wm1581066wm1581066 added usercase Important user case type label dev/2.1.x labels Feb 28, 2025
@yagagagaga
yagagagaga marked this pull request as draft March 3, 2025 02:22
@yagagagaga
yagagagaga marked this pull request as ready for review March 24, 2025 07:04
@yagagagaga

Copy link
Copy Markdown
ContributorAuthor

run buildall

@yagagagaga

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/6) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage37.40% (9852/26343)
Line Coverage29.10% (82582/283770)
Region Coverage27.70% (42342/152855)
Branch Coverage24.45% (21552/88160)

dataroaring pushed a commit that referenced this pull request Mar 25, 2025
…th the previous behavior of HDFS resource if upgrading from v2.1 (#49400)
Related PR: #48441
@yagagagaga

Copy link
Copy Markdown
ContributorAuthor

run p0

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jun 12, 2025
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei
yiguolei merged commit ab48d63 into apache:branch-2.1Jun 20, 2025
@yagagagaga
yagagagaga deleted the fix_cold_hot_hdfs_policy branch July 15, 2025 12:51
@yiguoleiyiguolei mentioned this pull request Aug 11, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.11-mergedreviewedusercaseImportant user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@yagagagaga@Thearas@doris-robot@hello-stephen@gavinchou@yiguolei@wm1581066@dataroaring