Uh oh!
There was an error while loading. Please reload this page.
[fix](Prepared Statment) Fix exec prepared insert stmt in non master error - #48689
Conversation
Thearas
commented
Mar 5, 2025
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
594e881 to
bf60474ComparemorrySnow
commented
Mar 5, 2025
run buildall |
doris-robot
commented
Mar 5, 2025
TeamCity cloud ut coverage result: |
doris-robot
commented
Mar 5, 2025
TPC-H: Total hot run time: 32623 ms |
doris-robot
commented
Mar 5, 2025
TPC-DS: Total hot run time: 185542 ms |
doris-robot
commented
Mar 5, 2025
ClickBench: Total hot run time: 30.67 s |
hello-stephen
commented
Mar 5, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
bf60474 to
0890506Compareliutang123
commented
Mar 6, 2025
run buildall |
doris-robot
commented
Mar 6, 2025
TeamCity cloud ut coverage result: |
doris-robot
commented
Mar 6, 2025
TPC-H: Total hot run time: 32943 ms |
doris-robot
commented
Mar 6, 2025
TPC-DS: Total hot run time: 192046 ms |
doris-robot
commented
Mar 6, 2025
ClickBench: Total hot run time: 31.41 s |
liutang123
commented
Mar 6, 2025
I test this pr, and it works well in my cluster. |
liutang123
commented
Mar 6, 2025
run beut |
doris-robot
commented
Mar 6, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
eldenmoon
left a comment
There was a problem hiding this comment.
please add test case? example pick none master frontend and send insert/delete/update prepared requests
liutang123
commented
Mar 7, 2025
The pipeline doris cluster has only one FE. |
902b363 to
c5cbffcCompareeldenmoon
commented
Mar 7, 2025
run buildall |
…error (apache#48689) When client send a prepare command to non master frontend like `INSERT INTO xxxx VALUES(?)` and then execute it whith some params. The non master frontend will forward the origin stmt to master and analyze error will occur. In this PR, we forward the origin sql and param to master. Master prepare a logic plan with place holder and then use the param and logic plan to generate physical plan.
…error (apache#48689) When client send a prepare command to non master frontend like `INSERT INTO xxxx VALUES(?)` and then execute it whith some params. The non master frontend will forward the origin stmt to master and analyze error will occur. In this PR, we forward the origin sql and param to master. Master prepare a logic plan with place holder and then use the param and logic plan to generate physical plan.
…error (apache#48689) When client send a prepare command to non master frontend like `INSERT INTO xxxx VALUES(?)` and then execute it whith some params. The non master frontend will forward the origin stmt to master and analyze error will occur. In this PR, we forward the origin sql and param to master. Master prepare a logic plan with place holder and then use the param and logic plan to generate physical plan.
…error (apache#48689) When client send a prepare command to non master frontend like `INSERT INTO xxxx VALUES(?)` and then execute it whith some params. The non master frontend will forward the origin stmt to master and analyze error will occur. In this PR, we forward the origin sql and param to master. Master prepare a logic plan with place holder and then use the param and logic plan to generate physical plan.
… non master error (apache#48689) (apache#52266) backport: apache#48689 Co-authored-by: Lijia Liu <liutang123@yeah.net>
What problem does this PR solve?
When client send a prepare command to non master frontend like
INSERT INTO xxxx VALUES(?)and then execute it whith some params.The non master frontend will forward the origin stmt to master and analyze error will occur.
In this PR, we forward the origin sql and param to master. Master prepare a logic plan with place holder and then use the param and logic plan to generate physical plan.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)