[fix](nereids)avoid generate Runtime filter whose target is not a base table column by englefly · Pull Request #48804 · apache/doris

englefly · 2025-03-07T03:25:21Z

What problem does this PR solve?

avoid generate wrong rf for pattern

join(#5=#8)
--> join(#7=#6)
-->project(null as #5, #7)
--->scan(t1)
-->project(#6)
-->scan(T2[#5, #6])
-->scan(T3[#8])

RF(#8->#5) should not be generated.
but current version, we set RF taget to T2.#5

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-03-07T03:25:28Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

englefly · 2025-03-07T03:25:33Z

run buildall

doris-robot · 2025-03-07T03:47:20Z

TPC-H: Total hot run time: 32366 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 428595db0d6fc73888477c09f4b7611261733bf2, data reload: false
------ Round 1 ----------------------------------
q1	17593	5247	5115	5115
q2	2051	288	172	172
q3	10403	1303	680	680
q4	10222	991	522	522
q5	7519	2382	2339	2339
q6	186	167	145	145
q7	908	747	600	600
q8	9312	1195	1047	1047
q9	4989	4805	4747	4747
q10	6812	2305	1893	1893
q11	486	279	266	266
q12	348	351	211	211
q13	17752	3667	3059	3059
q14	226	221	213	213
q15	550	503	478	478
q16	647	633	579	579
q17	575	867	347	347
q18	7223	6508	6342	6342
q19	1223	932	533	533
q20	313	326	191	191
q21	2798	2130	1915	1915
q22	1054	1044	972	972
Total cold run time: 103190 ms
Total hot run time: 32366 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5221	5185	5178	5178
q2	243	324	236	236
q3	2161	2674	2281	2281
q4	1416	1833	1358	1358
q5	4232	4076	4136	4076
q6	204	160	124	124
q7	1844	1878	1776	1776
q8	2555	2627	2575	2575
q9	7167	7199	7122	7122
q10	2978	3167	2792	2792
q11	598	522	506	506
q12	693	743	598	598
q13	3408	3816	3375	3375
q14	288	306	301	301
q15	524	483	478	478
q16	640	674	637	637
q17	1132	1547	1382	1382
q18	7753	7465	7595	7465
q19	785	811	916	811
q20	2057	2067	1906	1906
q21	5452	4794	4931	4794
q22	1092	1028	982	982
Total cold run time: 52443 ms
Total hot run time: 50753 ms

doris-robot · 2025-03-07T03:58:52Z

TPC-DS: Total hot run time: 184336 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 428595db0d6fc73888477c09f4b7611261733bf2, data reload: false
query1	972	393	388	388
query2	6527	1902	1912	1902
query3	6786	221	216	216
query4	26912	23781	22958	22958
query5	4396	696	505	505
query6	308	200	185	185
query7	4610	510	299	299
query8	298	242	240	240
query9	8606	2554	2517	2517
query10	478	302	262	262
query11	15441	15064	15057	15057
query12	158	109	108	108
query13	1658	513	401	401
query14	9241	6218	6325	6218
query15	219	196	173	173
query16	7638	640	493	493
query17	1198	727	561	561
query18	1944	417	307	307
query19	206	199	166	166
query20	122	114	119	114
query21	214	125	107	107
query22	4153	4276	4242	4242
query23	34189	32886	32975	32886
query24	8329	2356	2379	2356
query25	529	479	394	394
query26	1227	273	155	155
query27	2707	502	323	323
query28	4316	2383	2402	2383
query29	698	556	439	439
query30	278	209	194	194
query31	953	863	747	747
query32	81	67	66	66
query33	552	360	307	307
query34	789	856	500	500
query35	813	814	714	714
query36	948	992	851	851
query37	115	98	76	76
query38	4144	4157	4034	4034
query39	1452	1390	1396	1390
query40	213	112	102	102
query41	54	54	55	54
query42	126	107	106	106
query43	511	505	452	452
query44	1303	817	773	773
query45	176	171	164	164
query46	830	1021	629	629
query47	1755	1788	1724	1724
query48	384	403	292	292
query49	788	519	422	422
query50	666	743	398	398
query51	4174	4198	4119	4119
query52	108	101	91	91
query53	227	258	184	184
query54	477	490	417	417
query55	87	81	84	81
query56	276	255	244	244
query57	1098	1137	1070	1070
query58	238	232	236	232
query59	2498	2799	2445	2445
query60	297	289	252	252
query61	124	125	121	121
query62	788	757	694	694
query63	238	185	187	185
query64	4241	996	659	659
query65	4456	4344	4325	4325
query66	1091	411	321	321
query67	15855	15439	15170	15170
query68	7917	899	515	515
query69	464	293	265	265
query70	1146	1135	1054	1054
query71	460	282	269	269
query72	5748	3556	3704	3556
query73	773	707	340	340
query74	9153	9036	8913	8913
query75	3793	3201	2716	2716
query76	3705	1203	745	745
query77	797	386	285	285
query78	9967	10232	9244	9244
query79	2017	865	586	586
query80	620	534	445	445
query81	476	261	220	220
query82	465	128	93	93
query83	168	175	171	171
query84	249	102	71	71
query85	814	351	314	314
query86	340	311	278	278
query87	4402	4485	4332	4332
query88	3198	2190	2182	2182
query89	392	312	290	290
query90	1930	206	244	206
query91	144	138	108	108
query92	80	64	57	57
query93	1131	1061	579	579
query94	661	405	301	301
query95	354	270	251	251
query96	476	564	269	269
query97	3259	3377	3275	3275
query98	227	206	198	198
query99	1454	1417	1248	1248
Total cold run time: 274064 ms
Total hot run time: 184336 ms

doris-robot · 2025-03-07T04:04:12Z

ClickBench: Total hot run time: 30.88 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 428595db0d6fc73888477c09f4b7611261733bf2, data reload: false
query1	0.03	0.03	0.03
query2	0.07	0.04	0.03
query3	0.24	0.07	0.06
query4	1.80	0.11	0.11
query5	0.56	0.59	0.55
query6	1.18	0.72	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.59	0.52	0.52
query10	0.58	0.59	0.58
query11	0.16	0.11	0.10
query12	0.15	0.11	0.12
query13	0.62	0.61	0.61
query14	2.68	2.75	2.71
query15	0.91	0.85	0.86
query16	0.37	0.38	0.38
query17	1.03	1.06	1.02
query18	0.21	0.20	0.19
query19	1.94	1.99	1.78
query20	0.02	0.01	0.01
query21	15.35	0.91	0.56
query22	0.76	1.21	0.66
query23	14.93	1.38	0.63
query24	7.39	1.57	0.78
query25	0.49	0.16	0.09
query26	0.64	0.18	0.14
query27	0.05	0.05	0.05
query28	9.41	0.81	0.42
query29	12.58	4.01	3.35
query30	0.25	0.10	0.07
query31	2.82	0.57	0.39
query32	3.23	0.56	0.46
query33	3.06	3.01	3.00
query34	15.77	5.13	4.51
query35	4.57	4.58	4.57
query36	0.66	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.18	0.13	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.03
query43	0.03	0.03	0.03
Total cold run time: 105.66 s
Total hot run time: 30.88 s

morrySnow

could u add a test case? maybe a ut is a better way

…is not a base table column (#48779) ### What problem does this PR solve? pick #48804 Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test  - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason  - Behavior changed: - [ ] No. - [ ] Yes.  - Does this need documentation? - [ ] No. - [ ] Yes.  ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label

englefly · 2025-03-13T06:09:52Z

run buildall

englefly · 2025-03-13T06:13:02Z

run buildall

englefly · 2025-03-13T07:09:30Z

run buildall

doris-robot · 2025-03-13T07:58:43Z

TPC-H: Total hot run time: 35435 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9926a5dd98ff5fdbf1242d6c7e94f07250cc0c6d, data reload: false
------ Round 1 ----------------------------------
q1	17601	5301	5133	5133
q2	2042	292	164	164
q3	10538	1233	769	769
q4	10233	1865	1362	1362
q5	7657	2453	2323	2323
q6	190	161	129	129
q7	914	774	622	622
q8	9289	1329	1107	1107
q9	5025	4861	4730	4730
q10	6809	2319	1889	1889
q11	474	284	254	254
q12	345	363	217	217
q13	17801	3743	3095	3095
q14	228	226	218	218
q15	533	485	476	476
q16	618	616	589	589
q17	587	893	341	341
q18	6758	6550	6367	6367
q19	1626	964	565	565
q20	347	350	220	220
q21	4566	4065	3896	3896
q22	1063	1073	969	969
Total cold run time: 105244 ms
Total hot run time: 35435 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5198	5128	5188	5128
q2	239	329	249	249
q3	2162	2711	2324	2324
q4	1434	1814	1405	1405
q5	4237	4294	4400	4294
q6	223	169	130	130
q7	1995	1927	1798	1798
q8	2661	2680	2619	2619
q9	7119	7254	7262	7254
q10	2940	3111	2838	2838
q11	603	525	487	487
q12	731	755	611	611
q13	3546	3972	3304	3304
q14	292	316	281	281
q15	532	469	471	469
q16	642	689	666	666
q17	1162	1611	1382	1382
q18	7759	7710	7664	7664
q19	841	830	873	830
q20	1984	2031	1923	1923
q21	5310	4799	4925	4799
q22	1123	1057	1025	1025
Total cold run time: 52733 ms
Total hot run time: 51480 ms

github-actions · 2025-03-13T08:24:18Z

PR approved by at least one committer and no changes requested.

englefly · 2025-03-19T06:22:36Z

run buildall

doris-robot · 2025-03-19T07:06:02Z

TPC-H: Total hot run time: 32517 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 56ace85573914a8c434fced367248d1c230429a3, data reload: false
------ Round 1 ----------------------------------
q1	23866	5100	5059	5059
q2	2041	281	180	180
q3	10396	1238	678	678
q4	10220	1028	539	539
q5	7533	2375	2321	2321
q6	187	163	132	132
q7	900	746	614	614
q8	9311	1288	1065	1065
q9	5073	4931	4858	4858
q10	6807	2277	1893	1893
q11	477	266	262	262
q12	358	350	216	216
q13	17773	3723	3104	3104
q14	235	216	206	206
q15	502	474	468	468
q16	644	636	584	584
q17	559	848	339	339
q18	6755	6485	6332	6332
q19	1201	953	558	558
q20	316	334	210	210
q21	2826	2166	1920	1920
q22	1037	1061	979	979
Total cold run time: 109017 ms
Total hot run time: 32517 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5199	5164	5172	5164
q2	233	322	231	231
q3	2131	2655	2267	2267
q4	1397	1790	1360	1360
q5	4214	4109	4277	4109
q6	216	169	129	129
q7	2000	1933	1734	1734
q8	2593	2581	2521	2521
q9	7185	7172	7217	7172
q10	2997	3219	2694	2694
q11	563	504	487	487
q12	707	766	617	617
q13	3557	3867	3316	3316
q14	291	294	276	276
q15	525	489	478	478
q16	651	713	636	636
q17	1141	1591	1335	1335
q18	7716	7691	7389	7389
q19	842	844	823	823
q20	1968	2008	1873	1873
q21	5490	4767	4902	4767
q22	1111	1072	1065	1065
Total cold run time: 52727 ms
Total hot run time: 50443 ms

doris-robot · 2025-03-19T07:17:53Z

TPC-DS: Total hot run time: 191875 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 56ace85573914a8c434fced367248d1c230429a3, data reload: false
query1	1405	1069	1036	1036
query2	6204	1940	1932	1932
query3	11112	4826	4493	4493
query4	26029	24100	23348	23348
query5	5413	669	497	497
query6	328	200	202	200
query7	3987	495	300	300
query8	317	283	266	266
query9	8519	2630	2622	2622
query10	484	305	258	258
query11	15622	15213	14809	14809
query12	174	115	104	104
query13	1572	522	394	394
query14	9082	6232	6609	6232
query15	217	186	169	169
query16	7537	651	487	487
query17	1085	732	566	566
query18	2058	413	324	324
query19	192	211	159	159
query20	128	122	130	122
query21	204	125	103	103
query22	4553	4547	4482	4482
query23	34183	33501	33374	33374
query24	7879	2403	2393	2393
query25	510	465	394	394
query26	1176	279	159	159
query27	2662	481	334	334
query28	4887	2470	2441	2441
query29	720	576	437	437
query30	272	219	194	194
query31	932	871	784	784
query32	74	66	63	63
query33	550	383	299	299
query34	825	853	506	506
query35	817	850	779	779
query36	971	1025	903	903
query37	115	101	77	77
query38	4258	4149	4050	4050
query39	1501	1453	1437	1437
query40	211	121	108	108
query41	88	50	50	50
query42	121	104	107	104
query43	527	514	499	499
query44	1334	810	797	797
query45	191	177	166	166
query46	854	1036	643	643
query47	1855	1905	1810	1810
query48	389	409	302	302
query49	788	520	416	416
query50	718	766	433	433
query51	4337	4323	4291	4291
query52	105	107	94	94
query53	243	269	193	193
query54	493	496	419	419
query55	85	74	82	74
query56	286	267	254	254
query57	1187	1218	1122	1122
query58	259	238	245	238
query59	2900	2776	2755	2755
query60	291	279	264	264
query61	120	118	124	118
query62	785	736	668	668
query63	233	189	190	189
query64	4024	1052	678	678
query65	4689	4505	4476	4476
query66	979	411	352	352
query67	16061	15688	15374	15374
query68	8369	817	496	496
query69	489	320	265	265
query70	1181	1081	1065	1065
query71	396	295	269	269
query72	5571	3481	3820	3481
query73	722	711	345	345
query74	9054	8979	9154	8979
query75	3200	3153	2658	2658
query76	3152	1174	736	736
query77	487	371	284	284
query78	9950	10100	9352	9352
query79	1918	816	597	597
query80	649	517	430	430
query81	464	273	221	221
query82	306	135	102	102
query83	236	173	155	155
query84	240	95	76	76
query85	739	341	296	296
query86	384	305	293	293
query87	4416	4447	4276	4276
query88	2875	2250	2256	2250
query89	396	309	291	291
query90	1984	208	219	208
query91	137	136	105	105
query92	74	61	58	58
query93	2251	1035	568	568
query94	676	412	295	295
query95	356	268	273	268
query96	480	554	274	274
query97	3258	3409	3288	3288
query98	220	211	197	197
query99	1344	1380	1283	1283
Total cold run time: 278681 ms
Total hot run time: 191875 ms

doris-robot · 2025-03-19T07:23:12Z

ClickBench: Total hot run time: 31.52 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 56ace85573914a8c434fced367248d1c230429a3, data reload: false
query1	0.04	0.04	0.03
query2	0.12	0.10	0.11
query3	0.24	0.18	0.18
query4	1.60	0.19	0.20
query5	0.59	0.58	0.59
query6	1.19	0.72	0.71
query7	0.02	0.02	0.01
query8	0.05	0.03	0.03
query9	0.57	0.52	0.52
query10	0.57	0.60	0.55
query11	0.16	0.10	0.11
query12	0.15	0.11	0.11
query13	0.62	0.59	0.61
query14	2.71	2.87	2.72
query15	0.93	0.86	0.84
query16	0.38	0.38	0.38
query17	1.02	1.04	1.04
query18	0.21	0.19	0.19
query19	1.89	1.96	1.75
query20	0.01	0.02	0.02
query21	15.36	0.87	0.54
query22	0.77	1.17	0.67
query23	14.94	1.41	0.64
query24	6.42	2.19	1.17
query25	0.48	0.20	0.14
query26	0.67	0.16	0.12
query27	0.04	0.05	0.04
query28	9.76	0.89	0.44
query29	12.52	4.03	3.33
query30	0.25	0.09	0.07
query31	2.83	0.60	0.38
query32	3.22	0.54	0.46
query33	3.04	3.01	3.03
query34	15.83	5.17	4.55
query35	4.56	4.55	4.58
query36	0.66	0.48	0.47
query37	0.09	0.06	0.07
query38	0.04	0.04	0.04
query39	0.02	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.02
Total cold run time: 104.88 s
Total hot run time: 31.52 s

englefly · 2025-03-20T05:03:23Z

run buildall

doris-robot · 2025-03-20T05:24:58Z

TPC-H: Total hot run time: 32508 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 56ace85573914a8c434fced367248d1c230429a3, data reload: false
------ Round 1 ----------------------------------
q1	24406	5131	5047	5047
q2	2056	320	190	190
q3	10367	1241	706	706
q4	10237	992	558	558
q5	7555	2401	2349	2349
q6	192	161	132	132
q7	899	757	609	609
q8	9325	1312	1016	1016
q9	5045	4795	4855	4795
q10	6813	2312	1877	1877
q11	509	283	264	264
q12	349	351	219	219
q13	17767	3663	3112	3112
q14	235	225	209	209
q15	541	480	477	477
q16	620	631	578	578
q17	595	873	348	348
q18	6769	6559	6343	6343
q19	1215	951	554	554
q20	321	341	201	201
q21	2976	2136	1948	1948
q22	1027	976	983	976
Total cold run time: 109819 ms
Total hot run time: 32508 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5178	5126	5148	5126
q2	250	328	233	233
q3	2178	2679	2304	2304
q4	1457	1830	1437	1437
q5	4240	4136	4492	4136
q6	219	168	126	126
q7	2044	1935	1766	1766
q8	2678	2570	2627	2570
q9	7146	7205	7045	7045
q10	3005	3212	2749	2749
q11	568	521	492	492
q12	714	758	612	612
q13	3542	3935	3326	3326
q14	292	284	264	264
q15	525	470	487	470
q16	634	681	663	663
q17	1130	1637	1355	1355
q18	7839	7704	7525	7525
q19	830	783	813	783
q20	1996	2034	1874	1874
q21	5442	4830	4716	4716
q22	1077	1023	1042	1023
Total cold run time: 52984 ms
Total hot run time: 50595 ms

doris-robot · 2025-03-20T05:36:29Z

TPC-DS: Total hot run time: 185081 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 56ace85573914a8c434fced367248d1c230429a3, data reload: false
query1	1023	495	468	468
query2	6579	1905	1906	1905
query3	6793	219	224	219
query4	26506	23537	22976	22976
query5	4382	672	511	511
query6	308	194	186	186
query7	4601	494	293	293
query8	294	248	246	246
query9	8601	2602	2594	2594
query10	448	313	256	256
query11	15450	15164	14879	14879
query12	153	108	103	103
query13	1643	534	381	381
query14	9705	6794	6350	6350
query15	208	192	176	176
query16	7715	630	464	464
query17	1167	694	543	543
query18	1972	388	306	306
query19	190	183	157	157
query20	121	117	114	114
query21	208	119	105	105
query22	4296	4183	4277	4183
query23	34430	33037	33153	33037
query24	7704	2377	2366	2366
query25	521	447	394	394
query26	1232	280	156	156
query27	2153	480	326	326
query28	3929	2399	2372	2372
query29	718	557	414	414
query30	283	210	193	193
query31	928	899	759	759
query32	75	67	69	67
query33	567	369	304	304
query34	796	835	502	502
query35	809	812	753	753
query36	983	988	887	887
query37	121	101	72	72
query38	4248	4226	4225	4225
query39	1496	1385	1381	1381
query40	201	119	104	104
query41	53	62	60	60
query42	122	103	102	102
query43	511	516	481	481
query44	1287	810	791	791
query45	177	172	168	168
query46	829	1005	616	616
query47	1747	1780	1726	1726
query48	372	423	297	297
query49	783	491	419	419
query50	694	714	399	399
query51	4194	4172	4151	4151
query52	98	101	97	97
query53	227	254	191	191
query54	483	496	408	408
query55	85	86	79	79
query56	275	270	257	257
query57	1121	1145	1052	1052
query58	246	232	234	232
query59	2591	2706	2558	2558
query60	283	265	255	255
query61	125	124	118	118
query62	786	699	720	699
query63	228	185	192	185
query64	4269	993	671	671
query65	4444	4420	4352	4352
query66	1063	405	298	298
query67	15909	15559	15198	15198
query68	8005	861	491	491
query69	461	307	273	273
query70	1197	1150	1102	1102
query71	418	282	262	262
query72	5545	3570	3742	3570
query73	734	729	342	342
query74	9048	9336	8705	8705
query75	3360	3163	2700	2700
query76	3329	1178	764	764
query77	680	375	301	301
query78	10071	10011	9296	9296
query79	2122	935	583	583
query80	672	521	449	449
query81	488	264	222	222
query82	196	131	100	100
query83	178	174	153	153
query84	246	94	74	74
query85	753	350	303	303
query86	377	296	299	296
query87	4458	4469	4438	4438
query88	3565	2219	2237	2219
query89	382	313	288	288
query90	1977	213	210	210
query91	136	147	113	113
query92	76	60	58	58
query93	2154	1065	573	573
query94	653	428	296	296
query95	352	263	259	259
query96	491	559	276	276
query97	3229	3391	3339	3339
query98	237	223	198	198
query99	1310	1415	1241	1241
Total cold run time: 273459 ms
Total hot run time: 185081 ms

doris-robot · 2025-03-20T05:41:50Z

ClickBench: Total hot run time: 30.89 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 56ace85573914a8c434fced367248d1c230429a3, data reload: false
query1	0.04	0.04	0.04
query2	0.12	0.11	0.10
query3	0.26	0.19	0.19
query4	1.59	0.19	0.11
query5	0.57	0.55	0.54
query6	1.18	0.72	0.72
query7	0.03	0.01	0.02
query8	0.04	0.03	0.04
query9	0.59	0.53	0.51
query10	0.61	0.58	0.59
query11	0.15	0.11	0.10
query12	0.15	0.12	0.11
query13	0.61	0.60	0.61
query14	2.80	2.74	2.73
query15	0.95	0.85	0.85
query16	0.39	0.39	0.38
query17	1.01	1.02	1.07
query18	0.21	0.20	0.20
query19	2.07	1.89	1.78
query20	0.01	0.01	0.01
query21	15.36	0.92	0.58
query22	0.75	1.32	0.69
query23	14.79	1.40	0.65
query24	6.82	1.74	0.48
query25	0.50	0.23	0.17
query26	0.69	0.17	0.15
query27	0.05	0.04	0.04
query28	9.46	0.91	0.44
query29	12.55	3.96	3.33
query30	0.24	0.08	0.06
query31	2.83	0.59	0.39
query32	3.23	0.56	0.46
query33	3.06	2.99	3.03
query34	15.77	5.10	4.52
query35	4.54	4.53	4.53
query36	0.67	0.49	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.14	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.18 s
Total hot run time: 30.89 s

github-actions · 2025-03-20T08:08:58Z

PR approved by at least one committer and no changes requested.

…e table column (#48804) ### What problem does this PR solve? avoid generate wrong rf for pattern ``` join(#5=#8) --> join(#7=#6) -->project(null as #5, #7) --->scan(t1) -->project(#6) -->scan(T2[#5, #6]) -->scan(T3[#8]) ``` `RF(#8->#5)` should not be generated. but current version, we set RF taget to `T2.#5`

…e table column (apache#48804) ### What problem does this PR solve? avoid generate wrong rf for pattern ``` join(apache#5=apache#8) --> join(apache#7=apache#6) -->project(null as apache#5, apache#7) --->scan(t1) -->project(apache#6) -->scan(T2[apache#5, apache#6]) -->scan(T3[apache#8]) ``` `RF(apache#8->apache#5)` should not be generated. but current version, we set RF taget to `T2.apache#5`

…s not a base table column #48804 (#49314)

…is not a base table column #48804 (#49310) Cherry-picked from #48804 Co-authored-by: minghong <zhouminghong@selectdb.com>

englefly · 2025-04-27T01:24:43Z

pick for branch 2.1 #49314

…e table column (apache#48804) ### What problem does this PR solve? avoid generate wrong rf for pattern ``` join(apache#5=apache#8) --> join(apache#7=apache#6) -->project(null as apache#5, apache#7) --->scan(t1) -->project(apache#6) -->scan(T2[apache#5, apache#6]) -->scan(T3[apache#8]) ``` `RF(apache#8->apache#5)` should not be generated. but current version, we set RF taget to `T2.apache#5`

englefly mentioned this pull request Mar 7, 2025
branch-2.1 [fix](nereids) avoid generate Runtime filter whose target is not a base table column #48779
Merged
16 tasks

englefly added dev/2.1.x dev/3.0.x dev/3.1.x labels Mar 7, 2025

morrySnow added the p0_b label Mar 7, 2025

morrySnow reviewed Mar 7, 2025
View reviewed changes

englefly removed the dev/3.1.x label Mar 7, 2025

yiguolei added dev/2.1.9-merged and removed dev/2.1.x labels Mar 10, 2025

englefly closed this Mar 13, 2025

englefly reopened this Mar 13, 2025

morrySnow added dev/2.1.x and removed dev/2.1.9-merged labels Mar 13, 2025

morrySnow reviewed Mar 13, 2025
View reviewed changes

Comment thread...core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterPushDownVisitor.java

reject dangling rf target
819b9f8

englefly force-pushed the rf-null-master branch from 98ecaba to 819b9f8Compare March 13, 2025 06:09

reject pushdown if taget is not plan.output
9926a5d

morrySnow previously approved these changes Mar 13, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 13, 2025

starocean999 approved these changes Mar 20, 2025
View reviewed changes

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Mar 20, 2025

LiBinfeng-01 approved these changes Mar 20, 2025
View reviewed changes

englefly merged commit c525ec5 into apache:masterMar 20, 2025

englefly deleted the rf-null-master branch March 20, 2025 08:13

github-actionsBot mentioned this pull request Mar 20, 2025
branch-3.0: [fix](nereids)avoid generate Runtime filter whose target is not a base table column #48804 #49310
Merged

github-actionsBot mentioned this pull request Mar 20, 2025
branch-2.1: [fix](nereids)avoid generate Runtime filter whose target is not a base table column #48804 #49311
Closed

englefly mentioned this pull request Mar 20, 2025
branch-2.1 [fix](nereids)avoid generate Runtime filter whose target is not a base table column #48804 #49314
Merged
16 tasks

yiguolei pushed a commit that referenced this pull request Mar 27, 2025
branch-2.1 [fix](nereids)avoid generate Runtime filter whose target i…
374b901
…s not a base table column #48804 (#49314)

morrySnow added dev/2.1.9-merged and removed dev/2.1.x labels Apr 1, 2025

yiguolei added dev/2.1.10-merged and removed dev/2.1.9-merged labels Apr 2, 2025

dataroaring pushed a commit that referenced this pull request Apr 7, 2025
branch-3.0: [fix](nereids)avoid generate Runtime filter whose target …
99c6e1f
…is not a base table column #48804 (#49310) Cherry-picked from #48804 Co-authored-by: minghong <zhouminghong@selectdb.com>

dataroaring added dev/3.0.5-merged and removed dev/3.0.x labels Apr 7, 2025

Uh oh!

Conversation

englefly commented Mar 7, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Mar 7, 2025

Uh oh!

englefly commented Mar 7, 2025

Uh oh!

doris-robot commented Mar 7, 2025

Uh oh!

doris-robot commented Mar 7, 2025

Uh oh!

doris-robot commented Mar 7, 2025

Uh oh!

morrySnow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

englefly commented Mar 13, 2025

Uh oh!

englefly commented Mar 13, 2025

Uh oh!

englefly commented Mar 13, 2025

Uh oh!

doris-robot commented Mar 13, 2025

Uh oh!

github-actionsBot commented Mar 13, 2025

Uh oh!

englefly commented Mar 19, 2025

Uh oh!

doris-robot commented Mar 19, 2025

Uh oh!

doris-robot commented Mar 19, 2025

Uh oh!

doris-robot commented Mar 19, 2025

Uh oh!

englefly commented Mar 20, 2025

Uh oh!

doris-robot commented Mar 20, 2025

Uh oh!

doris-robot commented Mar 20, 2025

Uh oh!

doris-robot commented Mar 20, 2025

Uh oh!

github-actionsBot commented Mar 20, 2025

Uh oh!

englefly commented Apr 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

englefly commented Mar 7, 2025•
edited
Loading