Skip to content

[opt](inverted index) uniform profile naming convention - #48826

Merged
qidaye merged 1 commit into
apache:masterfrom
zzzxl1993:202503071706
Mar 12, 2025
Merged

[opt](inverted index) uniform profile naming convention#48826
qidaye merged 1 commit into
apache:masterfrom
zzzxl1993:202503071706

Conversation

@zzzxl1993

@zzzxl1993zzzxl1993 commented Mar 7, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zzzxl1993

zzzxl1993 commented Mar 7, 2025

Copy link
Copy Markdown
ContributorAuthor

run buildall

@doris-robot

doris-robot commented Mar 7, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 32639 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 709a050d7f63d7b6d75f1ef59b07fd853fc0f4af, data reload: false
------ Round 1 ----------------------------------
q1	17565	5148	5089	5089
q2	2043	286	176	176
q3	10422	1369	692	692
q4	10218	1010	514	514
q5	7540	2388	2360	2360
q6	187	166	134	134
q7	909	739	592	592
q8	9298	1243	1118	1118
q9	5174	4704	5009	4704
q10	6849	2318	1899	1899
q11	489	279	267	267
q12	344	349	214	214
q13	17786	3661	3067	3067
q14	223	235	215	215
q15	526	490	476	476
q16	633	619	597	597
q17	600	863	355	355
q18	6759	6548	6486	6486
q19	1206	941	533	533
q20	313	322	188	188
q21	2964	2095	1959	1959
q22	1107	1020	1004	1004
Total cold run time: 103155 ms
Total hot run time: 32639 ms
----- Round 2, with runtime_filter_mode=off -----
q1	5124	5092	5088	5088
q2	229	330	226	226
q3	2144	2652	2294	2294
q4	1437	1803	1360	1360
q5	4266	4098	4117	4098
q6	209	161	122	122
q7	1877	1913	1796	1796
q8	2604	2615	2570	2570
q9	7296	7243	7226	7226
q10	3008	3173	2763	2763
q11	611	491	497	491
q12	681	784	617	617
q13	3488	3846	3293	3293
q14	276	315	262	262
q15	518	485	472	472
q16	649	667	617	617
q17	1149	1586	1353	1353
q18	7810	7781	7438	7438
q19	826	821	866	821
q20	1965	2064	1873	1873
q21	5362	4943	4912	4912
q22	1136	1073	1008	1008
Total cold run time: 52665 ms
Total hot run time: 50700 ms

@doris-robot

doris-robot commented Mar 7, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 186269 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 709a050d7f63d7b6d75f1ef59b07fd853fc0f4af, data reload: false
query1	979	408	388	388
query2	6535	1876	1887	1876
query3	6792	230	214	214
query4	26504	23877	23327	23327
query5	4309	653	486	486
query6	315	208	194	194
query7	4622	515	300	300
query8	313	250	241	241
query9	8651	2525	2523	2523
query10	485	308	256	256
query11	15688	15153	15032	15032
query12	165	113	108	108
query13	1668	518	402	402
query14	9320	6426	6556	6426
query15	213	197	189	189
query16	7288	645	492	492
query17	1207	739	572	572
query18	1948	411	337	337
query19	186	191	148	148
query20	118	112	117	112
query21	203	119	103	103
query22	4236	4298	4327	4298
query23	33876	33176	33007	33007
query24	7725	2401	2428	2401
query25	563	449	379	379
query26	1236	270	155	155
query27	2132	489	322	322
query28	3906	2401	2366	2366
query29	745	561	429	429
query30	285	219	191	191
query31	967	866	772	772
query32	74	69	67	67
query33	552	366	305	305
query34	773	845	500	500
query35	779	818	754	754
query36	950	974	889	889
query37	123	102	78	78
query38	4196	4221	4201	4201
query39	1426	1384	1389	1384
query40	210	117	103	103
query41	55	51	53	51
query42	125	108	104	104
query43	491	513	482	482
query44	1272	785	778	778
query45	169	171	160	160
query46	832	1017	616	616
query47	1779	1829	1749	1749
query48	369	402	302	302
query49	778	518	422	422
query50	673	738	403	403
query51	4143	4176	4091	4091
query52	134	102	95	95
query53	228	252	188	188
query54	497	475	424	424
query55	83	85	82	82
query56	258	269	269	269
query57	1124	1118	1079	1079
query58	239	232	233	232
query59	2675	2612	2618	2612
query60	288	286	253	253
query61	124	119	114	114
query62	821	721	682	682
query63	231	188	194	188
query64	4331	1016	736	736
query65	4420	4355	4336	4336
query66	1154	400	309	309
query67	15739	15726	15209	15209
query68	8018	882	510	510
query69	464	297	252	252
query70	1190	1106	1137	1106
query71	447	305	261	261
query72	6006	3572	3484	3484
query73	770	739	345	345
query74	8906	9107	8978	8978
query75	3678	3198	2692	2692
query76	3577	1175	742	742
query77	780	379	294	294
query78	10106	10034	9371	9371
query79	2935	887	591	591
query80	739	521	464	464
query81	500	258	228	228
query82	689	124	96	96
query83	207	174	159	159
query84	290	96	74	74
query85	780	373	392	373
query86	388	319	279	279
query87	4436	4513	4438	4438
query88	3830	2256	2255	2255
query89	424	318	300	300
query90	1829	218	218	218
query91	144	143	112	112
query92	85	63	55	55
query93	2348	1059	586	586
query94	668	428	295	295
query95	360	278	267	267
query96	495	578	278	278
query97	3338	3449	3372	3372
query98	248	204	205	204
query99	1452	1409	1297	1297
Total cold run time: 275422 ms
Total hot run time: 186269 ms

@doris-robot

doris-robot commented Mar 7, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 31.17 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 709a050d7f63d7b6d75f1ef59b07fd853fc0f4af, data reload: false
query1	0.03	0.04	0.04
query2	0.07	0.04	0.03
query3	0.23	0.07	0.07
query4	1.61	0.10	0.10
query5	0.56	0.54	0.55
query6	1.20	0.72	0.72
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.59	0.52	0.51
query10	0.57	0.64	0.58
query11	0.16	0.10	0.11
query12	0.15	0.11	0.11
query13	0.62	0.62	0.60
query14	2.67	2.83	2.82
query15	0.93	0.86	0.85
query16	0.38	0.40	0.39
query17	1.00	1.03	1.02
query18	0.21	0.19	0.19
query19	1.94	1.82	1.99
query20	0.01	0.02	0.01
query21	15.35	0.89	0.56
query22	0.76	1.26	0.73
query23	14.77	1.41	0.63
query24	7.58	0.97	0.72
query25	0.51	0.27	0.11
query26	0.62	0.16	0.14
query27	0.05	0.05	0.05
query28	9.32	0.92	0.46
query29	12.54	4.02	3.29
query30	0.24	0.09	0.06
query31	2.82	0.64	0.40
query32	3.22	0.56	0.46
query33	3.00	3.12	3.04
query34	15.76	5.19	4.57
query35	4.62	4.60	4.62
query36	0.67	0.50	0.48
query37	0.10	0.06	0.06
query38	0.06	0.04	0.04
query39	0.04	0.02	0.03
query40	0.18	0.13	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.02	0.03
Total cold run time: 105.37 s
Total hot run time: 31.17 s

@doris-robot

doris-robot commented Mar 7, 2025

Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage46.86% (12533/26744)
Line Coverage36.45% (106834/293115)
Region Coverage35.49% (54566/153757)
Branch Coverage30.84% (27441/88972)

airborne12
airborne12 approved these changes Mar 12, 2025
View reviewed changes

@airborne12airborne12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Mar 12, 2025
@github-actions

github-actionsBot commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

qidaye
qidaye approved these changes Mar 12, 2025
View reviewed changes

@qidayeqidaye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qidaye
qidaye merged commit dc74f68 into apache:masterMar 12, 2025
github-actionsBot pushed a commit that referenced this pull request Mar 12, 2025
@zzzxl1993Your Name
[opt](inverted index) uniform profile naming convention (#48826)
1d7e883
@github-actionsgithub-actionsBot mentioned this pull request Mar 12, 2025
Merged
yiguolei pushed a commit that referenced this pull request Mar 14, 2025
@github-actions@zzzxl1993
branch-2.1: [opt](inverted index) uniform profile naming convention#…
ad6cf63
…48826 (#48975)
Cherry-picked from #48826
Co-authored-by: zzzxl <yangsiyu@selectdb.com>
airborne12 pushed a commit to airborne12/apache-doris that referenced this pull request May 14, 2025
@zzzxl1993@airborne12
[opt](inverted index) uniform profile naming convention (apache#48826)
ae4aa1b
@airborne12airborne12 mentioned this pull request May 14, 2025
Closed
zzzxl1993 added a commit to zzzxl1993/doris that referenced this pull request May 14, 2025
@zzzxl1993
[opt](inverted index) uniform profile naming convention (apache#48826)
5daa1c3
@zzzxl1993zzzxl1993 mentioned this pull request May 14, 2025
Merged
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@zzzxl1993koarz
[opt](inverted index) uniform profile naming convention (apache#48826)
84a88e5
dataroaring pushed a commit to airborne12/apache-doris that referenced this pull request Jun 11, 2025
@zzzxl1993@dataroaring
[opt](inverted index) uniform profile naming convention (apache#48826)
1a157f5
zzzxl1993 added a commit to zzzxl1993/doris that referenced this pull request Jun 26, 2025
@zzzxl1993
[opt](inverted index) uniform profile naming convention (apache#48826)
9864f51
@zzzxl1993zzzxl1993 mentioned this pull request Jun 26, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jun 27, 2025
@zzzxl1993
branch-3.1: [fix](inverted index) enhance inverted index profile#47504
c306240
#48826#48950 (#52377)
Cherry-picked
#47504#48826#48950
dataroaring pushed a commit that referenced this pull request Jun 27, 2025
@zzzxl1993
[opt](inverted index) enhance inverted index profile (#50876)
3d43145
pick #47504
pick #48826
pick #48950
koarz pushed a commit to koarz/doris that referenced this pull request Jul 3, 2025
@zzzxl1993koarz
[opt](inverted index) enhance inverted index profile (apache#50876)
8b9be16
pick apache#47504
pick apache#48826
pick apache#48950
@gavinchougavinchou mentioned this pull request Aug 15, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@airborne12airborne12airborne12 approved these changes
@qidayeqidayeqidaye approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.dev/2.1.9-mergeddev/3.0.7-mergeddev/3.1.0-mergedreviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@zzzxl1993@Thearas@doris-robot@airborne12@qidaye@yiguolei@dataroaring@morrySnow