Skip to content

branch-2.1: [fix](Nereids) deep copy for LogicalWindow is wrong #48861 - #49014

Merged
yiguolei merged 1 commit into
branch-2.1from
auto-pick-48861-branch-2.1
Mar 19, 2025
Merged

branch-2.1: [fix](Nereids) deep copy for LogicalWindow is wrong #48861#49014
yiguolei merged 1 commit into
branch-2.1from
auto-pick-48861-branch-2.1

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Mar 13, 2025

Copy link
Copy Markdown
Contributor

Cherry-picked from #48861

@Thearas

Thearas commented Mar 13, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Thearas

Thearas commented Mar 13, 2025

Copy link
Copy Markdown
Contributor

run buildall

@morrySnow
[fix](Nereids) deep copy for LogicalWindow is wrong (#48861)
95f99c1
Related PR: #21727#14397
Problem Summary:
1. forgot to copy isChecked flag in LogicalWindow when do deep copy
2. implement LogicalWindow To PhyscialWindow should not check isChecked
flag
This PR:
1. check deep copy for all plan node
2. remove check isChecked in LogicalWindow To PhyscialWindow
@morrySnow
morrySnowforce-pushed the auto-pick-48861-branch-2.1 branch from 4f60e47 to 95f99c1CompareMarch 13, 2025 08:03
@morrySnow

morrySnow commented Mar 13, 2025

Copy link
Copy Markdown
Contributor

run buildall

@yiguolei
yiguolei merged commit a32a7ba into branch-2.1Mar 19, 2025
@github-actions
github-actionsBot deleted the auto-pick-48861-branch-2.1 branch March 19, 2025 01:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Thearas@morrySnow@yiguolei@dataroaring